Complete implementation of signal-aware context propagation for graceful cancellation across all commands and storage operations. Key changes: 1. Signal-aware contexts (bd-rtp): - Added rootCtx/rootCancel in main.go using signal.NotifyContext() - Set up in PersistentPreRun, cancelled in PersistentPostRun - Daemon uses same pattern in runDaemonLoop() - Handles SIGINT/SIGTERM for graceful shutdown 2. Context propagation (bd-yb8): - All commands now use rootCtx instead of context.Background() - sqlite.New() receives context for cancellable operations - Database operations respect context cancellation - Storage layer propagates context through all queries 3. Cancellation tests (bd-2o2): - Added import_cancellation_test.go with comprehensive tests - Added export cancellation test in export_test.go - Tests verify database integrity after cancellation - All cancellation tests passing Fixes applied during review: - Fixed rootCtx lifecycle (removed premature defer from PersistentPreRun) - Fixed test context contamination (reset rootCtx in test cleanup) - Fixed export tests missing context setup Impact: - Pressing Ctrl+C during import/export now cancels gracefully - No database corruption or hanging transactions - Clean shutdown of all operations Tested: - go build ./cmd/bd ✓ - go test ./cmd/bd -run TestImportCancellation ✓ - go test ./cmd/bd -run TestExportCommand ✓ - Manual Ctrl+C testing verified 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
237 lines
5.4 KiB
Go
237 lines
5.4 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/steveyegge/beads/internal/storage/sqlite"
|
|
"github.com/steveyegge/beads/internal/types"
|
|
)
|
|
|
|
func TestEpicCommand(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
|
|
|
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
sqliteStore, err := sqlite.New(context.Background(), dbPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer sqliteStore.Close()
|
|
|
|
ctx := context.Background()
|
|
|
|
// Set issue_prefix
|
|
if err := sqliteStore.SetConfig(ctx, "issue_prefix", "test"); err != nil {
|
|
t.Fatalf("Failed to set issue_prefix: %v", err)
|
|
}
|
|
|
|
// Create an epic with children
|
|
epic := &types.Issue{
|
|
ID: "test-epic-1",
|
|
Title: "Test Epic",
|
|
Description: "Epic description",
|
|
Status: types.StatusOpen,
|
|
Priority: 1,
|
|
IssueType: types.TypeEpic,
|
|
CreatedAt: time.Now(),
|
|
}
|
|
|
|
if err := sqliteStore.CreateIssue(ctx, epic, "test"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create child tasks
|
|
child1 := &types.Issue{
|
|
Title: "Child Task 1",
|
|
Status: types.StatusClosed,
|
|
Priority: 2,
|
|
IssueType: types.TypeTask,
|
|
CreatedAt: time.Now(),
|
|
ClosedAt: ptrTime(time.Now()),
|
|
}
|
|
|
|
child2 := &types.Issue{
|
|
Title: "Child Task 2",
|
|
Status: types.StatusOpen,
|
|
Priority: 2,
|
|
IssueType: types.TypeTask,
|
|
CreatedAt: time.Now(),
|
|
}
|
|
|
|
if err := sqliteStore.CreateIssue(ctx, child1, "test"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := sqliteStore.CreateIssue(ctx, child2, "test"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Add parent-child dependencies
|
|
dep1 := &types.Dependency{
|
|
IssueID: child1.ID,
|
|
DependsOnID: epic.ID,
|
|
Type: types.DepParentChild,
|
|
}
|
|
dep2 := &types.Dependency{
|
|
IssueID: child2.ID,
|
|
DependsOnID: epic.ID,
|
|
Type: types.DepParentChild,
|
|
}
|
|
|
|
if err := sqliteStore.AddDependency(ctx, dep1, "test"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := sqliteStore.AddDependency(ctx, dep2, "test"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Test GetEpicsEligibleForClosure
|
|
store = sqliteStore
|
|
daemonClient = nil
|
|
|
|
epics, err := sqliteStore.GetEpicsEligibleForClosure(ctx)
|
|
if err != nil {
|
|
t.Fatalf("GetEpicsEligibleForClosure failed: %v", err)
|
|
}
|
|
|
|
if len(epics) != 1 {
|
|
t.Errorf("Expected 1 epic, got %d", len(epics))
|
|
}
|
|
|
|
if len(epics) > 0 {
|
|
epicStatus := epics[0]
|
|
if epicStatus.Epic.ID != "test-epic-1" {
|
|
t.Errorf("Expected epic ID test-epic-1, got %s", epicStatus.Epic.ID)
|
|
}
|
|
if epicStatus.TotalChildren != 2 {
|
|
t.Errorf("Expected 2 total children, got %d", epicStatus.TotalChildren)
|
|
}
|
|
if epicStatus.ClosedChildren != 1 {
|
|
t.Errorf("Expected 1 closed child, got %d", epicStatus.ClosedChildren)
|
|
}
|
|
if epicStatus.EligibleForClose {
|
|
t.Error("Epic should not be eligible for close with open children")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestEpicCommandInit(t *testing.T) {
|
|
if epicCmd == nil {
|
|
t.Fatal("epicCmd should be initialized")
|
|
}
|
|
|
|
if epicCmd.Use != "epic" {
|
|
t.Errorf("Expected Use='epic', got %q", epicCmd.Use)
|
|
}
|
|
|
|
// Check that subcommands exist
|
|
var hasStatusCmd bool
|
|
for _, cmd := range epicCmd.Commands() {
|
|
if cmd.Use == "status" {
|
|
hasStatusCmd = true
|
|
}
|
|
}
|
|
|
|
if !hasStatusCmd {
|
|
t.Error("epic command should have status subcommand")
|
|
}
|
|
}
|
|
|
|
func TestEpicEligibleForClose(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
|
|
|
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
sqliteStore, err := sqlite.New(context.Background(), dbPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer sqliteStore.Close()
|
|
|
|
ctx := context.Background()
|
|
|
|
// Set issue_prefix
|
|
if err := sqliteStore.SetConfig(ctx, "issue_prefix", "test"); err != nil {
|
|
t.Fatalf("Failed to set issue_prefix: %v", err)
|
|
}
|
|
|
|
// Create an epic where all children are closed
|
|
epic := &types.Issue{
|
|
ID: "test-epic-2",
|
|
Title: "Fully Completed Epic",
|
|
Description: "Epic description",
|
|
Status: types.StatusOpen,
|
|
Priority: 1,
|
|
IssueType: types.TypeEpic,
|
|
CreatedAt: time.Now(),
|
|
}
|
|
|
|
if err := sqliteStore.CreateIssue(ctx, epic, "test"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create all closed children
|
|
for i := 1; i <= 3; i++ {
|
|
child := &types.Issue{
|
|
Title: fmt.Sprintf("Child Task %d", i),
|
|
Status: types.StatusClosed,
|
|
Priority: 2,
|
|
IssueType: types.TypeTask,
|
|
CreatedAt: time.Now(),
|
|
ClosedAt: ptrTime(time.Now()),
|
|
}
|
|
if err := sqliteStore.CreateIssue(ctx, child, "test"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Add parent-child dependency
|
|
dep := &types.Dependency{
|
|
IssueID: child.ID,
|
|
DependsOnID: epic.ID,
|
|
Type: types.DepParentChild,
|
|
}
|
|
if err := sqliteStore.AddDependency(ctx, dep, "test"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
// Test GetEpicsEligibleForClosure
|
|
epics, err := sqliteStore.GetEpicsEligibleForClosure(ctx)
|
|
if err != nil {
|
|
t.Fatalf("GetEpicsEligibleForClosure failed: %v", err)
|
|
}
|
|
|
|
// Find our epic
|
|
var epicStatus *types.EpicStatus
|
|
for _, e := range epics {
|
|
if e.Epic.ID == "test-epic-2" {
|
|
epicStatus = e
|
|
break
|
|
}
|
|
}
|
|
|
|
if epicStatus == nil {
|
|
t.Fatal("Epic test-epic-2 not found in results")
|
|
}
|
|
|
|
if epicStatus.TotalChildren != 3 {
|
|
t.Errorf("Expected 3 total children, got %d", epicStatus.TotalChildren)
|
|
}
|
|
if epicStatus.ClosedChildren != 3 {
|
|
t.Errorf("Expected 3 closed children, got %d", epicStatus.ClosedChildren)
|
|
}
|
|
if !epicStatus.EligibleForClose {
|
|
t.Error("Epic should be eligible for close when all children are closed")
|
|
}
|
|
}
|