b855c444d4
- Enabled errcheck linter (previously disabled)
- Set tests: false in .golangci.yml to focus on production code
- Fixed 27 errcheck warnings using Go best practices:
* Database resources: defer func() { _ = rows.Close() }()
* Transaction rollbacks: defer func() { _ = tx.Rollback() }()
* Best-effort closers: _ = store.Close(), _ = client.Close()
* File writes: proper error checking on Close()
* Interactive input: handle EOF gracefully
* File ops: ignore ENOENT on os.Remove()
- All tests pass
- Closes bd-58
Amp-Thread-ID: https://ampcode.com/threads/T-57c9afd3-9adf-40c2-8be7-3e493d200361
Co-authored-by: Amp <amp@ampcode.com>
93 lines
2.2 KiB
Go
93 lines
2.2 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/steveyegge/beads"
|
|
"github.com/steveyegge/beads/internal/rpc"
|
|
)
|
|
|
|
var (
|
|
// Version is the current version of bd (overridden by ldflags at build time)
|
|
Version = "0.17.1"
|
|
// Build can be set via ldflags at compile time
|
|
Build = "dev"
|
|
)
|
|
|
|
var versionCmd = &cobra.Command{
|
|
Use: "version",
|
|
Short: "Print version information",
|
|
Run: func(cmd *cobra.Command, args []string) {
|
|
checkDaemon, _ := cmd.Flags().GetBool("daemon")
|
|
|
|
if checkDaemon {
|
|
showDaemonVersion()
|
|
return
|
|
}
|
|
|
|
if jsonOutput {
|
|
outputJSON(map[string]string{
|
|
"version": Version,
|
|
"build": Build,
|
|
})
|
|
} else {
|
|
fmt.Printf("bd version %s (%s)\n", Version, Build)
|
|
}
|
|
},
|
|
}
|
|
|
|
func showDaemonVersion() {
|
|
// Connect to daemon (PersistentPreRun skips version command)
|
|
// We need to find the database path first to get the socket path
|
|
if dbPath == "" {
|
|
// Use public API to find database (same logic as PersistentPreRun)
|
|
if foundDB := beads.FindDatabasePath(); foundDB != "" {
|
|
dbPath = foundDB
|
|
}
|
|
}
|
|
|
|
socketPath := getSocketPath()
|
|
client, err := rpc.TryConnect(socketPath)
|
|
if err != nil || client == nil {
|
|
fmt.Fprintf(os.Stderr, "Error: daemon is not running\n")
|
|
fmt.Fprintf(os.Stderr, "Hint: start daemon with 'bd daemon'\n")
|
|
os.Exit(1)
|
|
}
|
|
defer func() { _ = client.Close() }()
|
|
|
|
health, err := client.Health()
|
|
if err != nil {
|
|
fmt.Fprintf(os.Stderr, "Error checking daemon health: %v\n", err)
|
|
os.Exit(1)
|
|
}
|
|
|
|
if jsonOutput {
|
|
outputJSON(map[string]interface{}{
|
|
"daemon_version": health.Version,
|
|
"client_version": Version,
|
|
"compatible": health.Compatible,
|
|
"daemon_uptime": health.Uptime,
|
|
})
|
|
} else {
|
|
fmt.Printf("Daemon version: %s\n", health.Version)
|
|
fmt.Printf("Client version: %s\n", Version)
|
|
if health.Compatible {
|
|
fmt.Printf("Compatibility: ✓ compatible\n")
|
|
} else {
|
|
fmt.Printf("Compatibility: ✗ incompatible (restart daemon recommended)\n")
|
|
}
|
|
fmt.Printf("Daemon uptime: %.1f seconds\n", health.Uptime)
|
|
}
|
|
|
|
if !health.Compatible {
|
|
os.Exit(1)
|
|
}
|
|
}
|
|
|
|
func init() {
|
|
versionCmd.Flags().Bool("daemon", false, "Check daemon version and compatibility")
|
|
rootCmd.AddCommand(versionCmd)
|
|
}
|