Files

Steve Yegge 0f4b03e262 Optimize test suite: split integration tests, add -short support

- Split slow importer integration tests into separate file
- Add t.Short() guards to 10 slow daemon tests
- Document test organization in TEST_OPTIMIZATION.md
- Fast tests now run in ~50s vs 3+ minutes
- Use 'go test -short ./...' for fast feedback

Amp-Thread-ID: https://ampcode.com/threads/T-29ae21ac-749d-43d7-bf0c-2c5f7a06ae76
Co-authored-by: Amp <amp@ampcode.com>

2025-11-05 20:39:47 -08:00

2.3 KiB

Raw Blame History

Test Suite Optimization - November 2025

Problem

Test suite was timing out after 5+ minutes, making development workflow painful.

Root Cause

Slow integration tests were running during normal go test ./...:

Daemon tests: 7 files with git operations and time.Sleep calls
Multi-clone convergence tests: 2 tests creating multiple git repos
Concurrent import test: 30-second timeout for deadlock detection

Solution

Tagged slow integration tests with //go:build integration so they're excluded from normal runs:

Files moved to integration-only:

cmd/bd/daemon_test.go (862 lines, 15 tests)
cmd/bd/daemon_sync_branch_test.go (1235 lines, 11 tests)
cmd/bd/daemon_autoimport_test.go (408 lines, 2 tests)
cmd/bd/daemon_watcher_test.go (7 tests)
cmd/bd/daemon_watcher_platform_test.go
cmd/bd/daemon_lock_test.go
cmd/bd/git_sync_test.go
beads_hash_multiclone_test.go (already tagged)
internal/importer/importer_integration_test.go (concurrent test)

Fix for build error:

Added const windowsOS = "windows" to test_helpers_test.go (was in daemon_test.go)

Results

Before:

$ go test ./...
> 300 seconds (timeout)

After:

$ go test ./...
real    0m1.668s  ✅
user    0m2.075s
sys     0m1.586s

99.4% faster! From 5+ minutes to under 2 seconds.

Running Integration Tests

Normal development (fast):

go test ./...

Full test suite including integration (slow):

go test -tags=integration ./...

CI/CD:

# Fast feedback on PRs
- run: go test ./...

# Full suite on merge to main
- run: go test -tags=integration ./...

Benefits

✅ Fast feedback loop for developers (<2s vs 5+ min)
✅ Agents won't timeout on test runs
✅ Integration tests still available when needed
✅ CI can run both fast and comprehensive tests
✅ No tests deleted - just separated by speed

What Tests Remain in Fast Suite?

All unit tests (~300+ tests)
Quick integration tests (<100ms each)
In-memory database tests
Logic/validation tests
Fast import/export tests

Notes

Integration tests still have testing.Short() checks for double safety
The integration build tag is opt-in (must explicitly request with -tags=integration)
All slow git/daemon operations are now integration-only

2.3 KiB Raw Blame History