57253f93a3
Complete implementation of signal-aware context propagation for graceful cancellation across all commands and storage operations. Key changes: 1. Signal-aware contexts (bd-rtp): - Added rootCtx/rootCancel in main.go using signal.NotifyContext() - Set up in PersistentPreRun, cancelled in PersistentPostRun - Daemon uses same pattern in runDaemonLoop() - Handles SIGINT/SIGTERM for graceful shutdown 2. Context propagation (bd-yb8): - All commands now use rootCtx instead of context.Background() - sqlite.New() receives context for cancellable operations - Database operations respect context cancellation - Storage layer propagates context through all queries 3. Cancellation tests (bd-2o2): - Added import_cancellation_test.go with comprehensive tests - Added export cancellation test in export_test.go - Tests verify database integrity after cancellation - All cancellation tests passing Fixes applied during review: - Fixed rootCtx lifecycle (removed premature defer from PersistentPreRun) - Fixed test context contamination (reset rootCtx in test cleanup) - Fixed export tests missing context setup Impact: - Pressing Ctrl+C during import/export now cancels gracefully - No database corruption or hanging transactions - Clean shutdown of all operations Tested: - go build ./cmd/bd ✓ - go test ./cmd/bd -run TestImportCancellation ✓ - go test ./cmd/bd -run TestExportCommand ✓ - Manual Ctrl+C testing verified 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
49 lines
1.5 KiB
Go
49 lines
1.5 KiB
Go
package sqlite
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
)
|
|
|
|
// newTestStore creates a SQLiteStorage with issue_prefix configured (bd-166)
|
|
// This prevents "database not initialized" errors in tests
|
|
//
|
|
// Test Isolation Pattern (bd-2e80):
|
|
// By default, uses "file::memory:?mode=memory&cache=private" for proper test isolation.
|
|
// The standard ":memory:" creates a SHARED database across all tests in the same process,
|
|
// which can cause test interference and flaky behavior. The private mode ensures each
|
|
// test gets its own isolated in-memory database.
|
|
//
|
|
// To override (e.g., for file-based tests), pass a custom dbPath:
|
|
// - For temp files: t.TempDir()+"/test.db"
|
|
// - For shared memory (not recommended): ":memory:"
|
|
func newTestStore(t *testing.T, dbPath string) *SQLiteStorage {
|
|
t.Helper()
|
|
|
|
// Default to temp file for test isolation
|
|
// File-based databases are more reliable than in-memory for connection pool scenarios
|
|
if dbPath == "" {
|
|
dbPath = t.TempDir() + "/test.db"
|
|
}
|
|
|
|
ctx := context.Background()
|
|
store, err := New(ctx, dbPath)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create test database: %v", err)
|
|
}
|
|
|
|
t.Cleanup(func() {
|
|
if cerr := store.Close(); cerr != nil {
|
|
t.Fatalf("Failed to close test database: %v", cerr)
|
|
}
|
|
})
|
|
|
|
// CRITICAL (bd-166): Set issue_prefix to prevent "database not initialized" errors
|
|
if err := store.SetConfig(ctx, "issue_prefix", "bd"); err != nil {
|
|
_ = store.Close()
|
|
t.Fatalf("Failed to set issue_prefix: %v", err)
|
|
}
|
|
|
|
return store
|
|
}
|