Steve Yegge 25061ea9a7 chore: code health review - test fix and error comments (bd-9g1z, bd-ork0) ...

- Remove TestFindJSONLPathDefault from .test-skip (now passes)
- Add explanatory comments to 24 ignored error locations in cmd/bd:
  - Cobra flag methods (MarkHidden, MarkRequired, MarkDeprecated)
  - Best-effort cleanup/close operations
  - Process signaling operations

Part of code health review epic bd-tggf.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

2025-12-22 21:30:57 -08:00

..

doctor

fix(doctor): use context.Background() instead of nil in CheckDuplicateIssues

2025-12-22 20:21:30 -08:00

setup

fix(setup): preserve symlinks in atomicWriteFile

2025-12-20 20:15:55 -05:00

templates/hooks

release: v0.34.0

2025-12-22 03:18:55 -08:00

testdata

…

.gitattributes

…

@AGENTS.md

…

AGENTS.md

…

audit.go

…

autoflush.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

autoimport_test.go

refactor: consolidate duplicate path-finding utilities (bd-74w1, bd-4nqq)

2025-12-22 21:15:41 -08:00

autoimport.go

refactor: consolidate duplicate path-finding utilities (bd-74w1, bd-4nqq)

2025-12-22 21:15:41 -08:00

autostart_test.go

…

cleanup.go

refactor(cmd): replace map[string]interface{} with typed JSON response structs (bd-u2sc.1)

2025-12-22 15:48:36 -08:00

cli_fast_test.go

…

comments_test.go

…

comments.go

fix: misc improvements and dependency updates

2025-12-20 17:09:50 -08:00

compact_test.go

…

compact.go

refactor(cmd): replace map[string]interface{} with typed JSON response structs (bd-u2sc.1)

2025-12-22 15:48:36 -08:00

config_test.go

…

config.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

count.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

create_form_test.go

…

create_form.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

create_test.go

…

create.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

daemon_autoimport_test.go

…

daemon_autostart.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

daemon_basics_test.go

…

daemon_config.go

…

daemon_crash_test.go

…

daemon_debouncer_test.go

…

daemon_debouncer.go

…

daemon_event_loop.go

feat(daemon): add auto_pull config parameter for periodic remote sync

2025-12-22 18:47:18 -05:00

daemon_health_freebsd.go

…

daemon_health_unix.go

…

daemon_health_wasm.go

…

daemon_health_windows.go

…

daemon_integration_test.go

feat(daemon): add auto_pull config parameter for periodic remote sync

2025-12-22 18:47:18 -05:00

daemon_lifecycle.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

daemon_local_test.go

…

daemon_lock_test.go

…

daemon_lock_unix.go

…

daemon_lock_wasm.go

…

daemon_lock_windows.go

…

daemon_lock.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

daemon_logger.go

…

daemon_parent_test.go

…

daemon_rotation_test.go

…

daemon_server.go

…

daemon_sync_branch_test.go

fix(daemon): handle diverged sync branch with fetch-rebase-retry on push (#697)

2025-12-22 14:17:26 -08:00

daemon_sync_branch.go

fix(worktree): integrate health check into CreateBeadsWorktree to prevent redundant checks

2025-12-22 18:57:43 -05:00

daemon_sync_test.go

fix(daemon): include tombstones in exportToJSONLWithStore for sync propagation (#696)

2025-12-22 14:18:10 -08:00

daemon_sync.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

daemon_test.go

…

daemon_unix_test.go

…

daemon_unix.go

…

daemon_wasm.go

…

daemon_watcher_platform_test.go

…

daemon_watcher_test.go

…

daemon_watcher.go

fix(daemon): deduplicate file and git ref change log messages

2025-12-22 19:02:42 -05:00

daemon_windows.go

…

daemon.go

feat(daemon): add auto_pull config parameter for periodic remote sync

2025-12-22 18:47:18 -05:00

daemons_test.go

…

daemons.go

refactor(cmd): replace map[string]interface{} with typed JSON response structs (bd-u2sc.1)

2025-12-22 15:48:36 -08:00

defer.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

delete_test.go

…

delete.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

deletion_tracking_test.go

…

deletion_tracking.go

chore: remove dead deprecated wrapper functions

2025-12-21 15:50:10 -08:00

dep_test.go

…

dep.go

feat: add cross-project dependency support - config and external: prefix (bd-66w1, bd-om4a)

2025-12-21 23:08:00 -08:00

detect_pollution.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

direct_mode_test.go

…

direct_mode.go

…

docs.md

…

doctor_test.go

release: v0.34.0

2025-12-22 03:18:55 -08:00

doctor.go

refactor(doctor): consolidate maintenance commands + improve daemon startup

2025-12-22 20:21:30 -08:00

duplicate.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

duplicates_test.go

…

duplicates.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

epic_test.go

…

epic.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

errors.go

…

export_import_test.go

…

export_integrity_integration_test.go

…

export_mtime_test.go

…

export_staleness_test.go

…

export_test.go

…

export.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

external_ref_test.go

feat: add cross-project dependency support - config and external: prefix (bd-66w1, bd-om4a)

2025-12-21 23:08:00 -08:00

flags.go

…

flush_manager_test.go

…

flush_manager.go

…

fork_protection_test.go

…

fork_protection.go

refactor: consolidate duplicate path-finding utilities (bd-74w1, bd-4nqq)

2025-12-22 21:15:41 -08:00

git_sync_test.go

…

graph_test.go

…

graph.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

helpers_test.go

…

hook.go

feat: implement molecular chemistry UX commands

2025-12-22 02:21:40 -08:00

hooks_test.go

…

hooks.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

import_bug_test.go

…

import_cancellation_test.go

…

import_idempotent_test.go

…

import_mtime_test.go

…

import_multipart_id_test.go

…

import_profile_test.go

…

import_shared.go

…

import_uncommitted_test.go

…

import.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

info_test.go

refactor: consolidate duplicate path-finding utilities (bd-74w1, bd-4nqq)

2025-12-22 21:15:41 -08:00

info.go

release: v0.34.0

2025-12-22 03:18:55 -08:00

init_contributor.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

init_hooks_test.go

…

init_team.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

init_test.go

fix(init): handle read-only gitignore gracefully in stealth mode (#663)

2025-12-20 16:43:43 -08:00

init.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

integrity_content_test.go

…

integrity_test.go

…

integrity.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

jira_test.go

…

jira.go

refactor: consolidate duplicate path-finding utilities (bd-74w1, bd-4nqq)

2025-12-22 21:15:41 -08:00

jsonl_integrity_test.go

…

label_test.go

…

label.go

feat: add bd ship command for cross-project capabilities (bd-eijl)

2025-12-21 23:11:48 -08:00

linear_test.go

…

linear.go

fix: misc improvements and dependency updates

2025-12-20 17:09:50 -08:00

list_test.go

…

list.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

mail.go

fix(lint): add nosec for mail delegate exec.Command

2025-12-21 15:29:58 -08:00

main_test.go

…

main.go

refactor(doctor): consolidate maintenance commands + improve daemon startup

2025-12-22 20:21:30 -08:00

markdown_test.go

…

markdown.go

fix: priority:0 omitempty and markdown nil pointer (GH#671, GH#674)

2025-12-21 15:41:22 -08:00

merge_security_test.go

…

merge.go

fix: misc improvements and dependency updates

2025-12-20 17:09:50 -08:00

migrate_hash_ids_test.go

…

migrate_hash_ids.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

migrate_issues.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

migrate_sync_test.go

…

migrate_sync.go

fix: misc improvements and dependency updates

2025-12-20 17:09:50 -08:00

migrate_test.go

…

migrate_tombstones.go

refactor: consolidate duplicate path-finding utilities (bd-74w1, bd-4nqq)

2025-12-22 21:15:41 -08:00

migrate.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

mol_bond.go

feat: implement molecular chemistry UX commands

2025-12-22 02:21:40 -08:00

mol_burn.go

fix: resolve all golangci-lint errors (#699)

2025-12-22 14:06:45 -08:00

mol_catalog.go

refactor(mol): split 1218-line mol.go into subcommand files

2025-12-21 11:43:43 -08:00

mol_current.go

refactor(doctor): consolidate maintenance commands + improve daemon startup

2025-12-22 20:21:30 -08:00

mol_distill.go

refactor(mol): split 1218-line mol.go into subcommand files

2025-12-21 11:43:43 -08:00

mol_run.go

fix: remove slice bounds panic in mol run output (bd-987a)

2025-12-21 22:58:05 -08:00

mol_show.go

refactor(mol): split 1218-line mol.go into subcommand files

2025-12-21 11:43:43 -08:00

mol_spawn.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

mol_squash.go

fix: resolve all golangci-lint errors (#699)

2025-12-22 14:06:45 -08:00

mol_test.go

feat: add cross-store wisp→digest squash (bd-kwjh.4)

2025-12-22 00:54:35 -08:00

mol.go

feat(mol): spawn molecules as ephemeral by default (bd-2vh3.2)

2025-12-21 13:44:25 -08:00

nodb_test.go

…

nodb.go

…

onboard_test.go

…

onboard.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

output_test.go

…

periodic_remote_sync_test.go

feat(daemon): add auto_pull config parameter for periodic remote sync

2025-12-22 18:47:18 -05:00

pin.go

feat: implement molecular chemistry UX commands

2025-12-22 02:21:40 -08:00

pour.go

feat: implement molecular chemistry UX commands

2025-12-22 02:21:40 -08:00

prime_test.go

…

prime.go

fix: misc improvements and dependency updates

2025-12-20 17:09:50 -08:00

quick.go

fix: misc improvements and dependency updates

2025-12-20 17:09:50 -08:00

quickstart.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

readonly_test.go

…

ready_test.go

…

ready.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

reinit_test.go

…

relate_test.go

…

relate.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

rename_prefix_repair_test.go

…

rename_prefix_test.go

…

rename_prefix.go

refactor(doctor): consolidate maintenance commands + improve daemon startup

2025-12-22 20:21:30 -08:00

reopen_test.go

…

reopen.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

repair_deps_test.go

…

repo.go

fix: bd repo commands write to YAML and cleanup on remove (#683)

2025-12-22 01:26:45 -08:00

reset_test.go

…

reset.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

restore_test.go

…

restore.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

sandbox_test.go

…

sandbox_unix.go

…

sandbox_windows.go

…

scripttest_test.go

…

search_test.go

…

search.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

setup.go

fix: misc improvements and dependency updates

2025-12-20 17:09:50 -08:00

ship.go

feat: add bd ship command for cross-project capabilities (bd-eijl)

2025-12-21 23:11:48 -08:00

show.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

simple_helpers_test.go

…

snapshot_manager.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

stale_test.go

…

stale.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

staleness.go

…

status_test.go

refactor(status): merge stats command into status (GH#644)

2025-12-20 13:14:39 -08:00

status.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

sync_branch_priority_test.go

…

sync_local_only_test.go

…

sync_merge_test.go

…

sync_test.go

…

sync.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

template_test.go

feat(mol): spawn molecules as ephemeral by default (bd-2vh3.2)

2025-12-21 13:44:25 -08:00

template.go

refactor: rename Ephemeral → Wisp (Steam Engine metaphor)

2025-12-21 15:22:45 -08:00

test_helpers_test.go

…

test_wait_helper.go

…

thanks.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

thread_test.go

refactor: rename Ephemeral → Wisp (Steam Engine metaphor)

2025-12-21 15:22:45 -08:00

tips_example_test.go

…

tips_test.go

…

tips.go

chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

2025-12-22 21:30:57 -08:00

undefer.go

Merge upstream/main into subtle-ux-improvements

2025-12-20 17:22:43 -08:00

unpin.go

refactor(ui): standardize on lipgloss semantic color system

2025-12-20 17:09:50 -08:00

upgrade.go

fix: misc improvements and dependency updates

2025-12-20 17:09:50 -08:00

version_test.go

…

version_tracking_test.go

…

version_tracking.go

chore: remove obsolete BD_GUIDE.md references

2025-12-20 20:50:33 -08:00

version.go

release: v0.34.0

2025-12-22 03:18:55 -08:00

wisp.go

refactor(cmd): migrate sort.Slice to slices.SortFunc (bd-u2sc.2)

2025-12-22 15:39:55 -08:00

worktree_daemon_test.go

…

worktree_test.go

…

worktree.go

…