Files
beads/internal/git/worktree_test.go
Steve Yegge 8bbb710e6a Fix branchExists test after signature change
Updated tests to match the new branchExists() signature that returns
bool instead of (bool, error).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-02 20:30:31 -08:00

341 lines
9.8 KiB
Go

package git
import (
"os"
"os/exec"
"path/filepath"
"strings"
"testing"
)
// setupTestRepo creates a temporary git repository for testing
func setupTestRepo(t *testing.T) (repoPath string, cleanup func()) {
t.Helper()
tmpDir := t.TempDir()
repoPath = filepath.Join(tmpDir, "test-repo")
// Create repo directory
if err := os.MkdirAll(repoPath, 0750); err != nil {
t.Fatalf("Failed to create test repo directory: %v", err)
}
// Initialize git repo
cmd := exec.Command("git", "init")
cmd.Dir = repoPath
if output, err := cmd.CombinedOutput(); err != nil {
t.Fatalf("Failed to init git repo: %v\nOutput: %s", err, string(output))
}
// Configure git user for commits
cmd = exec.Command("git", "config", "user.email", "test@example.com")
cmd.Dir = repoPath
if err := cmd.Run(); err != nil {
t.Fatalf("Failed to set git user.email: %v", err)
}
cmd = exec.Command("git", "config", "user.name", "Test User")
cmd.Dir = repoPath
if err := cmd.Run(); err != nil {
t.Fatalf("Failed to set git user.name: %v", err)
}
// Create .beads directory and a test file
beadsDir := filepath.Join(repoPath, ".beads")
if err := os.MkdirAll(beadsDir, 0750); err != nil {
t.Fatalf("Failed to create .beads directory: %v", err)
}
testFile := filepath.Join(beadsDir, "test.jsonl")
if err := os.WriteFile(testFile, []byte("test data\n"), 0644); err != nil {
t.Fatalf("Failed to write test file: %v", err)
}
// Create a file outside .beads to test sparse checkout
otherFile := filepath.Join(repoPath, "other.txt")
if err := os.WriteFile(otherFile, []byte("other data\n"), 0644); err != nil {
t.Fatalf("Failed to write other file: %v", err)
}
// Initial commit
cmd = exec.Command("git", "add", ".")
cmd.Dir = repoPath
if err := cmd.Run(); err != nil {
t.Fatalf("Failed to git add: %v", err)
}
cmd = exec.Command("git", "commit", "-m", "Initial commit")
cmd.Dir = repoPath
if output, err := cmd.CombinedOutput(); err != nil {
t.Fatalf("Failed to commit: %v\nOutput: %s", err, string(output))
}
cleanup = func() {
// Cleanup is handled by t.TempDir()
}
return repoPath, cleanup
}
func TestCreateBeadsWorktree(t *testing.T) {
repoPath, cleanup := setupTestRepo(t)
defer cleanup()
wm := NewWorktreeManager(repoPath)
worktreePath := filepath.Join(t.TempDir(), "beads-worktree")
t.Run("creates new branch worktree", func(t *testing.T) {
err := wm.CreateBeadsWorktree("beads-metadata", worktreePath)
if err != nil {
t.Fatalf("CreateBeadsWorktree failed: %v", err)
}
// Verify worktree exists
if _, err := os.Stat(worktreePath); os.IsNotExist(err) {
t.Errorf("Worktree directory was not created")
}
// Verify .git file exists
gitFile := filepath.Join(worktreePath, ".git")
if _, err := os.Stat(gitFile); os.IsNotExist(err) {
t.Errorf("Worktree .git file was not created")
}
// Verify .beads directory exists in worktree
beadsDir := filepath.Join(worktreePath, ".beads")
if _, err := os.Stat(beadsDir); os.IsNotExist(err) {
t.Errorf(".beads directory not found in worktree")
}
// Verify sparse checkout: other.txt should NOT exist
otherFile := filepath.Join(worktreePath, "other.txt")
if _, err := os.Stat(otherFile); err == nil {
t.Errorf("Sparse checkout failed: other.txt should not exist in worktree")
}
})
t.Run("idempotent - calling twice succeeds", func(t *testing.T) {
worktreePath2 := filepath.Join(t.TempDir(), "beads-worktree-idempotent")
// Create once
if err := wm.CreateBeadsWorktree("beads-metadata-idempotent", worktreePath2); err != nil {
t.Fatalf("First CreateBeadsWorktree failed: %v", err)
}
// Create again with same path (should succeed and be a no-op)
if err := wm.CreateBeadsWorktree("beads-metadata-idempotent", worktreePath2); err != nil {
t.Errorf("Second CreateBeadsWorktree failed (should be idempotent): %v", err)
}
// Verify worktree still exists and is valid
if valid, err := wm.isValidWorktree(worktreePath2); err != nil || !valid {
t.Errorf("Worktree should still be valid after idempotent call: valid=%v, err=%v", valid, err)
}
})
}
func TestRemoveBeadsWorktree(t *testing.T) {
repoPath, cleanup := setupTestRepo(t)
defer cleanup()
wm := NewWorktreeManager(repoPath)
worktreePath := filepath.Join(t.TempDir(), "beads-worktree")
// Create worktree first
if err := wm.CreateBeadsWorktree("beads-metadata", worktreePath); err != nil {
t.Fatalf("CreateBeadsWorktree failed: %v", err)
}
// Verify it exists
if _, err := os.Stat(worktreePath); os.IsNotExist(err) {
t.Fatalf("Worktree was not created")
}
// Remove it
if err := wm.RemoveBeadsWorktree(worktreePath); err != nil {
t.Fatalf("RemoveBeadsWorktree failed: %v", err)
}
// Verify it's gone
if _, err := os.Stat(worktreePath); err == nil {
t.Errorf("Worktree directory still exists after removal")
}
}
func TestCheckWorktreeHealth(t *testing.T) {
repoPath, cleanup := setupTestRepo(t)
defer cleanup()
wm := NewWorktreeManager(repoPath)
t.Run("healthy worktree passes check", func(t *testing.T) {
worktreePath := filepath.Join(t.TempDir(), "beads-worktree")
if err := wm.CreateBeadsWorktree("beads-metadata", worktreePath); err != nil {
t.Fatalf("CreateBeadsWorktree failed: %v", err)
}
if err := wm.CheckWorktreeHealth(worktreePath); err != nil {
t.Errorf("CheckWorktreeHealth failed for healthy worktree: %v", err)
}
})
t.Run("non-existent path fails check", func(t *testing.T) {
nonExistentPath := filepath.Join(t.TempDir(), "does-not-exist")
err := wm.CheckWorktreeHealth(nonExistentPath)
if err == nil {
t.Error("CheckWorktreeHealth should fail for non-existent path")
}
if !strings.Contains(err.Error(), "does not exist") {
t.Errorf("Expected 'does not exist' error, got: %v", err)
}
})
t.Run("invalid worktree fails check", func(t *testing.T) {
invalidPath := filepath.Join(t.TempDir(), "invalid-worktree")
if err := os.MkdirAll(invalidPath, 0750); err != nil {
t.Fatalf("Failed to create invalid path: %v", err)
}
err := wm.CheckWorktreeHealth(invalidPath)
if err == nil {
t.Error("CheckWorktreeHealth should fail for invalid worktree")
}
})
}
func TestSyncJSONLToWorktree(t *testing.T) {
repoPath, cleanup := setupTestRepo(t)
defer cleanup()
wm := NewWorktreeManager(repoPath)
worktreePath := filepath.Join(t.TempDir(), "beads-worktree")
// Create worktree
if err := wm.CreateBeadsWorktree("beads-metadata", worktreePath); err != nil {
t.Fatalf("CreateBeadsWorktree failed: %v", err)
}
// Update the JSONL in the main repo
mainJSONL := filepath.Join(repoPath, ".beads", "test.jsonl")
newData := []byte("updated data\n")
if err := os.WriteFile(mainJSONL, newData, 0644); err != nil {
t.Fatalf("Failed to update main JSONL: %v", err)
}
// Sync to worktree
if err := wm.SyncJSONLToWorktree(worktreePath, ".beads/test.jsonl"); err != nil {
t.Fatalf("SyncJSONLToWorktree failed: %v", err)
}
// Verify the data was synced
worktreeJSONL := filepath.Join(worktreePath, ".beads", "test.jsonl")
data, err := os.ReadFile(worktreeJSONL)
if err != nil {
t.Fatalf("Failed to read worktree JSONL: %v", err)
}
if string(data) != string(newData) {
t.Errorf("JSONL data mismatch.\nExpected: %s\nGot: %s", string(newData), string(data))
}
}
func TestBranchExists(t *testing.T) {
repoPath, cleanup := setupTestRepo(t)
defer cleanup()
wm := NewWorktreeManager(repoPath)
t.Run("main branch exists", func(t *testing.T) {
// Get the default branch name (might be 'main' or 'master')
cmd := exec.Command("git", "branch", "--show-current")
cmd.Dir = repoPath
output, err := cmd.Output()
if err != nil {
t.Fatalf("Failed to get current branch: %v", err)
}
currentBranch := strings.TrimSpace(string(output))
exists := wm.branchExists(currentBranch)
if !exists {
t.Errorf("Current branch %s should exist", currentBranch)
}
})
t.Run("non-existent branch returns false", func(t *testing.T) {
exists := wm.branchExists("does-not-exist-branch")
if exists {
t.Error("Non-existent branch should return false")
}
})
}
func TestIsValidWorktree(t *testing.T) {
repoPath, cleanup := setupTestRepo(t)
defer cleanup()
wm := NewWorktreeManager(repoPath)
t.Run("created worktree is valid", func(t *testing.T) {
worktreePath := filepath.Join(t.TempDir(), "beads-worktree")
if err := wm.CreateBeadsWorktree("beads-metadata", worktreePath); err != nil {
t.Fatalf("CreateBeadsWorktree failed: %v", err)
}
valid, err := wm.isValidWorktree(worktreePath)
if err != nil {
t.Fatalf("isValidWorktree failed: %v", err)
}
if !valid {
t.Error("Created worktree should be valid")
}
})
t.Run("non-worktree path is invalid", func(t *testing.T) {
invalidPath := filepath.Join(t.TempDir(), "not-a-worktree")
if err := os.MkdirAll(invalidPath, 0750); err != nil {
t.Fatalf("Failed to create test directory: %v", err)
}
valid, err := wm.isValidWorktree(invalidPath)
if err != nil {
t.Fatalf("isValidWorktree failed: %v", err)
}
if valid {
t.Error("Non-worktree path should be invalid")
}
})
}
func TestSparseCheckoutConfiguration(t *testing.T) {
repoPath, cleanup := setupTestRepo(t)
defer cleanup()
wm := NewWorktreeManager(repoPath)
worktreePath := filepath.Join(t.TempDir(), "beads-worktree")
// Create worktree
if err := wm.CreateBeadsWorktree("beads-metadata", worktreePath); err != nil {
t.Fatalf("CreateBeadsWorktree failed: %v", err)
}
t.Run("sparse checkout includes .beads", func(t *testing.T) {
if err := wm.verifySparseCheckout(worktreePath); err != nil {
t.Errorf("verifySparseCheckout failed: %v", err)
}
})
t.Run("can reconfigure sparse checkout", func(t *testing.T) {
if err := wm.configureSparseCheckout(worktreePath); err != nil {
t.Errorf("configureSparseCheckout failed: %v", err)
}
// Verify it's still correct
if err := wm.verifySparseCheckout(worktreePath); err != nil {
t.Errorf("verifySparseCheckout failed after reconfigure: %v", err)
}
})
}