55fdaf99e7
Standardized error handling across the SQLite storage layer by consistently using wrapDBError() helper functions that were already defined in errors.go. Changes: - config.go: Applied wrapDBError to all config/metadata functions - queries.go: Fixed bare 'return err' in CreateIssue, UpdateIssue, DeleteIssues - store.go: Changed %v to %w for proper error chain preservation - errors_test.go: Added comprehensive test coverage for error wrapping All error paths now: - Wrap errors with operation context using %w - Convert sql.ErrNoRows to ErrNotFound consistently - Preserve error chains for unwrapping and type checking This improves debugging by maintaining operation context throughout the error chain and enables type-safe error checking with sentinel errors. All tests passing ✓ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
96 lines
3.2 KiB
Go
96 lines
3.2 KiB
Go
package sqlite
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
)
|
|
|
|
// SetConfig sets a configuration value
|
|
func (s *SQLiteStorage) SetConfig(ctx context.Context, key, value string) error {
|
|
_, err := s.db.ExecContext(ctx, `
|
|
INSERT INTO config (key, value) VALUES (?, ?)
|
|
ON CONFLICT (key) DO UPDATE SET value = excluded.value
|
|
`, key, value)
|
|
return wrapDBError("set config", err)
|
|
}
|
|
|
|
// GetConfig gets a configuration value
|
|
func (s *SQLiteStorage) GetConfig(ctx context.Context, key string) (string, error) {
|
|
var value string
|
|
err := s.db.QueryRowContext(ctx, `SELECT value FROM config WHERE key = ?`, key).Scan(&value)
|
|
if err == sql.ErrNoRows {
|
|
return "", nil
|
|
}
|
|
return value, wrapDBError("get config", err)
|
|
}
|
|
|
|
// GetAllConfig gets all configuration key-value pairs
|
|
func (s *SQLiteStorage) GetAllConfig(ctx context.Context) (map[string]string, error) {
|
|
rows, err := s.db.QueryContext(ctx, `SELECT key, value FROM config ORDER BY key`)
|
|
if err != nil {
|
|
return nil, wrapDBError("query all config", err)
|
|
}
|
|
defer func() { _ = rows.Close() }()
|
|
|
|
config := make(map[string]string)
|
|
for rows.Next() {
|
|
var key, value string
|
|
if err := rows.Scan(&key, &value); err != nil {
|
|
return nil, wrapDBError("scan config row", err)
|
|
}
|
|
config[key] = value
|
|
}
|
|
return config, wrapDBError("iterate config rows", rows.Err())
|
|
}
|
|
|
|
// DeleteConfig deletes a configuration value
|
|
func (s *SQLiteStorage) DeleteConfig(ctx context.Context, key string) error {
|
|
_, err := s.db.ExecContext(ctx, `DELETE FROM config WHERE key = ?`, key)
|
|
return wrapDBError("delete config", err)
|
|
}
|
|
|
|
// OrphanHandling defines how to handle orphan issues during import
|
|
type OrphanHandling string
|
|
|
|
const (
|
|
OrphanStrict OrphanHandling = "strict" // Reject imports with orphans
|
|
OrphanResurrect OrphanHandling = "resurrect" // Auto-resurrect parents from JSONL
|
|
OrphanSkip OrphanHandling = "skip" // Skip orphans silently
|
|
OrphanAllow OrphanHandling = "allow" // Allow orphans (default)
|
|
)
|
|
|
|
// GetOrphanHandling gets the import.orphan_handling config value
|
|
// Returns OrphanAllow (the default) if not set or if value is invalid
|
|
func (s *SQLiteStorage) GetOrphanHandling(ctx context.Context) OrphanHandling {
|
|
value, err := s.GetConfig(ctx, "import.orphan_handling")
|
|
if err != nil || value == "" {
|
|
return OrphanAllow // Default
|
|
}
|
|
|
|
switch OrphanHandling(value) {
|
|
case OrphanStrict, OrphanResurrect, OrphanSkip, OrphanAllow:
|
|
return OrphanHandling(value)
|
|
default:
|
|
return OrphanAllow // Invalid value, use default
|
|
}
|
|
}
|
|
|
|
// SetMetadata sets a metadata value (for internal state like import hashes)
|
|
func (s *SQLiteStorage) SetMetadata(ctx context.Context, key, value string) error {
|
|
_, err := s.db.ExecContext(ctx, `
|
|
INSERT INTO metadata (key, value) VALUES (?, ?)
|
|
ON CONFLICT (key) DO UPDATE SET value = excluded.value
|
|
`, key, value)
|
|
return wrapDBError("set metadata", err)
|
|
}
|
|
|
|
// GetMetadata gets a metadata value (for internal state like import hashes)
|
|
func (s *SQLiteStorage) GetMetadata(ctx context.Context, key string) (string, error) {
|
|
var value string
|
|
err := s.db.QueryRowContext(ctx, `SELECT value FROM metadata WHERE key = ?`, key).Scan(&value)
|
|
if err == sql.ErrNoRows {
|
|
return "", nil
|
|
}
|
|
return value, wrapDBError("get metadata", err)
|
|
}
|