Files
beads/internal/validation/bead_test.go
matt wilkie fb16e504e6 Fix tests (bd-6ss and sub-issues) (#626)
Test coverage improvements for bd-6ss. Fixing failing test assumption in follow-up commit.
2025-12-18 18:23:30 -08:00

191 lines
4.7 KiB
Go

package validation
import (
"strings"
"testing"
"github.com/steveyegge/beads/internal/types"
)
func TestParsePriority(t *testing.T) {
tests := []struct {
input string
expected int
}{
// Numeric format
{"0", 0},
{"1", 1},
{"2", 2},
{"3", 3},
{"4", 4},
// P-prefix format (uppercase)
{"P0", 0},
{"P1", 1},
{"P2", 2},
{"P3", 3},
{"P4", 4},
// P-prefix format (lowercase)
{"p0", 0},
{"p1", 1},
{"p2", 2},
// With whitespace
{" 1 ", 1},
{" P1 ", 1},
// Invalid cases (returns -1)
{"5", -1}, // Out of range
{"-1", -1}, // Negative
{"P5", -1}, // Out of range with prefix
{"abc", -1}, // Not a number
{"P", -1}, // Just the prefix
{"PP1", -1}, // Double prefix
}
for _, tt := range tests {
t.Run(tt.input, func(t *testing.T) {
got := ParsePriority(tt.input)
if got != tt.expected {
t.Errorf("ParsePriority(%q) = %d, want %d", tt.input, got, tt.expected)
}
})
}
}
func TestValidatePriority(t *testing.T) {
tests := []struct {
input string
wantValue int
wantError bool
}{
{"0", 0, false},
{"2", 2, false},
{"P1", 1, false},
{"5", -1, true},
{"abc", -1, true},
}
for _, tt := range tests {
t.Run(tt.input, func(t *testing.T) {
got, err := ValidatePriority(tt.input)
if (err != nil) != tt.wantError {
t.Errorf("ValidatePriority(%q) error = %v, wantError %v", tt.input, err, tt.wantError)
return
}
if got != tt.wantValue {
t.Errorf("ValidatePriority(%q) = %d, want %d", tt.input, got, tt.wantValue)
}
})
}
}
func TestValidateIDFormat(t *testing.T) {
tests := []struct {
input string
wantPrefix string
wantError bool
}{
{"", "", false},
{"bd-a3f8e9", "bd", false},
{"bd-42", "bd", false},
{"bd-a3f8e9.1", "bd", false},
{"foo-bar", "foo", false},
{"nohyphen", "", true},
}
for _, tt := range tests {
t.Run(tt.input, func(t *testing.T) {
got, err := ValidateIDFormat(tt.input)
if (err != nil) != tt.wantError {
t.Errorf("ValidateIDFormat(%q) error = %v, wantError %v", tt.input, err, tt.wantError)
return
}
if got != tt.wantPrefix {
t.Errorf("ValidateIDFormat(%q) = %q, want %q", tt.input, got, tt.wantPrefix)
}
})
}
}
func TestParseIssueType(t *testing.T) {
tests := []struct {
name string
input string
wantType types.IssueType
wantError bool
errorContains string
}{
// Valid issue types
{"bug type", "bug", types.TypeBug, false, ""},
{"feature type", "feature", types.TypeFeature, false, ""},
{"task type", "task", types.TypeTask, false, ""},
{"epic type", "epic", types.TypeEpic, false, ""},
{"chore type", "chore", types.TypeChore, false, ""},
// Case sensitivity (function is case-sensitive)
{"uppercase bug", "BUG", types.TypeTask, true, "invalid issue type"},
{"mixed case feature", "FeAtUrE", types.TypeTask, true, "invalid issue type"},
// With whitespace
{"bug with spaces", " bug ", types.TypeBug, false, ""},
{"feature with tabs", "\tfeature\t", types.TypeFeature, false, ""},
// Invalid issue types
{"invalid type", "invalid", types.TypeTask, true, "invalid issue type"},
{"empty string", "", types.TypeTask, true, "invalid issue type"},
{"whitespace only", " ", types.TypeTask, true, "invalid issue type"},
{"numeric type", "123", types.TypeTask, true, "invalid issue type"},
{"special chars", "bug!", types.TypeTask, true, "invalid issue type"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := ParseIssueType(tt.input)
// Check error conditions
if (err != nil) != tt.wantError {
t.Errorf("ParseIssueType(%q) error = %v, wantError %v", tt.input, err, tt.wantError)
return
}
if err != nil && tt.errorContains != "" {
if !strings.Contains(err.Error(), tt.errorContains) {
t.Errorf("ParseIssueType(%q) error message = %q, should contain %q", tt.input, err.Error(), tt.errorContains)
}
return
}
// Check return value
if got != tt.wantType {
t.Errorf("ParseIssueType(%q) = %v, want %v", tt.input, got, tt.wantType)
}
})
}
}
func TestValidatePrefix(t *testing.T) {
tests := []struct {
name string
requestedPrefix string
dbPrefix string
force bool
wantError bool
}{
{"matching prefixes", "bd", "bd", false, false},
{"empty db prefix", "bd", "", false, false},
{"mismatched with force", "foo", "bd", true, false},
{"mismatched without force", "foo", "bd", false, true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
err := ValidatePrefix(tt.requestedPrefix, tt.dbPrefix, tt.force)
if (err != nil) != tt.wantError {
t.Errorf("ValidatePrefix() error = %v, wantError %v", err, tt.wantError)
}
})
}
}