2adba0d8e0
Phase 1 of tombstone migration: bd delete now creates tombstones instead of hard-deleting issues. Key changes: - Add CreateTombstone() method to SQLiteStorage for soft-delete - Modify executeDelete() to create tombstones instead of removing rows - Add IsExpired() method with 30-day default TTL and clock skew grace - Fix deleted_at schema from TEXT to DATETIME for proper time scanning - Update delete.go to call CreateTombstone (single issue path) - Still writes to deletions.jsonl for backward compatibility (dual-write) - Dependencies are removed when creating tombstones - Tombstones are excluded from normal searches (bd-1bu) TTL constants: - DefaultTombstoneTTL: 30 days - MinTombstoneTTL: 7 days (safety floor) - ClockSkewGrace: 1 hour 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
55 lines
1.5 KiB
Go
55 lines
1.5 KiB
Go
package migrations
|
|
|
|
import (
|
|
"database/sql"
|
|
"fmt"
|
|
)
|
|
|
|
// MigrateTombstoneColumns adds tombstone support columns to the issues table.
|
|
// These columns support inline soft-delete (bd-vw8) replacing deletions.jsonl:
|
|
// - deleted_at: when the issue was deleted
|
|
// - deleted_by: who deleted the issue
|
|
// - delete_reason: why the issue was deleted
|
|
// - original_type: the issue type before deletion (for tombstones)
|
|
func MigrateTombstoneColumns(db *sql.DB) error {
|
|
columns := []struct {
|
|
name string
|
|
definition string
|
|
}{
|
|
{"deleted_at", "DATETIME"},
|
|
{"deleted_by", "TEXT DEFAULT ''"},
|
|
{"delete_reason", "TEXT DEFAULT ''"},
|
|
{"original_type", "TEXT DEFAULT ''"},
|
|
}
|
|
|
|
for _, col := range columns {
|
|
var columnExists bool
|
|
err := db.QueryRow(`
|
|
SELECT COUNT(*) > 0
|
|
FROM pragma_table_info('issues')
|
|
WHERE name = ?
|
|
`, col.name).Scan(&columnExists)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to check %s column: %w", col.name, err)
|
|
}
|
|
|
|
if columnExists {
|
|
continue
|
|
}
|
|
|
|
_, err = db.Exec(fmt.Sprintf(`ALTER TABLE issues ADD COLUMN %s %s`, col.name, col.definition))
|
|
if err != nil {
|
|
return fmt.Errorf("failed to add %s column: %w", col.name, err)
|
|
}
|
|
}
|
|
|
|
// Add partial index on deleted_at for efficient TTL queries (bd-saa)
|
|
// Only indexes non-NULL values, making it very efficient for tombstone filtering
|
|
_, err := db.Exec(`CREATE INDEX IF NOT EXISTS idx_issues_deleted_at ON issues(deleted_at) WHERE deleted_at IS NOT NULL`)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create deleted_at index: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|