Added tests for internal/rpc and internal/storage/sqlite: RPC tests (+5.8% coverage: 58.0% → 63.8%): - TestCloseIssue: Cover handleClose (was 0%) - TestReposStats: Cover handleReposStats (was 0%) - TestReposClearCache: Cover handleReposClearCache (was 0%) - TestEpicStatus: Cover handleEpicStatus (was 0%) Storage tests (+2.6% coverage: 62.2% → 64.8%): - Created epics_test.go with TestGetEpicsEligibleForClosure - TestUpdateIssueValidation: validateIssueType, validateEstimatedMinutes - TestGetAllConfig, TestDeleteConfig, TestIsClosed Overall coverage: 48.7% → 50.7% (+2.0%) Progress on bd-136: Achieve 75% test coverage across codebase Amp-Thread-ID: https://ampcode.com/threads/T-16b56923-6fbc-45db-b68b-315567849ec6 Co-authored-by: Amp <amp@ampcode.com>
408 lines
8.7 KiB
Go
408 lines
8.7 KiB
Go
package rpc
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/steveyegge/beads/internal/types"
|
|
)
|
|
|
|
func TestSetTimeout(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
client.SetTimeout(5 * time.Second)
|
|
// No crash means success
|
|
}
|
|
|
|
func TestShow(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
// Create issue
|
|
createArgs := &CreateArgs{
|
|
Title: "Show Test",
|
|
IssueType: "task",
|
|
Priority: 1,
|
|
}
|
|
|
|
createResp, err := client.Create(createArgs)
|
|
if err != nil {
|
|
t.Fatalf("Create failed: %v", err)
|
|
}
|
|
|
|
var issue types.Issue
|
|
if err := json.Unmarshal(createResp.Data, &issue); err != nil {
|
|
t.Fatalf("Failed to unmarshal: %v", err)
|
|
}
|
|
|
|
// Show issue
|
|
showArgs := &ShowArgs{ID: issue.ID}
|
|
resp, err := client.Show(showArgs)
|
|
if err != nil {
|
|
t.Fatalf("Show failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("Show failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestReady(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
args := &ReadyArgs{Limit: 10}
|
|
resp, err := client.Ready(args)
|
|
if err != nil {
|
|
t.Fatalf("Ready failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("Ready failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestStats(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
resp, err := client.Stats()
|
|
if err != nil {
|
|
t.Fatalf("Stats failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("Stats failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestAddDependency(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
// Create two issues
|
|
issue1, err := client.Create(&CreateArgs{Title: "Issue 1", IssueType: "task", Priority: 1})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var i1 types.Issue
|
|
json.Unmarshal(issue1.Data, &i1)
|
|
|
|
issue2, err := client.Create(&CreateArgs{Title: "Issue 2", IssueType: "task", Priority: 1})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var i2 types.Issue
|
|
json.Unmarshal(issue2.Data, &i2)
|
|
|
|
// Add dependency
|
|
args := &DepAddArgs{FromID: i1.ID, ToID: i2.ID, DepType: "blocks"}
|
|
resp, err := client.AddDependency(args)
|
|
if err != nil {
|
|
t.Fatalf("AddDependency failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("AddDependency failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestRemoveDependency(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
// Create issues and add dependency
|
|
issue1, _ := client.Create(&CreateArgs{Title: "Issue 1", IssueType: "task", Priority: 1})
|
|
var i1 types.Issue
|
|
json.Unmarshal(issue1.Data, &i1)
|
|
|
|
issue2, _ := client.Create(&CreateArgs{Title: "Issue 2", IssueType: "task", Priority: 1})
|
|
var i2 types.Issue
|
|
json.Unmarshal(issue2.Data, &i2)
|
|
|
|
client.AddDependency(&DepAddArgs{FromID: i1.ID, ToID: i2.ID, DepType: "blocks"})
|
|
|
|
// Remove dependency
|
|
args := &DepRemoveArgs{FromID: i1.ID, ToID: i2.ID}
|
|
resp, err := client.RemoveDependency(args)
|
|
if err != nil {
|
|
t.Fatalf("RemoveDependency failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("RemoveDependency failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestAddLabel(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
// Create issue
|
|
createResp, _ := client.Create(&CreateArgs{Title: "Label Test", IssueType: "task", Priority: 1})
|
|
var issue types.Issue
|
|
json.Unmarshal(createResp.Data, &issue)
|
|
|
|
// Add label
|
|
args := &LabelAddArgs{ID: issue.ID, Label: "test"}
|
|
resp, err := client.AddLabel(args)
|
|
if err != nil {
|
|
t.Fatalf("AddLabel failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("AddLabel failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestRemoveLabel(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
// Create issue with label
|
|
createArgs := &CreateArgs{
|
|
Title: "Label Test",
|
|
IssueType: "task",
|
|
Priority: 1,
|
|
Labels: []string{"test"},
|
|
}
|
|
createResp, _ := client.Create(createArgs)
|
|
var issue types.Issue
|
|
json.Unmarshal(createResp.Data, &issue)
|
|
|
|
// Remove label
|
|
args := &LabelRemoveArgs{ID: issue.ID, Label: "test"}
|
|
resp, err := client.RemoveLabel(args)
|
|
if err != nil {
|
|
t.Fatalf("RemoveLabel failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("RemoveLabel failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestBatch(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
createArgs, _ := json.Marshal(CreateArgs{Title: "Batch 1", IssueType: "task", Priority: 1})
|
|
args := &BatchArgs{
|
|
Operations: []BatchOperation{
|
|
{
|
|
Operation: "create",
|
|
Args: createArgs,
|
|
},
|
|
},
|
|
}
|
|
|
|
resp, err := client.Batch(args)
|
|
if err != nil {
|
|
t.Fatalf("Batch failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("Batch failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestReposList(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
resp, err := client.ReposList()
|
|
if err != nil {
|
|
t.Fatalf("ReposList failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("ReposList failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestReposReady(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
args := &ReposReadyArgs{}
|
|
resp, err := client.ReposReady(args)
|
|
if err != nil {
|
|
t.Fatalf("ReposReady failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("ReposReady failed: %s", resp.Error)
|
|
}
|
|
}
|
|
|
|
func TestReposStats(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
// Create a test issue to populate stats
|
|
createArgs := &CreateArgs{
|
|
Title: "Test Issue for Stats",
|
|
IssueType: "task",
|
|
Priority: 2,
|
|
}
|
|
_, err := client.Create(createArgs)
|
|
if err != nil {
|
|
t.Fatalf("Create failed: %v", err)
|
|
}
|
|
|
|
resp, err := client.ReposStats()
|
|
if err != nil {
|
|
t.Fatalf("ReposStats failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("ReposStats failed: %s", resp.Error)
|
|
}
|
|
|
|
// Verify response structure
|
|
var statsResp ReposStatsResponse
|
|
if err := json.Unmarshal(resp.Data, &statsResp); err != nil {
|
|
t.Fatalf("Failed to unmarshal stats response: %v", err)
|
|
}
|
|
|
|
if statsResp.Total.TotalIssues == 0 {
|
|
t.Error("Expected TotalIssues > 0 in aggregated stats")
|
|
}
|
|
}
|
|
|
|
func TestReposClearCache(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
// Create an issue to populate cache
|
|
createArgs := &CreateArgs{
|
|
Title: "Test Issue",
|
|
IssueType: "task",
|
|
Priority: 2,
|
|
}
|
|
_, err := client.Create(createArgs)
|
|
if err != nil {
|
|
t.Fatalf("Create failed: %v", err)
|
|
}
|
|
|
|
// Clear the cache
|
|
resp, err := client.ReposClearCache()
|
|
if err != nil {
|
|
t.Fatalf("ReposClearCache failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("ReposClearCache failed: %s", resp.Error)
|
|
}
|
|
|
|
// Verify we can still operate after cache clear (cache should rebuild)
|
|
createArgs2 := &CreateArgs{
|
|
Title: "Post-Clear Issue",
|
|
IssueType: "task",
|
|
Priority: 2,
|
|
}
|
|
createResp, err := client.Create(createArgs2)
|
|
if err != nil {
|
|
t.Fatalf("Create after cache clear failed: %v", err)
|
|
}
|
|
|
|
if !createResp.Success {
|
|
t.Errorf("Expected create to succeed after cache clear")
|
|
}
|
|
}
|
|
|
|
func TestEpicStatus(t *testing.T) {
|
|
_, client, cleanup := setupTestServer(t)
|
|
defer cleanup()
|
|
defer client.Close()
|
|
|
|
// Create an epic with subtasks
|
|
epicArgs := &CreateArgs{
|
|
Title: "Test Epic",
|
|
Description: "Epic for testing status",
|
|
IssueType: "epic",
|
|
Priority: 2,
|
|
}
|
|
epicResp, err := client.Create(epicArgs)
|
|
if err != nil {
|
|
t.Fatalf("Create epic failed: %v", err)
|
|
}
|
|
|
|
var epic types.Issue
|
|
json.Unmarshal(epicResp.Data, &epic)
|
|
|
|
// Create a subtask
|
|
taskArgs := &CreateArgs{
|
|
Title: "Subtask",
|
|
IssueType: "task",
|
|
Priority: 2,
|
|
}
|
|
taskResp, err := client.Create(taskArgs)
|
|
if err != nil {
|
|
t.Fatalf("Create task failed: %v", err)
|
|
}
|
|
|
|
var task types.Issue
|
|
json.Unmarshal(taskResp.Data, &task)
|
|
|
|
// Link task to epic
|
|
depArgs := &DepAddArgs{
|
|
FromID: task.ID,
|
|
ToID: epic.ID,
|
|
DepType: "parent-child",
|
|
}
|
|
_, err = client.AddDependency(depArgs)
|
|
if err != nil {
|
|
t.Fatalf("AddDependency failed: %v", err)
|
|
}
|
|
|
|
// Test EpicStatus with eligibleOnly=false
|
|
epicStatusArgs := &EpicStatusArgs{
|
|
EligibleOnly: false,
|
|
}
|
|
resp, err := client.EpicStatus(epicStatusArgs)
|
|
if err != nil {
|
|
t.Fatalf("EpicStatus failed: %v", err)
|
|
}
|
|
|
|
if !resp.Success {
|
|
t.Errorf("EpicStatus failed: %s", resp.Error)
|
|
}
|
|
|
|
var epicStatuses []*types.EpicStatus
|
|
if err := json.Unmarshal(resp.Data, &epicStatuses); err != nil {
|
|
t.Fatalf("Failed to unmarshal epic statuses: %v", err)
|
|
}
|
|
|
|
// Should find at least one epic
|
|
if len(epicStatuses) == 0 {
|
|
t.Error("Expected at least one epic in status")
|
|
}
|
|
|
|
// Test with eligibleOnly=true
|
|
epicStatusArgs.EligibleOnly = true
|
|
resp2, err := client.EpicStatus(epicStatusArgs)
|
|
if err != nil {
|
|
t.Fatalf("EpicStatus (eligible only) failed: %v", err)
|
|
}
|
|
|
|
if !resp2.Success {
|
|
t.Errorf("EpicStatus (eligible only) failed: %s", resp2.Error)
|
|
}
|
|
}
|