Files
beads/internal/storage/sqlite/adaptive_e2e_test.go
Steve Yegge e3afecca37 Remove sequential ID code path (bd-aa744b)
- Removed nextSequentialID() and getIDMode() functions
- Removed issue_counters table from schema
- Made SyncAllCounters() a no-op for backward compatibility
- Simplified ID generation to hash-only (adaptive length)
- Removed id_mode config setting
- Removed sequential ID tests and migration code
- Updated CONFIG.md and AGENTS.md to remove sequential ID references

Follow-up bd-2a70 will remove obsolete test files and renumber command.
2025-10-30 21:51:39 -07:00

154 lines
4.4 KiB
Go

package sqlite
import (
"context"
"strings"
"testing"
"github.com/steveyegge/beads/internal/types"
)
func TestAdaptiveIDLength_E2E(t *testing.T) {
// Create in-memory database
db, err := New(":memory:")
if err != nil {
t.Fatalf("Failed to create database: %v", err)
}
defer db.Close()
ctx := context.Background()
// Initialize with prefix
if err := db.SetConfig(ctx, "issue_prefix", "test"); err != nil {
t.Fatalf("Failed to set prefix: %v", err)
}
// Helper to create issue and verify ID length
createAndCheckLength := func(title string, expectedHashLen int) string {
issue := &types.Issue{
Title: title,
Description: "Test",
Status: "open",
Priority: 1,
IssueType: "task",
}
if err := db.CreateIssue(ctx, issue, "test@example.com"); err != nil {
t.Fatalf("Failed to create issue: %v", err)
}
// Check ID format: test-xxxx
if !strings.HasPrefix(issue.ID, "test-") {
t.Errorf("ID should start with test-, got %s", issue.ID)
}
hashPart := strings.TrimPrefix(issue.ID, "test-")
if len(hashPart) != expectedHashLen {
t.Errorf("Issue %s: hash length = %d, want %d", title, len(hashPart), expectedHashLen)
}
return issue.ID
}
// Test 1: First few issues should use 4-char IDs
t.Run("first_50_issues_use_4_chars", func(t *testing.T) {
for i := 0; i < 50; i++ {
title := formatTitle("Issue %d", i)
createAndCheckLength(title, 4)
}
})
// Test 2: Issues 50-500 should still use 4 chars (7% collision at 500)
t.Run("issues_50_to_500_use_4_chars", func(t *testing.T) {
for i := 50; i < 500; i++ {
title := formatTitle("Issue %d", i)
id := createAndCheckLength(title, 4)
// Most should be 4 chars, but collisions might push some to 5
// We allow up to 5 chars as progressive fallback
hashPart := strings.TrimPrefix(id, "test-")
if len(hashPart) > 5 {
t.Errorf("Issue %d has hash length %d, expected 4-5", i, len(hashPart))
}
}
})
// Test 3: At 1000 issues, should scale to 5 chars
// Note: We don't enforce exact length in this test because the adaptive
// algorithm will keep using 4 chars until collision probability exceeds 25%
// At 600 issues we're still below that threshold
t.Run("verify_adaptive_scaling_works", func(t *testing.T) {
// Just verify that we can create more issues and the algorithm doesn't break
// The actual length will be determined by the adaptive algorithm
for i := 500; i < 550; i++ {
title := formatTitle("Issue %d", i)
issue := &types.Issue{
Title: title,
Description: "Test",
Status: "open",
Priority: 1,
IssueType: "task",
}
if err := db.CreateIssue(ctx, issue, "test@example.com"); err != nil {
t.Fatalf("Failed to create issue: %v", err)
}
// Should use 4-6 chars depending on database size
hashPart := strings.TrimPrefix(issue.ID, "test-")
if len(hashPart) < 4 || len(hashPart) > 6 {
t.Errorf("Issue %d has hash length %d, expected 4-6", i, len(hashPart))
}
}
})
}
func formatTitle(format string, i int) string {
// Use sprintf to format title
return strings.Replace(format, "%d", strings.Repeat("x", i%10), 1) + string(rune('a'+i%26))
}
func TestAdaptiveIDLength_CustomConfig(t *testing.T) {
// Create in-memory database
db, err := New(":memory:")
if err != nil {
t.Fatalf("Failed to create database: %v", err)
}
defer db.Close()
ctx := context.Background()
// Initialize with custom config
if err := db.SetConfig(ctx, "issue_prefix", "test"); err != nil {
t.Fatalf("Failed to set prefix: %v", err)
}
// Set stricter collision threshold (1%) and min length of 5
if err := db.SetConfig(ctx, "max_collision_prob", "0.01"); err != nil {
t.Fatalf("Failed to set max_collision_prob: %v", err)
}
if err := db.SetConfig(ctx, "min_hash_length", "5"); err != nil {
t.Fatalf("Failed to set min_hash_length: %v", err)
}
// With min_hash_length=5, all IDs should be at least 5 chars
for i := 0; i < 20; i++ {
issue := &types.Issue{
Title: formatTitle("Issue %d", i),
Description: "Test",
Status: "open",
Priority: 1,
IssueType: "task",
}
if err := db.CreateIssue(ctx, issue, "test@example.com"); err != nil {
t.Fatalf("Failed to create issue: %v", err)
}
hashPart := strings.TrimPrefix(issue.ID, "test-")
// With min_hash_length=5, should use at least 5 chars
if len(hashPart) < 5 {
t.Errorf("Issue %d with min_hash_length=5: hash length = %d, want >= 5", i, len(hashPart))
}
}
}