Files
beads/cmd/bd/comments_test.go
Steve Yegge 0b1a86a207 test: Refactor P1 test files to use shared DB pattern (bd-1rh)
Refactored 6 high-priority test files to reduce database initializations
and improve test suite performance:

- create_test.go: Combined 11 tests into TestCreateSuite (11 DBs → 1 DB)
- dep_test.go: Combined into TestDependencySuite (4 DBs → 1 DB)
- comments_test.go: Combined into TestCommentsSuite (2 DBs → 1 DB)
- list_test.go: Split into 2 suites to avoid data pollution (2 DBs → 2 DBs)
- ready_test.go: Combined into TestReadySuite (3 DBs → 1 DB)
- stale_test.go: Kept as individual functions due to data isolation needs

Added TEST_SUITE_AUDIT.md documenting the refactoring plan, results,
and key learnings for future test development.

Results:
- P1 tests now run in 0.43 seconds
- Estimated 10-20x speedup
- All tests passing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-21 15:51:07 -05:00

186 lines
4.8 KiB
Go

package main
import (
"context"
"fmt"
"path/filepath"
"testing"
"github.com/steveyegge/beads/internal/types"
)
const testUserAlice = "alice"
func TestCommentsSuite(t *testing.T) {
tmpDir := t.TempDir()
testDB := filepath.Join(tmpDir, ".beads", "beads.db")
s := newTestStore(t, testDB)
ctx := context.Background()
t.Run("CommentsCommand", func(t *testing.T) {
// Create test issue
issue := &types.Issue{
Title: "Test Issue",
Description: "Test description",
Priority: 1,
IssueType: types.TypeBug,
Status: types.StatusOpen,
}
if err := s.CreateIssue(ctx, issue, "test-user"); err != nil {
t.Fatalf("Failed to create issue: %v", err)
}
t.Run("add comment", func(t *testing.T) {
comment, err := s.AddIssueComment(ctx, issue.ID, testUserAlice, "This is a test comment")
if err != nil {
t.Fatalf("Failed to add comment: %v", err)
}
if comment.IssueID != issue.ID {
t.Errorf("Expected issue ID %s, got %s", issue.ID, comment.IssueID)
}
if comment.Author != testUserAlice {
t.Errorf("Expected author alice, got %s", comment.Author)
}
if comment.Text != "This is a test comment" {
t.Errorf("Expected text 'This is a test comment', got %s", comment.Text)
}
})
t.Run("list comments", func(t *testing.T) {
comments, err := s.GetIssueComments(ctx, issue.ID)
if err != nil {
t.Fatalf("Failed to get comments: %v", err)
}
if len(comments) != 1 {
t.Errorf("Expected 1 comment, got %d", len(comments))
}
if comments[0].Text != "This is a test comment" {
t.Errorf("Expected comment text, got %s", comments[0].Text)
}
})
t.Run("multiple comments", func(t *testing.T) {
_, err := s.AddIssueComment(ctx, issue.ID, "bob", "Second comment")
if err != nil {
t.Fatalf("Failed to add second comment: %v", err)
}
comments, err := s.GetIssueComments(ctx, issue.ID)
if err != nil {
t.Fatalf("Failed to get comments: %v", err)
}
if len(comments) != 2 {
t.Errorf("Expected 2 comments, got %d", len(comments))
}
})
t.Run("comments on non-existent issue", func(t *testing.T) {
comments, err := s.GetIssueComments(ctx, "bd-nonexistent")
if err != nil {
t.Fatalf("Unexpected error: %v", err)
}
if len(comments) != 0 {
t.Errorf("Expected 0 comments for non-existent issue, got %d", len(comments))
}
})
})
t.Run("CommentAlias", func(t *testing.T) {
// Create test issue
issue := &types.Issue{
Title: "Test Issue for Alias",
Description: "Test description",
Priority: 1,
IssueType: types.TypeBug,
Status: types.StatusOpen,
}
if err := s.CreateIssue(ctx, issue, "test-user"); err != nil {
t.Fatalf("Failed to create issue: %v", err)
}
t.Run("comment alias shares Run function with comments add", func(t *testing.T) {
// This verifies that commentCmd reuses commentsAddCmd.Run
if commentCmd.Run == nil {
t.Error("commentCmd.Run is nil")
}
if commentsAddCmd.Run == nil {
t.Error("commentsAddCmd.Run is nil")
}
// Verify they share the same Run function (same memory address)
// This is a compile-time guarantee from how we defined it
// Just verify the command structure is set up correctly
if commentCmd.Use != "comment [issue-id] [text]" {
t.Errorf("Expected Use to be 'comment [issue-id] [text]', got %s", commentCmd.Use)
}
if commentCmd.Short != "Add a comment to an issue (alias for 'comments add')" {
t.Errorf("Unexpected Short description: %s", commentCmd.Short)
}
})
t.Run("comment added via storage API works", func(t *testing.T) {
// Test direct storage API (which is what the command uses under the hood)
comment, err := s.AddIssueComment(ctx, issue.ID, testUserAlice, "Test comment")
if err != nil {
t.Fatalf("Failed to add comment: %v", err)
}
if comment.Text != "Test comment" {
t.Errorf("Expected 'Test comment', got %s", comment.Text)
}
// Verify via GetIssueComments
comments, err := s.GetIssueComments(ctx, issue.ID)
if err != nil {
t.Fatalf("Failed to get comments: %v", err)
}
if len(comments) != 1 {
t.Fatalf("Expected 1 comment, got %d", len(comments))
}
})
})
}
func TestIsUnknownOperationError(t *testing.T) {
tests := []struct {
name string
err error
expected bool
}{
{
name: "nil error",
err: nil,
expected: false,
},
{
name: "unknown operation error",
err: fmt.Errorf("unknown operation: test"),
expected: true,
},
{
name: "other error",
err: fmt.Errorf("some other error"),
expected: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := isUnknownOperationError(tt.err)
if result != tt.expected {
t.Errorf("Expected %v, got %v for error: %v", tt.expected, result, tt.err)
}
})
}
}