9520e7a2e2
- Created internal/util/strings.go with NormalizeLabels function - Added comprehensive tests in internal/util/strings_test.go - Updated internal/rpc/server_issues_epics.go to use util.NormalizeLabels - Updated cmd/bd/list.go and cmd/bd/ready.go to use util.NormalizeLabels - Updated cmd/bd/list_test.go to use util.NormalizeLabels - Removed duplicate implementations - All tests pass Fixes bd-fb95094c.6 Amp-Thread-ID: https://ampcode.com/threads/T-edb3c286-cd60-4231-94cd-edaf75d84a3d Co-authored-by: Amp <amp@ampcode.com>
105 lines
2.6 KiB
Go
105 lines
2.6 KiB
Go
package util
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
func TestNormalizeLabels(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
input []string
|
|
expected []string
|
|
}{
|
|
{
|
|
name: "empty slice",
|
|
input: []string{},
|
|
expected: []string{},
|
|
},
|
|
{
|
|
name: "nil slice",
|
|
input: nil,
|
|
expected: []string{},
|
|
},
|
|
{
|
|
name: "single label",
|
|
input: []string{"bug"},
|
|
expected: []string{"bug"},
|
|
},
|
|
{
|
|
name: "multiple labels",
|
|
input: []string{"bug", "critical", "frontend"},
|
|
expected: []string{"bug", "critical", "frontend"},
|
|
},
|
|
{
|
|
name: "labels with whitespace",
|
|
input: []string{" bug ", " critical", "frontend "},
|
|
expected: []string{"bug", "critical", "frontend"},
|
|
},
|
|
{
|
|
name: "duplicate labels",
|
|
input: []string{"bug", "bug", "critical"},
|
|
expected: []string{"bug", "critical"},
|
|
},
|
|
{
|
|
name: "duplicates after trimming",
|
|
input: []string{"bug", " bug ", " bug"},
|
|
expected: []string{"bug"},
|
|
},
|
|
{
|
|
name: "empty strings",
|
|
input: []string{"bug", "", "critical"},
|
|
expected: []string{"bug", "critical"},
|
|
},
|
|
{
|
|
name: "whitespace-only strings",
|
|
input: []string{"bug", " ", "critical", "\t", "\n"},
|
|
expected: []string{"bug", "critical"},
|
|
},
|
|
{
|
|
name: "preserves order",
|
|
input: []string{"zebra", "apple", "banana"},
|
|
expected: []string{"zebra", "apple", "banana"},
|
|
},
|
|
{
|
|
name: "complex case with all issues",
|
|
input: []string{" bug ", "", "bug", "critical", " ", "frontend", "critical", " frontend "},
|
|
expected: []string{"bug", "critical", "frontend"},
|
|
},
|
|
{
|
|
name: "unicode labels",
|
|
input: []string{"🐛 bug", " 🐛 bug ", "🚀 feature"},
|
|
expected: []string{"🐛 bug", "🚀 feature"},
|
|
},
|
|
{
|
|
name: "case-sensitive",
|
|
input: []string{"Bug", "bug", "BUG"},
|
|
expected: []string{"Bug", "bug", "BUG"},
|
|
},
|
|
{
|
|
name: "labels with internal spaces",
|
|
input: []string{"needs review", " needs review ", "in progress"},
|
|
expected: []string{"needs review", "in progress"},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
result := NormalizeLabels(tt.input)
|
|
if !reflect.DeepEqual(result, tt.expected) {
|
|
t.Errorf("NormalizeLabels(%v) = %v, want %v", tt.input, result, tt.expected)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNormalizeLabels_PreservesCapacity(t *testing.T) {
|
|
input := []string{"bug", "critical", "frontend"}
|
|
result := NormalizeLabels(input)
|
|
|
|
// Result should have reasonable capacity (not excessive allocation)
|
|
if cap(result) > len(input)*2 {
|
|
t.Errorf("NormalizeLabels capacity too large: got %d, input len %d", cap(result), len(input))
|
|
}
|
|
}
|