Files
beads/cmd/bd/create_test.go
Steve Yegge 0b1a86a207 test: Refactor P1 test files to use shared DB pattern (bd-1rh)
Refactored 6 high-priority test files to reduce database initializations
and improve test suite performance:

- create_test.go: Combined 11 tests into TestCreateSuite (11 DBs → 1 DB)
- dep_test.go: Combined into TestDependencySuite (4 DBs → 1 DB)
- comments_test.go: Combined into TestCommentsSuite (2 DBs → 1 DB)
- list_test.go: Split into 2 suites to avoid data pollution (2 DBs → 2 DBs)
- ready_test.go: Combined into TestReadySuite (3 DBs → 1 DB)
- stale_test.go: Kept as individual functions due to data isolation needs

Added TEST_SUITE_AUDIT.md documenting the refactoring plan, results,
and key learnings for future test development.

Results:
- P1 tests now run in 0.43 seconds
- Estimated 10-20x speedup
- All tests passing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-21 15:51:07 -05:00

555 lines
13 KiB
Go

package main
import (
"context"
"path/filepath"
"testing"
"time"
"github.com/steveyegge/beads/internal/types"
)
func TestCreateSuite(t *testing.T) {
tmpDir := t.TempDir()
testDB := filepath.Join(tmpDir, ".beads", "beads.db")
s := newTestStore(t, testDB)
ctx := context.Background()
t.Run("BasicIssue", func(t *testing.T) {
issue := &types.Issue{
Title: "Test Issue",
Priority: 1,
IssueType: types.TypeBug,
Status: types.StatusOpen,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
if len(issues) == 0 {
t.Fatal("expected at least 1 issue, got 0")
}
// Find our issue
var created *types.Issue
for _, iss := range issues {
if iss.Title == "Test Issue" {
created = iss
break
}
}
if created == nil {
t.Fatal("could not find created issue")
}
if created.Title != "Test Issue" {
t.Errorf("expected title 'Test Issue', got %q", created.Title)
}
if created.Priority != 1 {
t.Errorf("expected priority 1, got %d", created.Priority)
}
if created.IssueType != types.TypeBug {
t.Errorf("expected type bug, got %s", created.IssueType)
}
})
t.Run("WithDescription", func(t *testing.T) {
issue := &types.Issue{
Title: "Issue with desc",
Description: "This is a description",
Priority: 2,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Find our issue
var created *types.Issue
for _, iss := range issues {
if iss.Title == "Issue with desc" {
created = iss
break
}
}
if created == nil {
t.Fatal("could not find created issue")
}
if created.Description != "This is a description" {
t.Errorf("expected description, got %q", created.Description)
}
})
t.Run("WithDesignAndAcceptance", func(t *testing.T) {
issue := &types.Issue{
Title: "Feature with design",
Design: "Use MVC pattern",
AcceptanceCriteria: "All tests pass",
IssueType: types.TypeFeature,
Priority: 2,
Status: types.StatusOpen,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Find our issue
var created *types.Issue
for _, iss := range issues {
if iss.Title == "Feature with design" {
created = iss
break
}
}
if created == nil {
t.Fatal("could not find created issue")
}
if created.Design != "Use MVC pattern" {
t.Errorf("expected design, got %q", created.Design)
}
if created.AcceptanceCriteria != "All tests pass" {
t.Errorf("expected acceptance criteria, got %q", created.AcceptanceCriteria)
}
})
t.Run("WithLabels", func(t *testing.T) {
issue := &types.Issue{
Title: "Issue with labels",
Priority: 0,
Status: types.StatusOpen,
IssueType: types.TypeBug,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
// Add labels
if err := s.AddLabel(ctx, issue.ID, "bug", "test"); err != nil {
t.Fatalf("failed to add bug label: %v", err)
}
if err := s.AddLabel(ctx, issue.ID, "critical", "test"); err != nil {
t.Fatalf("failed to add critical label: %v", err)
}
labels, err := s.GetLabels(ctx, issue.ID)
if err != nil {
t.Fatalf("failed to get labels: %v", err)
}
if len(labels) != 2 {
t.Errorf("expected 2 labels, got %d", len(labels))
}
labelMap := make(map[string]bool)
for _, l := range labels {
labelMap[l] = true
}
if !labelMap["bug"] || !labelMap["critical"] {
t.Errorf("expected labels 'bug' and 'critical', got %v", labels)
}
})
t.Run("WithDependencies", func(t *testing.T) {
parent := &types.Issue{
Title: "Parent issue",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, parent, "test"); err != nil {
t.Fatalf("failed to create parent: %v", err)
}
child := &types.Issue{
Title: "Child issue",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, child, "test"); err != nil {
t.Fatalf("failed to create child: %v", err)
}
// Add dependency
dep := &types.Dependency{
IssueID: child.ID,
DependsOnID: parent.ID,
Type: types.DepBlocks,
CreatedAt: time.Now(),
}
if err := s.AddDependency(ctx, dep, "test"); err != nil {
t.Fatalf("failed to add dependency: %v", err)
}
deps, err := s.GetDependencies(ctx, child.ID)
if err != nil {
t.Fatalf("failed to get dependencies: %v", err)
}
if len(deps) == 0 {
t.Fatal("expected at least 1 dependency, got 0")
}
// Find the dependency on parent
found := false
for _, d := range deps {
if d.ID == parent.ID {
found = true
break
}
}
if !found {
t.Errorf("expected dependency on %s, not found", parent.ID)
}
})
t.Run("WithDiscoveredFromDependency", func(t *testing.T) {
parent := &types.Issue{
Title: "Parent work",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, parent, "test"); err != nil {
t.Fatalf("failed to create parent: %v", err)
}
discovered := &types.Issue{
Title: "Found bug",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeBug,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, discovered, "test"); err != nil {
t.Fatalf("failed to create discovered issue: %v", err)
}
// Add discovered-from dependency
dep := &types.Dependency{
IssueID: discovered.ID,
DependsOnID: parent.ID,
Type: types.DepDiscoveredFrom,
CreatedAt: time.Now(),
}
if err := s.AddDependency(ctx, dep, "test"); err != nil {
t.Fatalf("failed to add dependency: %v", err)
}
deps, err := s.GetDependencies(ctx, discovered.ID)
if err != nil {
t.Fatalf("failed to get dependencies: %v", err)
}
if len(deps) == 0 {
t.Fatal("expected at least 1 dependency, got 0")
}
// Find the dependency on parent
found := false
for _, d := range deps {
if d.ID == parent.ID {
found = true
break
}
}
if !found {
t.Errorf("expected dependency on %s, not found", parent.ID)
}
})
t.Run("WithExplicitID", func(t *testing.T) {
issue := &types.Issue{
ID: "test-abc123",
Title: "Custom ID issue",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Find our issue
found := false
for _, iss := range issues {
if iss.ID == "test-abc123" {
found = true
break
}
}
if !found {
t.Error("expected to find issue with ID 'test-abc123'")
}
})
t.Run("WithAssignee", func(t *testing.T) {
issue := &types.Issue{
Title: "Assigned issue",
Assignee: "alice",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Find our issue
var created *types.Issue
for _, iss := range issues {
if iss.Title == "Assigned issue" {
created = iss
break
}
}
if created == nil {
t.Fatal("could not find created issue")
}
if created.Assignee != "alice" {
t.Errorf("expected assignee 'alice', got %q", created.Assignee)
}
})
t.Run("AllIssueTypes", func(t *testing.T) {
issueTypes := []types.IssueType{
types.TypeBug,
types.TypeFeature,
types.TypeTask,
types.TypeEpic,
types.TypeChore,
}
createdIDs := make(map[string]bool)
for _, issueType := range issueTypes {
issue := &types.Issue{
Title: "Test " + string(issueType),
IssueType: issueType,
Priority: 2,
Status: types.StatusOpen,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue type %s: %v", issueType, err)
}
createdIDs[issue.ID] = true
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Verify all 5 types were created
foundCount := 0
for _, iss := range issues {
if createdIDs[iss.ID] {
foundCount++
}
}
if foundCount != 5 {
t.Errorf("expected to find 5 created issues, found %d", foundCount)
}
})
t.Run("MultipleDependencies", func(t *testing.T) {
parent1 := &types.Issue{
Title: "Parent 1",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
parent2 := &types.Issue{
Title: "Parent 2",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
child := &types.Issue{
Title: "Child",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, parent1, "test"); err != nil {
t.Fatalf("failed to create parent1: %v", err)
}
if err := s.CreateIssue(ctx, parent2, "test"); err != nil {
t.Fatalf("failed to create parent2: %v", err)
}
if err := s.CreateIssue(ctx, child, "test"); err != nil {
t.Fatalf("failed to create child: %v", err)
}
// Add multiple dependencies
dep1 := &types.Dependency{
IssueID: child.ID,
DependsOnID: parent1.ID,
Type: types.DepBlocks,
CreatedAt: time.Now(),
}
dep2 := &types.Dependency{
IssueID: child.ID,
DependsOnID: parent2.ID,
Type: types.DepRelated,
CreatedAt: time.Now(),
}
if err := s.AddDependency(ctx, dep1, "test"); err != nil {
t.Fatalf("failed to add dep1: %v", err)
}
if err := s.AddDependency(ctx, dep2, "test"); err != nil {
t.Fatalf("failed to add dep2: %v", err)
}
deps, err := s.GetDependencies(ctx, child.ID)
if err != nil {
t.Fatalf("failed to get dependencies: %v", err)
}
if len(deps) < 2 {
t.Fatalf("expected at least 2 dependencies, got %d", len(deps))
}
// Verify both parents are in dependencies
foundParents := make(map[string]bool)
for _, d := range deps {
if d.ID == parent1.ID || d.ID == parent2.ID {
foundParents[d.ID] = true
}
}
if len(foundParents) != 2 {
t.Errorf("expected to find both parent dependencies, found %d", len(foundParents))
}
})
t.Run("DiscoveredFromInheritsSourceRepo", func(t *testing.T) {
// Create a parent issue with a custom source_repo
parent := &types.Issue{
Title: "Parent issue",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
SourceRepo: "/path/to/custom/repo",
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, parent, "test"); err != nil {
t.Fatalf("failed to create parent: %v", err)
}
// Create a discovered issue with discovered-from dependency
// This should inherit the parent's source_repo
discovered := &types.Issue{
Title: "Discovered bug",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeBug,
CreatedAt: time.Now(),
}
// Simulate what happens in create.go when --deps discovered-from:parent is used
// The source_repo should be inherited from the parent
parentIssue, err := s.GetIssue(ctx, parent.ID)
if err != nil {
t.Fatalf("failed to get parent issue: %v", err)
}
if parentIssue.SourceRepo != "" {
discovered.SourceRepo = parentIssue.SourceRepo
}
if err := s.CreateIssue(ctx, discovered, "test"); err != nil {
t.Fatalf("failed to create discovered issue: %v", err)
}
// Add discovered-from dependency
dep := &types.Dependency{
IssueID: discovered.ID,
DependsOnID: parent.ID,
Type: types.DepDiscoveredFrom,
CreatedAt: time.Now(),
}
if err := s.AddDependency(ctx, dep, "test"); err != nil {
t.Fatalf("failed to add dependency: %v", err)
}
// Verify the discovered issue inherited the source_repo
retrievedIssue, err := s.GetIssue(ctx, discovered.ID)
if err != nil {
t.Fatalf("failed to get discovered issue: %v", err)
}
if retrievedIssue.SourceRepo != parent.SourceRepo {
t.Errorf("expected source_repo %q, got %q", parent.SourceRepo, retrievedIssue.SourceRepo)
}
if retrievedIssue.SourceRepo != "/path/to/custom/repo" {
t.Errorf("expected source_repo '/path/to/custom/repo', got %q", retrievedIssue.SourceRepo)
}
})
}