* fix(routing): auto-enable hydration and flush JSONL after routed create Fixes split-brain bug where issues routed to different repos (via routing.mode=auto) weren't visible in bd list because JSONL wasn't updated and hydration wasn't configured. **Problem**: When routing.mode=auto routes issues to a separate repo (e.g., ~/.beads-planning), those issues don't appear in 'bd list' because: 1. Target repo's JSONL isn't flushed after create 2. Multi-repo hydration (repos.additional) not configured automatically 3. No doctor warnings about the misconfiguration **Changes**: 1. **Auto-flush JSONL after routed create** (cmd/bd/create.go) - After routing issue to target repo, immediately flush to JSONL - Tries target daemon's export RPC first (if daemon running) - Falls back to direct JSONL export if no daemon - Ensures hydration can read the new issue immediately 2. **Enable hydration in bd init --contributor** (cmd/bd/init_contributor.go) - Wizard now automatically adds planning repo to repos.additional - Users no longer need to manually run 'bd repo add' - Routed issues appear in bd list immediately after setup 3. **Add doctor check for hydrated repo daemons** (cmd/bd/doctor/daemon.go) - New CheckHydratedRepoDaemons() warns if daemons not running - Without daemons, JSONL becomes stale and hydration breaks - Suggests: cd <repo> && bd daemon start --local 4. **Add doctor check for routing+hydration mismatch** (cmd/bd/doctor/config_values.go) - Validates routing targets are in repos.additional - Catches split-brain configuration before users encounter it - Suggests: bd repo add <routing-target> **Testing**: Builds successfully. Unit/integration tests pending. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test(routing): add comprehensive tests for routing fixes Add unit tests for all 4 routing/hydration fixes: 1. **create_routing_flush_test.go** - Test JSONL flush after routing - TestFlushRoutedRepo_DirectExport: Verify direct JSONL export - TestPerformAtomicExport: Test atomic file operations - TestFlushRoutedRepo_PathExpansion: Test path handling - TestRoutingWithHydrationIntegration: E2E routing+hydration test 2. **daemon_test.go** - Test hydrated repo daemon check - TestCheckHydratedRepoDaemons: Test with/without daemons running - Covers no repos, daemons running, daemons missing scenarios 3. **config_values_test.go** - Test routing+hydration validation - Test routing without hydration (should warn) - Test routing with correct hydration (should pass) - Test routing target not in hydration list (should warn) - Test maintainer="." edge case (should pass) All tests follow existing patterns and use t.TempDir() for isolation. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix(tests): fix test failures and refine routing validation logic Fixes test failures and improves validation accuracy: 1. **Fix routing+hydration validation** (config_values.go) - Exclude "." from hasRoutingTargets check (current repo doesn't need hydration) - Prevents false warnings when maintainer="." or contributor="." 2. **Fix test ID generation** (create_routing_flush_test.go) - Use auto-generated IDs instead of hard-coded "beads-test1" - Respects test store prefix configuration (test-) - Fixed json.NewDecoder usage (file handle, not os.Open result) 3. **Fix config validation tests** (config_values_test.go) - Create actual directories for routing paths to pass path validation - Tests now verify both routing+hydration AND path existence checks 4. **Fix daemon test expectations** (daemon_test.go) - When database unavailable, check returns "No additional repos" not error - This is correct behavior (graceful degradation) All tests now pass: - TestFlushRoutedRepo* (3 tests) - TestPerformAtomicExport - TestCheckHydratedRepoDaemons (3 subtests) - TestCheckConfigValues routing tests (5 subtests) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * docs: clarify when git config beads.role maintainer is needed Clarify that maintainer role config is only needed in edge case: - Using GitHub HTTPS URL without credentials - But you have write access (are a maintainer) In most cases, beads auto-detects correctly via: - SSH URLs (git@github.com:owner/repo.git) - HTTPS with credentials This prevents confusion - users with SSH or credential-based HTTPS don't need to manually configure their role. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix(lint): address linter warnings in routing flush code - Add missing sqlite import in daemon.go - Fix unchecked client.Close() error return - Fix unchecked tempFile.Close() error returns - Mark unused parameters with _ prefix - Add nolint:gosec for safe tempPath construction Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Roland Tritsch <roland@ailtir.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
292 lines
8.0 KiB
Go
292 lines
8.0 KiB
Go
package doctor
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads/internal/git"
|
|
"github.com/steveyegge/beads/internal/storage/sqlite"
|
|
)
|
|
|
|
func TestCheckDaemonStatus(t *testing.T) {
|
|
t.Run("no beads directory", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
|
|
check := CheckDaemonStatus(tmpDir, "1.0.0")
|
|
|
|
// Should return OK when no .beads directory (daemon not needed)
|
|
if check.Status != StatusOK {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusOK)
|
|
}
|
|
})
|
|
|
|
t.Run("beads directory exists", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
beadsDir := filepath.Join(tmpDir, ".beads")
|
|
if err := os.Mkdir(beadsDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
check := CheckDaemonStatus(tmpDir, "1.0.0")
|
|
|
|
// Should check daemon status - may be OK or warning depending on daemon state
|
|
if check.Name != "Daemon Health" {
|
|
t.Errorf("Name = %q, want %q", check.Name, "Daemon Health")
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestCheckGitSyncSetup(t *testing.T) {
|
|
t.Run("not in git repository", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
oldDir, err := os.Getwd()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() {
|
|
_ = os.Chdir(oldDir)
|
|
git.ResetCaches()
|
|
}()
|
|
|
|
if err := os.Chdir(tmpDir); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
git.ResetCaches()
|
|
|
|
check := CheckGitSyncSetup(tmpDir)
|
|
|
|
if check.Status != StatusWarning {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusWarning)
|
|
}
|
|
if check.Name != "Git Sync Setup" {
|
|
t.Errorf("Name = %q, want %q", check.Name, "Git Sync Setup")
|
|
}
|
|
if check.Fix == "" {
|
|
t.Error("Expected Fix to contain instructions")
|
|
}
|
|
})
|
|
|
|
t.Run("in git repository without sync-branch", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
oldDir, err := os.Getwd()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() {
|
|
_ = os.Chdir(oldDir)
|
|
git.ResetCaches()
|
|
}()
|
|
|
|
// Initialize git repo
|
|
cmd := exec.Command("git", "init", "--initial-branch=main")
|
|
cmd.Dir = tmpDir
|
|
if err := cmd.Run(); err != nil {
|
|
t.Fatalf("Failed to init git repo: %v", err)
|
|
}
|
|
|
|
if err := os.Chdir(tmpDir); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
git.ResetCaches()
|
|
|
|
check := CheckGitSyncSetup(tmpDir)
|
|
|
|
if check.Status != StatusOK {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusOK)
|
|
}
|
|
if check.Name != "Git Sync Setup" {
|
|
t.Errorf("Name = %q, want %q", check.Name, "Git Sync Setup")
|
|
}
|
|
// Should mention sync-branch not configured
|
|
if check.Detail == "" {
|
|
t.Error("Expected Detail to contain sync-branch hint")
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestCheckDaemonAutoSync(t *testing.T) {
|
|
t.Run("no daemon socket", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
beadsDir := filepath.Join(tmpDir, ".beads")
|
|
if err := os.Mkdir(beadsDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
check := CheckDaemonAutoSync(tmpDir)
|
|
|
|
if check.Status != StatusOK {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusOK)
|
|
}
|
|
if check.Message != "Daemon not running (will use defaults on next start)" {
|
|
t.Errorf("Message = %q, want 'Daemon not running...'", check.Message)
|
|
}
|
|
})
|
|
|
|
t.Run("no sync-branch configured", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
beadsDir := filepath.Join(tmpDir, ".beads")
|
|
if err := os.Mkdir(beadsDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create database without sync-branch config
|
|
dbPath := filepath.Join(beadsDir, "beads.db")
|
|
ctx := context.Background()
|
|
store, err := sqlite.New(ctx, dbPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() { _ = store.Close() }()
|
|
|
|
// Create a fake socket file to simulate daemon running
|
|
socketPath := filepath.Join(beadsDir, "bd.sock")
|
|
if err := os.WriteFile(socketPath, []byte{}, 0600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
check := CheckDaemonAutoSync(tmpDir)
|
|
|
|
// Should return OK because no sync-branch means auto-sync not applicable
|
|
if check.Status != StatusOK {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusOK)
|
|
}
|
|
if check.Message != "No sync-branch configured (auto-sync not applicable)" {
|
|
t.Errorf("Message = %q, want 'No sync-branch...'", check.Message)
|
|
}
|
|
})
|
|
|
|
t.Run("sync-branch configured but cannot connect", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
beadsDir := filepath.Join(tmpDir, ".beads")
|
|
if err := os.Mkdir(beadsDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create database with sync-branch config
|
|
dbPath := filepath.Join(beadsDir, "beads.db")
|
|
ctx := context.Background()
|
|
store, err := sqlite.New(ctx, dbPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := store.SetConfig(ctx, "sync.branch", "beads-sync"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
_ = store.Close()
|
|
|
|
// Create a fake socket file (not a real daemon)
|
|
socketPath := filepath.Join(beadsDir, "bd.sock")
|
|
if err := os.WriteFile(socketPath, []byte{}, 0600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
check := CheckDaemonAutoSync(tmpDir)
|
|
|
|
// Should return warning because can't connect to fake socket
|
|
if check.Status != StatusWarning {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusWarning)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestCheckHydratedRepoDaemons(t *testing.T) {
|
|
t.Run("no additional repos configured", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
beadsDir := filepath.Join(tmpDir, ".beads")
|
|
if err := os.Mkdir(beadsDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create database without repos.additional config
|
|
dbPath := filepath.Join(beadsDir, "beads.db")
|
|
ctx := context.Background()
|
|
store, err := sqlite.New(ctx, dbPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() { _ = store.Close() }()
|
|
|
|
check := CheckHydratedRepoDaemons(tmpDir)
|
|
|
|
if check.Status != StatusOK {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusOK)
|
|
}
|
|
if check.Name != "Hydrated Repo Daemons" {
|
|
t.Errorf("Name = %q, want %q", check.Name, "Hydrated Repo Daemons")
|
|
}
|
|
// Should say no additional repos configured
|
|
if check.Message != "No additional repos configured (N/A)" {
|
|
t.Errorf("Message = %q, want 'No additional repos configured (N/A)'", check.Message)
|
|
}
|
|
})
|
|
|
|
t.Run("additional repos configured but no daemons running", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
beadsDir := filepath.Join(tmpDir, ".beads")
|
|
if err := os.Mkdir(beadsDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create a fake additional repo directory
|
|
additionalRepo := t.TempDir()
|
|
additionalBeadsDir := filepath.Join(additionalRepo, ".beads")
|
|
if err := os.Mkdir(additionalBeadsDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create database with repos.additional config
|
|
dbPath := filepath.Join(beadsDir, "beads.db")
|
|
ctx := context.Background()
|
|
store, err := sqlite.New(ctx, dbPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() { _ = store.Close() }()
|
|
|
|
// Set repos.additional config (stored as JSON array)
|
|
reposJSON := `["` + additionalRepo + `"]`
|
|
if err := store.SetConfig(ctx, "repos.additional", reposJSON); err != nil {
|
|
t.Fatalf("failed to set repos.additional: %v", err)
|
|
}
|
|
|
|
check := CheckHydratedRepoDaemons(tmpDir)
|
|
|
|
// Should return warning because no daemon is running in additional repo
|
|
if check.Status != StatusWarning {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusWarning)
|
|
}
|
|
if check.Name != "Hydrated Repo Daemons" {
|
|
t.Errorf("Name = %q, want %q", check.Name, "Hydrated Repo Daemons")
|
|
}
|
|
// Should mention missing daemons
|
|
if check.Fix == "" {
|
|
t.Error("Expected Fix to contain remediation steps")
|
|
}
|
|
})
|
|
|
|
t.Run("database unavailable", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
beadsDir := filepath.Join(tmpDir, ".beads")
|
|
if err := os.Mkdir(beadsDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Don't create database - should handle gracefully
|
|
|
|
check := CheckHydratedRepoDaemons(tmpDir)
|
|
|
|
// When database is unavailable, GetConfig returns empty string,
|
|
// so the check reports "No additional repos configured" which is OK status
|
|
if check.Status != StatusOK {
|
|
t.Errorf("Status = %q, want %q", check.Status, StatusOK)
|
|
}
|
|
// The function returns early when no config is found, treating it as "no repos"
|
|
if !contains(check.Message, "No additional repos configured") {
|
|
t.Errorf("Message = %q, want message about no additional repos", check.Message)
|
|
}
|
|
})
|
|
}
|