From 0a6b0b892f38c99d0f830a4c28ce8234a696500a Mon Sep 17 00:00:00 2001 From: gastown/crew/mel Date: Tue, 20 Jan 2026 20:18:55 -0800 Subject: [PATCH] fix(witness,rig): code review cleanup - Remove unused workDir field from witness manager - Use witMgr.IsRunning() consistently instead of direct tmux call Co-Authored-By: Claude Opus 4.5 --- internal/cmd/rig.go | 5 ++--- internal/witness/manager.go | 6 ++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/internal/cmd/rig.go b/internal/cmd/rig.go index cc732f0e..c3127d08 100644 --- a/internal/cmd/rig.go +++ b/internal/cmd/rig.go @@ -1073,9 +1073,8 @@ func runRigStatus(cmd *cobra.Command, args []string) error { // Witness status fmt.Printf("%s\n", style.Bold.Render("Witness")) - witnessSession := fmt.Sprintf("gt-%s-witness", rigName) - witnessRunning, _ := t.HasSession(witnessSession) - _ = witness.NewManager(r) // silence unused warning, manager created for consistency + witMgr := witness.NewManager(r) + witnessRunning, _ := witMgr.IsRunning() if witnessRunning { fmt.Printf(" %s running\n", style.Success.Render("●")) } else { diff --git a/internal/witness/manager.go b/internal/witness/manager.go index a24d9861..48d6ec8d 100644 --- a/internal/witness/manager.go +++ b/internal/witness/manager.go @@ -27,15 +27,13 @@ var ( // Manager handles witness lifecycle and monitoring operations. // ZFC-compliant: tmux session is the source of truth for running state. type Manager struct { - rig *rig.Rig - workDir string + rig *rig.Rig } // NewManager creates a new witness manager for a rig. func NewManager(r *rig.Rig) *Manager { return &Manager{ - rig: r, - workDir: r.Path, + rig: r, } }