johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: handle crypto/rand.Read error in ID generation (gt-qysj9)

Browse Source 
Panic if crypto/rand.Read fails rather than silently returning
zero IDs which could cause message collisions.
This commit is contained in:
george
2026-01-04 23:58:19 -08:00
committed by Steve Yegge
parent 820ff17f9a
commit 117e6a1852
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/mail/types.go
View File

@@ -144,14 +144,18 @@ func NewReplyMessage(from, to, subject, body string, original *Message) *Message
// generateID creates a random message ID. // generateID creates a random message ID.
func generateID() string { func generateID() string {
b := make([]byte, 8) b := make([]byte, 8)
_, _ = rand.Read(b) // crypto/rand.Read only fails on broken system if _, err := rand.Read(b); err != nil {
panic("crypto/rand.Read failed: " + err.Error())
}
return "msg-" + hex.EncodeToString(b) return "msg-" + hex.EncodeToString(b)
} }
// generateThreadID creates a random thread ID. // generateThreadID creates a random thread ID.
func generateThreadID() string { func generateThreadID() string {
b := make([]byte, 6) b := make([]byte, 6)
_, _ = rand.Read(b) // crypto/rand.Read only fails on broken system if _, err := rand.Read(b); err != nil {
panic("crypto/rand.Read failed: " + err.Error())
}
return "thread-" + hex.EncodeToString(b) return "thread-" + hex.EncodeToString(b)
} }