johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: Address golangci-lint errors (errcheck, gosec) (#76)

Browse Source 
Apply PR #76 from dannomayernotabot:

- Add golangci exclusions for internal package false positives
- Tighten file permissions (0644 -> 0600) for sensitive files
- Add ReadHeaderTimeout to HTTP server (slowloris prevention)
- Explicit error ignoring with _ = for intentional cases
- Add //nolint comments with justifications
- Spelling: cancelled -> canceled (US locale)

Co-Authored-By: dannomayernotabot <noreply@github.com>

🤖 Generated with Claude Code
This commit is contained in:
max
2026-01-03 16:11:40 -08:00
committed by Steve Yegge
parent 62848065e3
commit 1b69576573
82 changed files with 325 additions and 355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/cmd/nudge.go
View File

@@ -163,7 +163,7 @@ func runNudge(cmd *cobra.Command, args []string) error {
// Log nudge event
if townRoot, err := workspace.FindFromCwd(); err == nil && townRoot != "" {
LogNudge(townRoot, "deacon", message)
_ = LogNudge(townRoot, "deacon", message)
}
_ = events.LogFeed(events.TypeNudge, sender, events.NudgePayload("", "deacon", message))
return nil
@@ -202,7 +202,7 @@ func runNudge(cmd *cobra.Command, args []string) error {
// Log nudge event
if townRoot, err := workspace.FindFromCwd(); err == nil && townRoot != "" {
LogNudge(townRoot, target, message)
_ = LogNudge(townRoot, target, message)
}
_ = events.LogFeed(events.TypeNudge, sender, events.NudgePayload(rigName, target, message))
} else {
@@ -223,7 +223,7 @@ func runNudge(cmd *cobra.Command, args []string) error {
// Log nudge event
if townRoot, err := workspace.FindFromCwd(); err == nil && townRoot != "" {
LogNudge(townRoot, target, message)
_ = LogNudge(townRoot, target, message)
}
_ = events.LogFeed(events.TypeNudge, sender, events.NudgePayload("", target, message))
}
@@ -424,7 +424,7 @@ func resolveNudgePattern(pattern string, agents []*AgentSession) []string {
// Returns (shouldSend bool, level string, err error).
// If force is true, always returns true.
// If the agent bead cannot be found, returns true (fail-open for backward compatibility).
func shouldNudgeTarget(townRoot, targetAddress string, force bool) (bool, string, error) {
func shouldNudgeTarget(townRoot, targetAddress string, force bool) (bool, string, error) { //nolint:unparam // error return kept for future use
if force {
return true, "", nil
}