From 21cee0c45b4b5cfd708c8ee93e094b01c8a12a2a Mon Sep 17 00:00:00 2001 From: Dustin Smith Date: Wed, 21 Jan 2026 22:45:14 +0700 Subject: [PATCH] fix: handle error return from os.RemoveAll in defer --- internal/git/git.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/git/git.go b/internal/git/git.go index 801464e2..8a0775b1 100644 --- a/internal/git/git.go +++ b/internal/git/git.go @@ -127,7 +127,7 @@ func (g *Git) Clone(url, dest string) error { if err != nil { return fmt.Errorf("creating temp dir: %w", err) } - defer os.RemoveAll(tmpDir) + defer func() { _ = os.RemoveAll(tmpDir) }() tmpDest := filepath.Join(tmpDir, filepath.Base(dest)) cmd := exec.Command("git", "clone", url, tmpDest) @@ -167,7 +167,7 @@ func (g *Git) CloneWithReference(url, dest, reference string) error { if err != nil { return fmt.Errorf("creating temp dir: %w", err) } - defer os.RemoveAll(tmpDir) + defer func() { _ = os.RemoveAll(tmpDir) }() tmpDest := filepath.Join(tmpDir, filepath.Base(dest)) cmd := exec.Command("git", "clone", "--reference-if-able", reference, url, tmpDest) @@ -207,7 +207,7 @@ func (g *Git) CloneBare(url, dest string) error { if err != nil { return fmt.Errorf("creating temp dir: %w", err) } - defer os.RemoveAll(tmpDir) + defer func() { _ = os.RemoveAll(tmpDir) }() tmpDest := filepath.Join(tmpDir, filepath.Base(dest)) cmd := exec.Command("git", "clone", "--bare", url, tmpDest) @@ -289,7 +289,7 @@ func (g *Git) CloneBareWithReference(url, dest, reference string) error { if err != nil { return fmt.Errorf("creating temp dir: %w", err) } - defer os.RemoveAll(tmpDir) + defer func() { _ = os.RemoveAll(tmpDir) }() tmpDest := filepath.Join(tmpDir, filepath.Base(dest)) cmd := exec.Command("git", "clone", "--bare", "--reference-if-able", reference, url, tmpDest)