Document intentional error suppressions with comments (gt-zn9m)

All 156 instances of _ = error suppression in non-test code now have
explanatory comments documenting why the error is intentionally ignored.

Categories of intentional suppressions:
- non-fatal: session works without these - tmux environment setup
- non-fatal: theming failure does not affect operation - visual styling
- best-effort cleanup - defer cleanup on failure paths
- best-effort notification - mail/notifications that should not block
- best-effort interrupt - graceful shutdown attempts
- crypto/rand.Read only fails on broken system - random ID generation
- output errors non-actionable - fmt.Fprint to io.Writer

This addresses the silent failure and debugging concerns raised in the
issue by making the intentionality explicit in the code.

Generated with Claude Code https://claude.com/claude-code

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-25 23:14:13 -08:00
parent 99b1a11cbd
commit 34b5a3bb8d
41 changed files with 134 additions and 133 deletions

View File

@@ -106,7 +106,7 @@ func runMqIntegrationCreate(cmd *cobra.Command, args []string) error {
// 3. Push to origin
fmt.Printf("Pushing to origin...\n")
if err := g.Push("origin", branchName, false); err != nil {
// Clean up local branch on push failure
// Clean up local branch on push failure (best-effort cleanup)
_ = g.DeleteBranch(branchName, true)
return fmt.Errorf("pushing to origin: %w", err)
}
@@ -299,7 +299,7 @@ func runMqIntegrationLand(cmd *cobra.Command, args []string) error {
fmt.Printf("Merging %s to main...\n", branchName)
mergeMsg := fmt.Sprintf("Merge %s: %s\n\nEpic: %s", branchName, epic.Title, epicID)
if err := g.MergeNoFF("origin/"+branchName, mergeMsg); err != nil {
// Abort merge on failure
// Abort merge on failure (best-effort cleanup)
_ = g.AbortMerge()
return fmt.Errorf("merge failed: %w", err)
}
@@ -313,7 +313,7 @@ func runMqIntegrationLand(cmd *cobra.Command, args []string) error {
if err := runTestCommand(r.Path, testCmd); err != nil {
// Tests failed - reset main
fmt.Printf(" %s Tests failed, resetting main...\n", style.Bold.Render("✗"))
_ = g.Checkout("main")
_ = g.Checkout("main") // best-effort: need to be on main to reset
resetErr := resetHard(g, "HEAD~1")
if resetErr != nil {
return fmt.Errorf("tests failed and could not reset: %w (test error: %v)", resetErr, err)