johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fixing unit tests on windows (#813)

Browse Source 
* Add Windows stub for orphan cleanup

* Fix account switch tests on Windows

* Make query session events test portable

* Disable beads daemon in query session events test

* Add Windows bd stubs for sling tests

* Make expandOutputPath test OS-agnostic

* Make role_agents test Windows-friendly

* Make config path tests OS-agnostic

* Make HealthCheckStateFile test OS-agnostic

* Skip orphan process check on Windows

* Normalize sparse checkout detail paths

* Make dog path tests OS-agnostic

* Fix bare repo refspec config on Windows

* Add Windows process detection for locks

* Add Windows CI workflow

* Make mail path tests OS-agnostic

* Skip plugin file mode test on Windows

* Skip tmux-dependent polecat tests on Windows

* Normalize polecat paths and AGENTS.md content

* Make beads init failure test Windows-friendly

* Skip rig agent bead init test on Windows

* Make XDG path tests OS-agnostic

* Make exec tests portable on Windows

* Adjust atomic write tests for Windows

* Make wisp tests Windows-friendly

* Make workspace find tests OS-agnostic

* Fix Windows rig add integration test

* Make sling var logging Windows-friendly

* Fix sling attached molecule update ordering

---------

Co-authored-by: Johann Dirry <johann.dirry@microsea.at>
This commit is contained in:
Johann Dirry
2026-01-20 23:17:35 +01:00
committed by GitHub
parent b8a679c30c
commit 3d5a66f850
32 changed files with 626 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/util/atomic_test.go
View File

@@ -4,6 +4,7 @@ import (
"encoding/json"
"os"
"path/filepath"
"runtime"
"sync"
"testing"
)
@@ -189,6 +190,10 @@ func TestAtomicWriteJSONUnmarshallable(t *testing.T) {
}
func TestAtomicWriteFileReadOnlyDir(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("chmod-based read-only directories are not reliable on Windows")
}
tmpDir := t.TempDir()
roDir := filepath.Join(tmpDir, "readonly")
@@ -240,7 +245,11 @@ func TestAtomicWriteFileConcurrent(t *testing.T) {
if err != nil {
t.Fatalf("ReadFile error: %v", err)
}
if len(content) != 1 {
if runtime.GOOS == "windows" {
if len(content) == 0 {
t.Error("Expected non-empty content on Windows")
}
} else if len(content) != 1 {
t.Errorf("Expected single character, got %q", content)
}

42
internal/util/exec_test.go
View File

@@ -2,13 +2,20 @@ package util
import (
"os"
"runtime"
"strings"
"testing"
)
func TestExecWithOutput(t *testing.T) {
// Test successful command
output, err := ExecWithOutput(".", "echo", "hello")
var output string
var err error
if runtime.GOOS == "windows" {
output, err = ExecWithOutput(".", "cmd", "/c", "echo hello")
} else {
output, err = ExecWithOutput(".", "echo", "hello")
}
if err != nil {
t.Fatalf("ExecWithOutput failed: %v", err)
}
@@ -17,7 +24,11 @@ func TestExecWithOutput(t *testing.T) {
}
// Test command that fails
_, err = ExecWithOutput(".", "false")
if runtime.GOOS == "windows" {
_, err = ExecWithOutput(".", "cmd", "/c", "exit /b 1")
} else {
_, err = ExecWithOutput(".", "false")
}
if err == nil {
t.Error("expected error for failing command")
}
@@ -25,13 +36,22 @@ func TestExecWithOutput(t *testing.T) {
func TestExecRun(t *testing.T) {
// Test successful command
err := ExecRun(".", "true")
var err error
if runtime.GOOS == "windows" {
err = ExecRun(".", "cmd", "/c", "exit /b 0")
} else {
err = ExecRun(".", "true")
}
if err != nil {
t.Fatalf("ExecRun failed: %v", err)
}
// Test command that fails
err = ExecRun(".", "false")
if runtime.GOOS == "windows" {
err = ExecRun(".", "cmd", "/c", "exit /b 1")
} else {
err = ExecRun(".", "false")
}
if err == nil {
t.Error("expected error for failing command")
}
@@ -46,7 +66,12 @@ func TestExecWithOutput_WorkDir(t *testing.T) {
defer os.RemoveAll(tmpDir)
// Test that workDir is respected
output, err := ExecWithOutput(tmpDir, "pwd")
var output string
if runtime.GOOS == "windows" {
output, err = ExecWithOutput(tmpDir, "cmd", "/c", "cd")
} else {
output, err = ExecWithOutput(tmpDir, "pwd")
}
if err != nil {
t.Fatalf("ExecWithOutput failed: %v", err)
}
@@ -57,7 +82,12 @@ func TestExecWithOutput_WorkDir(t *testing.T) {
func TestExecWithOutput_StderrInError(t *testing.T) {
// Test that stderr is captured in error
_, err := ExecWithOutput(".", "sh", "-c", "echo 'error message' >&2; exit 1")
var err error
if runtime.GOOS == "windows" {
_, err = ExecWithOutput(".", "cmd", "/c", "echo error message 1>&2 & exit /b 1")
} else {
_, err = ExecWithOutput(".", "sh", "-c", "echo 'error message' >&2; exit 1")
}
if err == nil {
t.Error("expected error")
}