johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(lint): resolve all errcheck warnings

Browse Source 
Fix ~50 errcheck warnings across the codebase:

- Add explicit `_ =` for intentionally ignored error returns (cleanup,
  best-effort operations, etc.)
- Use `defer func() { _ = ... }()` pattern for defer statements
- Handle tmux SetEnvironment, KillSession, SendKeysRaw returns
- Handle mail router.Send returns
- Handle os.RemoveAll, os.Rename in cleanup paths
- Handle rand.Read returns for ID generation
- Handle fmt.Fprint* returns when writing to io.Writer
- Fix for-select with single case to use for-range
- Handle cobra MarkFlagRequired returns

All tests pass. Code compiles without errors.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-19 12:09:52 -08:00
parent 3a477f673c
commit 4048cdc373
29 changed files with 115 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/tmux/tmux.go
View File

@@ -260,7 +260,7 @@ func (t *Tmux) GetSessionInfo(name string) (*SessionInfo, error) {
}
windows := 0
fmt.Sscanf(parts[1], "%d", &windows)
_, _ = fmt.Sscanf(parts[1], "%d", &windows)
return &SessionInfo{
Name: parts[0],

16
internal/tmux/tmux_test.go
View File

@@ -50,13 +50,13 @@ func TestSessionLifecycle(t *testing.T) {
sessionName := "gt-test-session-" + t.Name()
// Clean up any existing session
tm.KillSession(sessionName)
_ = tm.KillSession(sessionName)
// Create session
if err := tm.NewSession(sessionName, ""); err != nil {
t.Fatalf("NewSession: %v", err)
}
defer tm.KillSession(sessionName)
defer func() { _ = tm.KillSession(sessionName) }()
// Verify exists
has, err := tm.HasSession(sessionName)
@@ -107,13 +107,13 @@ func TestDuplicateSession(t *testing.T) {
sessionName := "gt-test-dup-" + t.Name()
// Clean up any existing session
tm.KillSession(sessionName)
_ = tm.KillSession(sessionName)
// Create session
if err := tm.NewSession(sessionName, ""); err != nil {
t.Fatalf("NewSession: %v", err)
}
defer tm.KillSession(sessionName)
defer func() { _ = tm.KillSession(sessionName) }()
// Try to create duplicate
err := tm.NewSession(sessionName, "")
@@ -131,13 +131,13 @@ func TestSendKeysAndCapture(t *testing.T) {
sessionName := "gt-test-keys-" + t.Name()
// Clean up any existing session
tm.KillSession(sessionName)
_ = tm.KillSession(sessionName)
// Create session
if err := tm.NewSession(sessionName, ""); err != nil {
t.Fatalf("NewSession: %v", err)
}
defer tm.KillSession(sessionName)
defer func() { _ = tm.KillSession(sessionName) }()
// Send echo command
if err := tm.SendKeys(sessionName, "echo HELLO_TEST_MARKER"); err != nil {
@@ -167,13 +167,13 @@ func TestGetSessionInfo(t *testing.T) {
sessionName := "gt-test-info-" + t.Name()
// Clean up any existing session
tm.KillSession(sessionName)
_ = tm.KillSession(sessionName)
// Create session
if err := tm.NewSession(sessionName, ""); err != nil {
t.Fatalf("NewSession: %v", err)
}
defer tm.KillSession(sessionName)
defer func() { _ = tm.KillSession(sessionName) }()
info, err := tm.GetSessionInfo(sessionName)
if err != nil {