fix(convoy-tui): Address code review issues

- Add convoy ID validation to prevent SQL injection
- Add 5-second timeouts to all subprocess calls
- Batch issue lookups to eliminate N+1 query pattern
- Fix truncate() to handle multi-byte UTF-8 characters

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

internal/tui/convoy/model.go

@@ -2,18 +2,27 @@ package convoy
 
 import (
 	"bytes"
+	"context"
 	"encoding/json"
 	"fmt"
 	"os/exec"
 	"path/filepath"
+	"regexp"
 	"sort"
 	"strings"
+	"time"
 
 	"github.com/charmbracelet/bubbles/help"
 	"github.com/charmbracelet/bubbles/key"
 	tea "github.com/charmbracelet/bubbletea"
 )
 
+// convoyIDPattern validates convoy IDs to prevent SQL injection.
+var convoyIDPattern = regexp.MustCompile(`^hq-[a-zA-Z0-9-]+$`)
+
+// subprocessTimeout is the timeout for bd and sqlite3 calls.
+const subprocessTimeout = 5 * time.Second
+
 // IssueItem represents a tracked issue within a convoy.
 type IssueItem struct {
 	ID     string
@@ -75,9 +84,12 @@ func (m Model) fetchConvoys() tea.Msg {
 
 // loadConvoys loads convoy data from the beads directory.
 func loadConvoys(townBeads string) ([]ConvoyItem, error) {
+	ctx, cancel := context.WithTimeout(context.Background(), subprocessTimeout)
+	defer cancel()
+
 	// Get list of open convoys
 	listArgs := []string{"list", "--type=convoy", "--json"}
-	listCmd := exec.Command("bd", listArgs...)
+	listCmd := exec.CommandContext(ctx, "bd", listArgs...)
 	listCmd.Dir = townBeads
 	var stdout bytes.Buffer
 	listCmd.Stdout = &stdout
@@ -113,16 +125,24 @@ func loadConvoys(townBeads string) ([]ConvoyItem, error) {
 
 // loadTrackedIssues loads issues tracked by a convoy.
 func loadTrackedIssues(townBeads, convoyID string) ([]IssueItem, int, int) {
+	// Validate convoy ID to prevent SQL injection
+	if !convoyIDPattern.MatchString(convoyID) {
+		return nil, 0, 0
+	}
+
+	ctx, cancel := context.WithTimeout(context.Background(), subprocessTimeout)
+	defer cancel()
+
 	dbPath := filepath.Join(townBeads, "beads.db")
 
-	// Query tracked issues from SQLite
+	// Query tracked issues from SQLite (ID validated above)
 	query := fmt.Sprintf(`
 		SELECT d.depends_on_id
 		FROM dependencies d
 		WHERE d.issue_id = '%s' AND d.dependency_type = 'tracks'
 	`, convoyID)
 
-	cmd := exec.Command("sqlite3", "-json", dbPath, query)
+	cmd := exec.CommandContext(ctx, "sqlite3", "-json", dbPath, query)
 	var stdout bytes.Buffer
 	cmd.Stdout = &stdout
 
@@ -137,24 +157,27 @@ func loadTrackedIssues(townBeads, convoyID string) ([]IssueItem, int, int) {
 		return nil, 0, 0
 	}
 
-	issues := make([]IssueItem, 0, len(deps))
+	// Collect issue IDs, handling external references
-	completed := 0
+	issueIDs := make([]string, 0, len(deps))
-
 	for _, dep := range deps {
 		issueID := dep.DependsOnID
-
-		// Handle external references
 		if strings.HasPrefix(issueID, "external:") {
 			parts := strings.SplitN(issueID, ":", 3)
 			if len(parts) == 3 {
 				issueID = parts[2]
 			}
 		}
+		issueIDs = append(issueIDs, issueID)
+	}
 
-		// Get issue details
+	// Batch fetch all issue details in one call
-		issue := getIssueDetails(townBeads, issueID)
+	detailsMap := getIssueDetailsBatch(townBeads, issueIDs)
-		if issue != nil {
+
-			issues = append(issues, *issue)
+	issues := make([]IssueItem, 0, len(deps))
+	completed := 0
+	for _, id := range issueIDs {
+		if issue, ok := detailsMap[id]; ok {
+			issues = append(issues, issue)
 			if issue.Status == "closed" {
 				completed++
 			}
@@ -172,15 +195,28 @@ func loadTrackedIssues(townBeads, convoyID string) ([]IssueItem, int, int) {
 	return issues, completed, len(issues)
 }
 
-// getIssueDetails fetches details for a single issue.
+// getIssueDetailsBatch fetches details for multiple issues in a single bd show call.
-func getIssueDetails(townBeads, issueID string) *IssueItem {
+// Returns a map from issue ID to details.
-	cmd := exec.Command("bd", "show", issueID, "--json")
+func getIssueDetailsBatch(townBeads string, issueIDs []string) map[string]IssueItem {
+	result := make(map[string]IssueItem)
+	if len(issueIDs) == 0 {
+		return result
+	}
+
+	ctx, cancel := context.WithTimeout(context.Background(), subprocessTimeout)
+	defer cancel()
+
+	// Build args: bd show id1 id2 id3 ... --json
+	args := append([]string{"show"}, issueIDs...)
+	args = append(args, "--json")
+
+	cmd := exec.CommandContext(ctx, "bd", args...)
 	cmd.Dir = townBeads
 	var stdout bytes.Buffer
 	cmd.Stdout = &stdout
 
 	if err := cmd.Run(); err != nil {
-		return nil
+		return result // Return empty map on error
 	}
 
 	var issues []struct {
@@ -188,15 +224,19 @@ func getIssueDetails(townBeads, issueID string) *IssueItem {
 		Title  string `json:"title"`
 		Status string `json:"status"`
 	}
-	if err := json.Unmarshal(stdout.Bytes(), &issues); err != nil || len(issues) == 0 {
+	if err := json.Unmarshal(stdout.Bytes(), &issues); err != nil {
-		return nil
+		return result
 	}
 
-	return &IssueItem{
+	for _, issue := range issues {
-		ID:     issues[0].ID,
+		result[issue.ID] = IssueItem{
-		Title:  issues[0].Title,
+			ID:     issue.ID,
-		Status: issues[0].Status,
+			Title:  issue.Title,
+			Status: issue.Status,
+		}
 	}
+
+	return result
 }
 
 // Update handles messages.

internal/tui/convoy/view.go

@@ -3,6 +3,7 @@ package convoy
 import (
 	"fmt"
 	"strings"
+	"unicode/utf8"
 
 	"github.com/charmbracelet/lipgloss"
 )
@@ -146,10 +147,14 @@ func statusToIcon(status string) string {
 	}
 }
 
-// truncate shortens a string to the given length.
+// truncate shortens a string to the given rune length, preserving UTF-8.
 func truncate(s string, maxLen int) string {
-	if len(s) <= maxLen {
+	if utf8.RuneCountInString(s) <= maxLen {
 		return s
 	}
-	return s[:maxLen-3] + "..."
+	runes := []rune(s)
+	if maxLen <= 3 {
+		return "..."
+	}
+	return string(runes[:maxLen-3]) + "..."
 }