johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor: remove unused isFirstRig param from initAgentBeads (gt-fugmy)

Browse Source 
The isFirstRig parameter was no longer used - it was being assigned
to a blank identifier. Since initAgentBeads is an internal function
with only 2 callers in this repo, remove the parameter entirely.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
immortan
2026-01-04 10:37:21 -08:00
committed by Steve Yegge
parent b7d82c7243
commit 4d24f79492
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/rig/manager.go
+2 -5
View File
@@ -423,8 +423,7 @@ Use crew for your own workspace. Polecats are for batch work dispatch.
// Create rig-level agent beads (witness, refinery) in rig beads. // Create rig-level agent beads (witness, refinery) in rig beads.
// Town-level agents (mayor, deacon) are created by gt install in town beads. // Town-level agents (mayor, deacon) are created by gt install in town beads.
isFirstRig := len(m.config.Rigs) == 0 // Kept for backward compatibility if err := m.initAgentBeads(rigPath, opts.Name, opts.BeadsPrefix); err != nil {
if err := m.initAgentBeads(rigPath, opts.Name, opts.BeadsPrefix, isFirstRig); err != nil {
// Non-fatal: log warning but continue // Non-fatal: log warning but continue
fmt.Printf(" Warning: Could not create agent beads: %v\n", err) fmt.Printf(" Warning: Could not create agent beads: %v\n", err)
} }
@@ -536,7 +535,7 @@ func (m *Manager) initBeads(rigPath, prefix string) error {
// Format: <prefix>-<rig>-<role> (e.g., gt-gastown-witness) // Format: <prefix>-<rig>-<role> (e.g., gt-gastown-witness)
// //
// Agent beads track lifecycle state for ZFC compliance (gt-h3hak, gt-pinkq). // Agent beads track lifecycle state for ZFC compliance (gt-h3hak, gt-pinkq).
func (m *Manager) initAgentBeads(_, rigName, _ string, isFirstRig bool) error { // rigPath and prefix unused until Phase 2 func (m *Manager) initAgentBeads(_, rigName, _ string) error { // rigPath and prefix unused until Phase 2
// TEMPORARY (gt-4r1ph): Currently all agent beads go in town beads. // TEMPORARY (gt-4r1ph): Currently all agent beads go in town beads.
// After Phase 2, only Mayor/Deacon will be here; Witness/Refinery go to rig beads. // After Phase 2, only Mayor/Deacon will be here; Witness/Refinery go to rig beads.
townBeadsDir := filepath.Join(m.townRoot, ".beads") townBeadsDir := filepath.Join(m.townRoot, ".beads")
@@ -568,8 +567,6 @@ func (m *Manager) initAgentBeads(_, rigName, _ string, isFirstRig bool) error {
} }
// Note: Mayor and Deacon are now created by gt install in town beads. // Note: Mayor and Deacon are now created by gt install in town beads.
// isFirstRig parameter is kept for backward compatibility but no longer used.
_ = isFirstRig
for _, agent := range agents { for _, agent := range agents {
// Check if already exists // Check if already exists
internal/rig/manager_test.go
+1 -1
View File
@@ -381,7 +381,7 @@ esac
t.Setenv("BEADS_DIR", "") // Clear any existing BEADS_DIR t.Setenv("BEADS_DIR", "") // Clear any existing BEADS_DIR
manager := &Manager{townRoot: townRoot} manager := &Manager{townRoot: townRoot}
if err := manager.initAgentBeads(rigPath, "demo", "gt", false); err != nil { if err := manager.initAgentBeads(rigPath, "demo", "gt"); err != nil {
t.Fatalf("initAgentBeads: %v", err) t.Fatalf("initAgentBeads: %v", err)
} }