From 542bc32b00aa67e3e054ec50a1e3227679909d3e Mon Sep 17 00:00:00 2001 From: Steve Yegge Date: Wed, 17 Dec 2025 14:59:04 -0800 Subject: [PATCH] fix(polecat): code review fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Use errors.Is() instead of direct error comparison - Add warning output when listing polecats fails for a rig - Remove extra blank line 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- internal/cmd/polecat.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/cmd/polecat.go b/internal/cmd/polecat.go index f471adab..81d91129 100644 --- a/internal/cmd/polecat.go +++ b/internal/cmd/polecat.go @@ -2,6 +2,7 @@ package cmd import ( "encoding/json" + "errors" "fmt" "os" "path/filepath" @@ -165,7 +166,6 @@ func getPolecatManager(rigName string) (*polecat.Manager, *rig.Rig, error) { return mgr, r, nil } - func runPolecatList(cmd *cobra.Command, args []string) error { var rigs []*rig.Rig @@ -199,6 +199,7 @@ func runPolecatList(cmd *cobra.Command, args []string) error { polecats, err := mgr.List() if err != nil { + fmt.Fprintf(os.Stderr, "warning: failed to list polecats in %s: %v\n", r.Name, err) continue } @@ -303,7 +304,7 @@ func runPolecatRemove(cmd *cobra.Command, args []string) error { fmt.Printf("Removing polecat %s/%s...\n", rigName, polecatName) if err := mgr.Remove(polecatName); err != nil { - if err == polecat.ErrHasChanges && !polecatForce { + if errors.Is(err, polecat.ErrHasChanges) && !polecatForce { return fmt.Errorf("polecat has uncommitted changes. Use --force to remove anyway") } return fmt.Errorf("removing polecat: %w", err)