feat(doctor): add auto-fix capability to SessionHookCheck (#857)

Add Fix() method to SessionHookCheck to automatically update
settings.json files when 'gt prime' is used without '--hook'.
This enables 'gt doctor --fix' to repair existing installations
that use bare 'gt prime' in SessionStart/PreCompact hooks.

Changes:
- Changed SessionHookCheck to embed FixableCheck instead of BaseCheck
- Added filesToFix cache populated during Run()
- Implemented Fix() method that parses JSON and replaces 'gt prime'
  with 'gt prime --hook' in command strings
- Uses json.Encoder with SetEscapeHTML(false) to preserve readable
  ampersands in command strings

Closes: gt-1tj0c

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
aleiby
2026-01-21 19:11:34 -08:00
committed by GitHub
parent 3931d10af3
commit 5791cd7e34
2 changed files with 239 additions and 9 deletions

View File

@@ -228,11 +228,137 @@ func TestSessionHookCheck_Run(t *testing.T) {
})
}
func TestSessionHookCheck_Fix(t *testing.T) {
t.Run("fixes bare gt prime to gt prime --hook", func(t *testing.T) {
tmpDir := t.TempDir()
claudeDir := filepath.Join(tmpDir, ".claude")
if err := os.MkdirAll(claudeDir, 0755); err != nil {
t.Fatal(err)
}
// Create settings with bare gt prime
settings := `{"hooks": {"SessionStart": [{"hooks": [{"type": "command", "command": "gt prime"}]}]}}`
settingsPath := filepath.Join(claudeDir, "settings.json")
if err := os.WriteFile(settingsPath, []byte(settings), 0644); err != nil {
t.Fatal(err)
}
check := NewSessionHookCheck()
ctx := &CheckContext{TownRoot: tmpDir}
// Run to detect issue and cache file
result := check.Run(ctx)
if result.Status != StatusWarning {
t.Errorf("expected StatusWarning before fix, got %v", result.Status)
}
// Apply fix
if err := check.Fix(ctx); err != nil {
t.Fatalf("Fix failed: %v", err)
}
// Re-run to verify fix
result = check.Run(ctx)
if result.Status != StatusOK {
t.Errorf("expected StatusOK after fix, got %v: %v", result.Status, result.Details)
}
// Verify file content
data, err := os.ReadFile(settingsPath)
if err != nil {
t.Fatal(err)
}
content := string(data)
if !strings.Contains(content, "gt prime --hook") {
t.Errorf("expected 'gt prime --hook' in fixed file, got: %s", content)
}
})
t.Run("fixes multiple hooks in same file", func(t *testing.T) {
tmpDir := t.TempDir()
claudeDir := filepath.Join(tmpDir, ".claude")
if err := os.MkdirAll(claudeDir, 0755); err != nil {
t.Fatal(err)
}
settings := `{"hooks": {"SessionStart": [{"hooks": [{"type": "command", "command": "gt prime && echo done"}]}], "PreCompact": [{"hooks": [{"type": "command", "command": "gt prime"}]}]}}`
settingsPath := filepath.Join(claudeDir, "settings.json")
if err := os.WriteFile(settingsPath, []byte(settings), 0644); err != nil {
t.Fatal(err)
}
check := NewSessionHookCheck()
ctx := &CheckContext{TownRoot: tmpDir}
result := check.Run(ctx)
if result.Status != StatusWarning {
t.Errorf("expected StatusWarning before fix, got %v", result.Status)
}
if err := check.Fix(ctx); err != nil {
t.Fatalf("Fix failed: %v", err)
}
result = check.Run(ctx)
if result.Status != StatusOK {
t.Errorf("expected StatusOK after fix, got %v: %v", result.Status, result.Details)
}
data, err := os.ReadFile(settingsPath)
if err != nil {
t.Fatal(err)
}
content := string(data)
// Both hooks should now have --hook
if strings.Count(content, "gt prime --hook") != 2 {
t.Errorf("expected 2 occurrences of 'gt prime --hook', got content: %s", content)
}
})
t.Run("does not double-add --hook", func(t *testing.T) {
tmpDir := t.TempDir()
claudeDir := filepath.Join(tmpDir, ".claude")
if err := os.MkdirAll(claudeDir, 0755); err != nil {
t.Fatal(err)
}
settings := `{"hooks": {"SessionStart": [{"hooks": [{"type": "command", "command": "gt prime --hook"}]}]}}`
settingsPath := filepath.Join(claudeDir, "settings.json")
if err := os.WriteFile(settingsPath, []byte(settings), 0644); err != nil {
t.Fatal(err)
}
check := NewSessionHookCheck()
ctx := &CheckContext{TownRoot: tmpDir}
// Should already be OK
result := check.Run(ctx)
if result.Status != StatusOK {
t.Errorf("expected StatusOK for already-fixed file, got %v", result.Status)
}
// Fix should be no-op (no files cached)
if err := check.Fix(ctx); err != nil {
t.Fatalf("Fix failed: %v", err)
}
data, err := os.ReadFile(settingsPath)
if err != nil {
t.Fatal(err)
}
content := string(data)
// Should not have --hook --hook
if strings.Contains(content, "--hook --hook") {
t.Errorf("fix doubled --hook flag: %s", content)
}
})
}
func TestParseConfigOutput(t *testing.T) {
tests := []struct {
name string
input string
want string
name string
input string
want string
}{
{
name: "simple value",