johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(mail): filter by read status in ListUnread for beads mode (#936)

Browse Source 
ListUnread() was returning all open messages in beads mode instead of
filtering out messages marked as read. This caused `gt mail inbox --unread`
to show all messages even when they had the "read" label.

The fix unifies the code path for legacy and beads modes - both now
filter by the msg.Read field, which is correctly populated from the
"read" label via ToMessage().

Note: `gt mail read` intentionally does NOT mark messages as read
(to preserve handoff messages). Users should use `gt mail mark-read`
to explicitly mark messages as read.

Fixes gt-izcp85

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
aleiby
2026-01-24 21:45:22 -08:00
committed by GitHub
parent 6c86616273
commit 71077e93dd
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
internal/mail/mailbox.go
View File

@@ -281,8 +281,8 @@ func (m *Mailbox) listLegacy() ([]*Message, error) {
} }
// ListUnread returns unread (open) messages. // ListUnread returns unread (open) messages.
// Filters out messages marked as read (via "read" label in beads mode).
func (m *Mailbox) ListUnread() ([]*Message, error) { func (m *Mailbox) ListUnread() ([]*Message, error) {
if m.legacy {
all, err := m.List() all, err := m.List()
if err != nil { if err != nil {
return nil, err return nil, err
@@ -295,9 +295,6 @@ func (m *Mailbox) ListUnread() ([]*Message, error) {
} }
return unread, nil return unread, nil
} }
// For beads, inbox only returns open (unread) messages
return m.List()
}
// Get returns a message by ID. // Get returns a message by ID.
func (m *Mailbox) Get(id string) (*Message, error) { func (m *Mailbox) Get(id string) (*Message, error) {