johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(handoff): prevent self-kill during gt handoff (#881) (#882)

Browse Source 
gt handoff was calling KillPaneProcesses which killed Claude Code
(the pane process) before RespawnPane could be called. This caused
handoff to silently fail with no respawn.

Add KillPaneProcessesExcluding function that allows excluding specific
PIDs from being killed. The self-handoff path now excludes the current
process and its parent (Claude Code) so gt handoff survives long enough
to call RespawnPane. The -k flag on respawn-pane handles final cleanup.

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
aleiby
2026-01-25 18:00:49 -08:00
committed by GitHub
parent aca753296b
commit 7926d7b3e8
3 changed files with 211 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
internal/cmd/handoff.go
View File

@@ -5,6 +5,7 @@ import (
"os"
"os/exec"
"path/filepath"
"strconv"
"strings"
"github.com/spf13/cobra"
@@ -211,15 +212,19 @@ func runHandoff(cmd *cobra.Command, args []string) error {
style.PrintWarning("could not set remain-on-exit: %v", err)
}
// NOTE: For self-handoff, we do NOT call KillPaneProcesses here.
// That would kill the gt handoff process itself before it can call RespawnPane,
// leaving the pane dead with no respawn. RespawnPane's -k flag handles killing
// atomically - tmux kills the old process and spawns the new one together.
// See: https://github.com/steveyegge/gastown/issues/859 (pane is dead bug)
// Kill all processes in the pane before respawning to prevent orphan leaks.
// RespawnPane's -k flag only sends SIGHUP which Claude/Node may ignore.
//
// For orphan prevention, we rely on respawn-pane -k which sends SIGHUP/SIGTERM.
// If orphans still occur, the solution is to adjust the restart command to
// kill orphans at startup, not to kill ourselves before respawning.
// IMPORTANT: For self-handoff, we must exclude our own process and parent (Claude Code)
// from being killed. Otherwise gt handoff dies before reaching RespawnPane.
excludePIDs := []string{
strconv.Itoa(os.Getpid()), // gt handoff process
strconv.Itoa(os.Getppid()), // Claude Code (parent)
}
if err := t.KillPaneProcessesExcluding(pane, excludePIDs); err != nil {
// Non-fatal but log the warning
style.PrintWarning("could not kill pane processes: %v", err)
}
// Use respawn-pane -k to atomically kill current process and start new one
// Note: respawn-pane automatically resets remain-on-exit to off