fix: Detect and auto-remove circular redirect files in beads (gt-csbjj)

Added multiple layers of protection against circular redirects:

1. ResolveBeadsDir now detects when a redirect points back to itself
   and auto-removes the errant redirect file with a warning

2. ensureBeadsRedirect now includes safety checks:
   - Prevents creating redirects inside mayor/rig/ (the canonical location)
   - Validates that the redirect target is not the same as the beads dir

3. Added test case for circular redirect detection

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-30 00:46:52 -08:00
parent de32cb0be2
commit a68cf54057
3 changed files with 87 additions and 13 deletions

View File

@@ -966,6 +966,34 @@ func TestResolveBeadsDir(t *testing.T) {
t.Errorf("ResolveBeadsDir() = %q, want %q", got, want)
}
})
t.Run("circular redirect", func(t *testing.T) {
// Redirect that points to itself (e.g., mayor/rig/.beads/redirect -> ../../mayor/rig/.beads)
// This is the bug scenario from gt-csbjj
workDir := filepath.Join(tmpDir, "mayor", "rig")
beadsDir := filepath.Join(workDir, ".beads")
if err := os.MkdirAll(beadsDir, 0755); err != nil {
t.Fatal(err)
}
// Create a circular redirect: ../../mayor/rig/.beads resolves back to .beads
redirectPath := filepath.Join(beadsDir, "redirect")
if err := os.WriteFile(redirectPath, []byte("../../mayor/rig/.beads\n"), 0644); err != nil {
t.Fatal(err)
}
// ResolveBeadsDir should detect the circular redirect and return the original beadsDir
got := ResolveBeadsDir(workDir)
want := beadsDir
if got != want {
t.Errorf("ResolveBeadsDir() = %q, want %q (should ignore circular redirect)", got, want)
}
// The circular redirect file should have been removed
if _, err := os.Stat(redirectPath); err == nil {
t.Error("circular redirect file should have been removed, but it still exists")
}
})
}
func TestParseAgentBeadID(t *testing.T) {