fix: ignore hidden directories when enumerating polecats (#258)

* fix(sling): route bd mol commands to target rig directory

* Fix daemon polecat enumeration to ignore hidden dirs

* Ignore hidden dirs when discovering rig polecats

* Fix CI: enable beads custom types during install

---------

Co-authored-by: joshuavial <git@codewithjv.com>
This commit is contained in:
Joshua Vial
2026-01-08 17:48:09 +13:00
committed by GitHub
parent f9e788ccfb
commit a9ed342be6
8 changed files with 284 additions and 17 deletions

View File

@@ -120,9 +120,14 @@ func (m *Manager) loadRig(name string, entry config.RigEntry) (*Rig, error) {
polecatsDir := filepath.Join(rigPath, "polecats")
if entries, err := os.ReadDir(polecatsDir); err == nil {
for _, e := range entries {
if e.IsDir() {
rig.Polecats = append(rig.Polecats, e.Name())
if !e.IsDir() {
continue
}
name := e.Name()
if strings.HasPrefix(name, ".") {
continue
}
rig.Polecats = append(rig.Polecats, name)
}
}

View File

@@ -3,6 +3,7 @@ package rig
import (
"os"
"path/filepath"
"slices"
"strings"
"testing"
@@ -55,6 +56,10 @@ func createTestRig(t *testing.T, root, name string) {
t.Fatalf("mkdir polecat: %v", err)
}
}
// Create a shared support dir that should not be treated as a polecat worktree.
if err := os.MkdirAll(filepath.Join(polecatsDir, ".claude"), 0755); err != nil {
t.Fatalf("mkdir polecats/.claude: %v", err)
}
}
func TestDiscoverRigs(t *testing.T) {
@@ -84,6 +89,9 @@ func TestDiscoverRigs(t *testing.T) {
if len(rig.Polecats) != 2 {
t.Errorf("Polecats count = %d, want 2", len(rig.Polecats))
}
if slices.Contains(rig.Polecats, ".claude") {
t.Errorf("expected polecats/.claude to be ignored, got %v", rig.Polecats)
}
if !rig.HasWitness {
t.Error("expected HasWitness = true")
}
@@ -430,17 +438,17 @@ func TestIsValidBeadsPrefix(t *testing.T) {
{"a-b-c", true},
// Invalid prefixes
{"", false}, // empty
{"1abc", false}, // starts with number
{"-abc", false}, // starts with hyphen
{"abc def", false}, // contains space
{"abc;ls", false}, // shell injection attempt
{"$(whoami)", false}, // command substitution
{"`id`", false}, // backtick command
{"abc|cat", false}, // pipe
{"../etc/passwd", false}, // path traversal
{"", false}, // empty
{"1abc", false}, // starts with number
{"-abc", false}, // starts with hyphen
{"abc def", false}, // contains space
{"abc;ls", false}, // shell injection attempt
{"$(whoami)", false}, // command substitution
{"`id`", false}, // backtick command
{"abc|cat", false}, // pipe
{"../etc/passwd", false}, // path traversal
{"aaaaaaaaaaaaaaaaaaaaa", false}, // too long (21 chars, >20 limit)
{"valid-but-with-$var", false}, // variable reference
{"valid-but-with-$var", false}, // variable reference
}
for _, tt := range tests {