johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(refinery): pass convoy ID to convoy check command

Browse Source 
The runConvoyCheck function was running `gt convoy check` without
the convoy ID, which checked all open convoys. Now it passes the
specific convoy ID to check only the relevant convoy, as specified
in the requirements.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
nux
2026-01-20 23:17:16 -08:00
committed by beads/crew/emma
parent 35abe21c50
commit b14835b140
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/convoy/observer.go
View File

@@ -46,7 +46,7 @@ func CheckConvoysForIssue(townRoot, issueID, observer string, logger func(format
} }
logger("%s: running convoy check for %s", observer, convoyID) logger("%s: running convoy check for %s", observer, convoyID)
if err := runConvoyCheck(townRoot); err != nil { if err := runConvoyCheck(townRoot, convoyID); err != nil {
logger("%s: convoy check failed: %v", observer, err) logger("%s: convoy check failed: %v", observer, err)
} }
} }
@@ -120,10 +120,10 @@ func isConvoyClosed(townRoot, convoyID string) bool {
return results[0].Status == "closed" return results[0].Status == "closed"
} }
// runConvoyCheck runs `gt convoy check` to close any completed convoys. // runConvoyCheck runs `gt convoy check <convoy-id>` to check a specific convoy.
// This is idempotent and handles already-closed convoys gracefully. // This is idempotent and handles already-closed convoys gracefully.
func runConvoyCheck(townRoot string) error { func runConvoyCheck(townRoot, convoyID string) error {
cmd := exec.Command("gt", "convoy", "check") cmd := exec.Command("gt", "convoy", "check", convoyID)
cmd.Dir = townRoot cmd.Dir = townRoot
var stderr bytes.Buffer var stderr bytes.Buffer
cmd.Stderr = &stderr cmd.Stderr = &stderr