From b79e4a7c3b834c0563cd7cf4914e982559406b64 Mon Sep 17 00:00:00 2001 From: gastown/crew/jack Date: Tue, 6 Jan 2026 13:09:15 -0800 Subject: [PATCH] fix: remove BranchPushedToRemote checks from gt done and mq submit (gt-dymy5) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Phase 1 of local-only polecat branches. Removes push verification checks since polecats will no longer push branches to remote. - done.go: Remove push check, keep existing CommitsAhead validation - mq_submit.go: Remove push check entirely 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- internal/cmd/done.go | 11 ----------- internal/cmd/mq_submit.go | 11 ----------- 2 files changed, 22 deletions(-) diff --git a/internal/cmd/done.go b/internal/cmd/done.go index 106cce4b..672c79d6 100644 --- a/internal/cmd/done.go +++ b/internal/cmd/done.go @@ -162,17 +162,6 @@ func runDone(cmd *cobra.Command, args []string) error { if branch == defaultBranch || branch == "master" { return fmt.Errorf("cannot submit %s/master branch to merge queue", defaultBranch) } - - // Check for unpushed commits - branch must be pushed before MR creation - // Use BranchPushedToRemote which handles polecat branches without upstream tracking - pushed, unpushedCount, err := g.BranchPushedToRemote(branch, "origin") - if err != nil { - return fmt.Errorf("checking if branch is pushed: %w", err) - } - if !pushed { - return fmt.Errorf("branch has %d unpushed commit(s); run 'git push -u origin %s' first", unpushedCount, branch) - } - // Check that branch has commits ahead of default branch (prevents submitting stale branches) aheadCount, err := g.CommitsAhead(defaultBranch, branch) if err != nil { diff --git a/internal/cmd/mq_submit.go b/internal/cmd/mq_submit.go index 0e46dff0..f453dc3d 100644 --- a/internal/cmd/mq_submit.go +++ b/internal/cmd/mq_submit.go @@ -90,17 +90,6 @@ func runMqSubmit(cmd *cobra.Command, args []string) error { return fmt.Errorf("cannot submit %s/master branch to merge queue", defaultBranch) } - // CRITICAL: Verify branch is pushed before creating MR bead - // This prevents work loss when MR is created but commits aren't on remote. - // See: gt-2hwi9 (Polecats not pushing before signaling done) - pushed, unpushedCount, err := g.BranchPushedToRemote(branch, "origin") - if err != nil { - return fmt.Errorf("checking if branch is pushed: %w", err) - } - if !pushed { - return fmt.Errorf("branch has %d unpushed commit(s); run 'git push -u origin %s' first", unpushedCount, branch) - } - // Parse branch info info := parseBranchName(branch)