From b9e8be43524ca306de34c604b3fba899163bb5da Mon Sep 17 00:00:00 2001 From: gastown/crew/dennis Date: Sun, 11 Jan 2026 18:06:09 -0800 Subject: [PATCH] fix(lint): resolve errcheck and unparam violations Fixes CI lint failures by handling unchecked error returns and marking unused parameters with blank identifiers. Co-Authored-By: Claude Opus 4.5 --- internal/cmd/down.go | 2 +- internal/cmd/install.go | 2 +- internal/cmd/root.go | 4 ++-- internal/doctor/priming_check.go | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/cmd/down.go b/internal/cmd/down.go index 19d7da36..0d9a2653 100644 --- a/internal/cmd/down.go +++ b/internal/cmd/down.go @@ -95,7 +95,7 @@ func runDown(cmd *cobra.Command, args []string) error { if err != nil { return fmt.Errorf("cannot proceed: %w", err) } - defer lock.Unlock() + defer func() { _ = lock.Unlock() }() } allOK := true diff --git a/internal/cmd/install.go b/internal/cmd/install.go index 036777a9..00115c07 100644 --- a/internal/cmd/install.go +++ b/internal/cmd/install.go @@ -308,7 +308,7 @@ func runInstall(cmd *cobra.Command, args []string) error { return nil } -func createMayorCLAUDEmd(mayorDir, townRoot string) error { +func createMayorCLAUDEmd(mayorDir, _ string) error { // Create a minimal bootstrap pointer instead of full context. // Full context is injected ephemerally by `gt prime` at session start. // This keeps the on-disk file small (<30 lines) per priming architecture. diff --git a/internal/cmd/root.go b/internal/cmd/root.go index fd7dbd34..35195465 100644 --- a/internal/cmd/root.go +++ b/internal/cmd/root.go @@ -100,7 +100,7 @@ func warnIfTownRootOffMain() { // checkBeadsDependency verifies beads meets minimum version requirements. // Skips check for exempt commands (version, help, completion). // Deprecated: Use persistentPreRun instead, which calls CheckBeadsVersion. -func checkBeadsDependency(cmd *cobra.Command, args []string) error { +func checkBeadsDependency(cmd *cobra.Command, _ []string) error { // Get the root command name being run cmdName := cmd.Name() @@ -142,7 +142,7 @@ func checkStaleBinaryWarning() { if info.IsStale { staleBinaryWarned = true - os.Setenv("GT_STALE_WARNED", "1") + _ = os.Setenv("GT_STALE_WARNED", "1") msg := fmt.Sprintf("gt binary is stale (built from %s, repo at %s)", version.ShortCommit(info.BinaryCommit), version.ShortCommit(info.RepoCommit)) diff --git a/internal/doctor/priming_check.go b/internal/doctor/priming_check.go index df318e51..a97327b1 100644 --- a/internal/doctor/priming_check.go +++ b/internal/doctor/priming_check.go @@ -111,7 +111,7 @@ func (c *PrimingCheck) Run(ctx *CheckContext) *CheckResult { } // checkAgentPriming checks priming configuration for a specific agent. -func (c *PrimingCheck) checkAgentPriming(townRoot, agentDir, agentType string) []primingIssue { +func (c *PrimingCheck) checkAgentPriming(townRoot, agentDir, _ string) []primingIssue { var issues []primingIssue agentPath := filepath.Join(townRoot, agentDir)