feat(version): add stale binary detection with startup warning
Add detection for when the installed gt binary is out of date with the source repository. This helps catch issues where commands fail mysteriously because the installed binary doesn't have recent fixes. Changes: - Add internal/version package with stale binary detection logic - Add startup warning in PersistentPreRunE when binary is stale - Add gt doctor check for stale-binary - Use prefix matching for commit comparison (handles short vs full hash) The warning is non-blocking and only shows once per shell session via the GT_STALE_WARNED environment variable. Resolves: gt-ud912 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -7,6 +7,7 @@ import (
|
||||
"strings"
|
||||
|
||||
"github.com/spf13/cobra"
|
||||
"github.com/steveyegge/gastown/internal/version"
|
||||
)
|
||||
|
||||
// Version information - set at build time via ldflags
|
||||
@@ -28,9 +29,9 @@ var versionCmd = &cobra.Command{
|
||||
branch := resolveBranch()
|
||||
|
||||
if commit != "" && branch != "" {
|
||||
fmt.Printf("gt version %s (%s: %s@%s)\n", Version, Build, branch, shortCommit(commit))
|
||||
fmt.Printf("gt version %s (%s: %s@%s)\n", Version, Build, branch, version.ShortCommit(commit))
|
||||
} else if commit != "" {
|
||||
fmt.Printf("gt version %s (%s: %s)\n", Version, Build, shortCommit(commit))
|
||||
fmt.Printf("gt version %s (%s: %s)\n", Version, Build, version.ShortCommit(commit))
|
||||
} else {
|
||||
fmt.Printf("gt version %s (%s)\n", Version, Build)
|
||||
}
|
||||
@@ -39,6 +40,11 @@ var versionCmd = &cobra.Command{
|
||||
|
||||
func init() {
|
||||
rootCmd.AddCommand(versionCmd)
|
||||
|
||||
// Pass the build-time commit to the version package for stale binary checks
|
||||
if Commit != "" {
|
||||
version.SetCommit(Commit)
|
||||
}
|
||||
}
|
||||
|
||||
func resolveCommitHash() string {
|
||||
@@ -57,13 +63,6 @@ func resolveCommitHash() string {
|
||||
return ""
|
||||
}
|
||||
|
||||
func shortCommit(hash string) string {
|
||||
if len(hash) > 12 {
|
||||
return hash[:12]
|
||||
}
|
||||
return hash
|
||||
}
|
||||
|
||||
func resolveBranch() string {
|
||||
if Branch != "" {
|
||||
return Branch
|
||||
|
||||
Reference in New Issue
Block a user