johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: align assigneeID format with hooked issue format (#946)

Browse Source 
The polecat manager was using rig/name format while sling sets
rig/polecats/name. This caused gt polecat status to show 'done'
for working polecats because GetAssignedIssue couldn't find them.

Fixes gt-oohy
This commit is contained in:
Artem Bambalov
2026-01-26 04:05:44 +02:00
committed by GitHub
parent 6d18e0a88b
commit c94a2301eb
3 changed files with 57 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/beads/beads.go
View File

@@ -327,7 +327,7 @@ func (b *Beads) List(opts ListOptions) ([]*Issue, error) {
} }
// ListByAssignee returns all issues assigned to a specific assignee. // ListByAssignee returns all issues assigned to a specific assignee.
// The assignee is typically in the format "rig/polecatName" (e.g., "gastown/Toast"). // The assignee is typically in the format "rig/polecats/polecatName" (e.g., "gastown/polecats/Toast").
func (b *Beads) ListByAssignee(assignee string) ([]*Issue, error) { func (b *Beads) ListByAssignee(assignee string) ([]*Issue, error) {
return b.List(ListOptions{ return b.List(ListOptions{
Status: "all", // Include both open and closed for state derivation Status: "all", // Include both open and closed for state derivation

4
internal/polecat/manager.go
View File

@@ -90,9 +90,9 @@ func NewManager(r *rig.Rig, g *git.Git, t *tmux.Tmux) *Manager {
} }
// assigneeID returns the beads assignee identifier for a polecat. // assigneeID returns the beads assignee identifier for a polecat.
// Format: "rig/polecatName" (e.g., "gastown/Toast") // Format: "rig/polecats/polecatName" (e.g., "gastown/polecats/Toast")
func (m *Manager) assigneeID(name string) string { func (m *Manager) assigneeID(name string) string {
return fmt.Sprintf("%s/%s", m.rig.Name, name) return fmt.Sprintf("%s/polecats/%s", m.rig.Name, name)
} }
// agentBeadID returns the agent bead ID for a polecat. // agentBeadID returns the agent bead ID for a polecat.

4
internal/polecat/manager_test.go
View File

@@ -135,7 +135,7 @@ func TestAssigneeID(t *testing.T) {
m := NewManager(r, git.NewGit(r.Path), nil) m := NewManager(r, git.NewGit(r.Path), nil)
id := m.assigneeID("Toast") id := m.assigneeID("Toast")
expected := "test-rig/Toast" expected := "test-rig/polecats/Toast"
if id != expected { if id != expected {
t.Errorf("assigneeID = %q, want %q", id, expected) t.Errorf("assigneeID = %q, want %q", id, expected)
} }
@@ -446,10 +446,12 @@ func TestAddWithOptions_AgentsMDFallback(t *testing.T) {
t.Errorf("AGENTS.md content = %q, want %q", gotContent, wantContent) t.Errorf("AGENTS.md content = %q, want %q", gotContent, wantContent)
} }
} }
// TestReconcilePoolWith tests all permutations of directory and session existence. // TestReconcilePoolWith tests all permutations of directory and session existence.
// This is the core allocation policy logic. // This is the core allocation policy logic.
// //
// Truth table: // Truth table:
//
// HasDir | HasSession | Result // HasDir | HasSession | Result
// -------|------------|------------------ // -------|------------|------------------
// false | false | available (not in-use) // false | false | available (not in-use)