feat(config): Add multi-agent support with pluggable registry
Implements agent abstraction layer to support multiple AI coding agents. Built-in presets (E2E tested): - Claude Code (default) - Gemini CLI - OpenAI Codex Key changes: - Add AgentRegistry with built-in presets and custom agent support - Add TownSettings with default_agent and custom agents map - Add Agent field to RigSettings for per-rig agent selection - Update ResolveAgentConfig for hierarchical config resolution - Update spawn paths to use configured agent instead of hardcoded claude Configuration hierarchy (first match wins): 1. Rig's Runtime config (backwards compat) 2. Rig's Agent -> custom agents -> built-in presets 3. Town's default_agent setting 4. Fallback to Claude Additional agents (aider, opencode, etc.) can be added via config file: settings/agents.json Addresses Issue #10: Agent Agnostic Engine with Multi-provider support 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
mayor
217
internal/config/agents_test.go
Normal file
217
internal/config/agents_test.go
Normal file
@@ -0,0 +1,217 @@
|
||||
package config
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestBuiltinPresets(t *testing.T) {
|
||||
// Ensure all built-in presets are accessible (E2E tested agents only)
|
||||
presets := []AgentPreset{AgentClaude, AgentGemini, AgentCodex}
|
||||
|
||||
for _, preset := range presets {
|
||||
info := GetAgentPreset(preset)
|
||||
if info == nil {
|
||||
t.Errorf("GetAgentPreset(%s) returned nil", preset)
|
||||
continue
|
||||
}
|
||||
|
||||
if info.Command == "" {
|
||||
t.Errorf("preset %s has empty Command", preset)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestGetAgentPresetByName(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
want AgentPreset
|
||||
wantNil bool
|
||||
}{
|
||||
{"claude", AgentClaude, false},
|
||||
{"gemini", AgentGemini, false},
|
||||
{"codex", AgentCodex, false},
|
||||
{"aider", "", true}, // Not built-in, can be added via config
|
||||
{"opencode", "", true}, // Not built-in, can be added via config
|
||||
{"unknown", "", true},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
got := GetAgentPresetByName(tt.name)
|
||||
if tt.wantNil && got != nil {
|
||||
t.Errorf("GetAgentPresetByName(%s) = %v, want nil", tt.name, got)
|
||||
}
|
||||
if !tt.wantNil && got == nil {
|
||||
t.Errorf("GetAgentPresetByName(%s) = nil, want preset", tt.name)
|
||||
}
|
||||
if !tt.wantNil && got != nil && got.Name != tt.want {
|
||||
t.Errorf("GetAgentPresetByName(%s).Name = %v, want %v", tt.name, got.Name, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestRuntimeConfigFromPreset(t *testing.T) {
|
||||
tests := []struct {
|
||||
preset AgentPreset
|
||||
wantCommand string
|
||||
}{
|
||||
{AgentClaude, "claude"},
|
||||
{AgentGemini, "gemini"},
|
||||
{AgentCodex, "codex"},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(string(tt.preset), func(t *testing.T) {
|
||||
rc := RuntimeConfigFromPreset(tt.preset)
|
||||
if rc.Command != tt.wantCommand {
|
||||
t.Errorf("RuntimeConfigFromPreset(%s).Command = %v, want %v",
|
||||
tt.preset, rc.Command, tt.wantCommand)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestIsKnownPreset(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
want bool
|
||||
}{
|
||||
{"claude", true},
|
||||
{"gemini", true},
|
||||
{"codex", true},
|
||||
{"aider", false}, // Not built-in, can be added via config
|
||||
{"opencode", false}, // Not built-in, can be added via config
|
||||
{"unknown", false},
|
||||
{"chatgpt", false},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if got := IsKnownPreset(tt.name); got != tt.want {
|
||||
t.Errorf("IsKnownPreset(%s) = %v, want %v", tt.name, got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestLoadAgentRegistry(t *testing.T) {
|
||||
// Create temp directory for test config
|
||||
tmpDir := t.TempDir()
|
||||
configPath := filepath.Join(tmpDir, "agents.json")
|
||||
|
||||
// Write custom agent config
|
||||
customRegistry := AgentRegistry{
|
||||
Version: CurrentAgentRegistryVersion,
|
||||
Agents: map[string]*AgentPresetInfo{
|
||||
"my-agent": {
|
||||
Name: "my-agent",
|
||||
Command: "my-agent-bin",
|
||||
Args: []string{"--auto"},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
data, err := json.Marshal(customRegistry)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to marshal test config: %v", err)
|
||||
}
|
||||
|
||||
if err := os.WriteFile(configPath, data, 0644); err != nil {
|
||||
t.Fatalf("failed to write test config: %v", err)
|
||||
}
|
||||
|
||||
// Reset global registry for test
|
||||
globalRegistry = nil
|
||||
|
||||
// Load the custom registry
|
||||
if err := LoadAgentRegistry(configPath); err != nil {
|
||||
t.Fatalf("LoadAgentRegistry failed: %v", err)
|
||||
}
|
||||
|
||||
// Check custom agent is available
|
||||
myAgent := GetAgentPresetByName("my-agent")
|
||||
if myAgent == nil {
|
||||
t.Fatal("custom agent 'my-agent' not found after loading registry")
|
||||
}
|
||||
if myAgent.Command != "my-agent-bin" {
|
||||
t.Errorf("my-agent.Command = %v, want my-agent-bin", myAgent.Command)
|
||||
}
|
||||
|
||||
// Check built-ins still accessible
|
||||
claude := GetAgentPresetByName("claude")
|
||||
if claude == nil {
|
||||
t.Fatal("built-in 'claude' not found after loading registry")
|
||||
}
|
||||
|
||||
// Reset for other tests
|
||||
globalRegistry = nil
|
||||
}
|
||||
|
||||
func TestAgentPresetYOLOFlags(t *testing.T) {
|
||||
// Verify YOLO flags are set correctly for each E2E tested agent
|
||||
tests := []struct {
|
||||
preset AgentPreset
|
||||
wantArg string // At least this arg should be present
|
||||
}{
|
||||
{AgentClaude, "--dangerously-skip-permissions"},
|
||||
{AgentGemini, "yolo"}, // Part of "--approval-mode yolo"
|
||||
{AgentCodex, "--yolo"},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(string(tt.preset), func(t *testing.T) {
|
||||
info := GetAgentPreset(tt.preset)
|
||||
if info == nil {
|
||||
t.Fatalf("preset %s not found", tt.preset)
|
||||
}
|
||||
|
||||
found := false
|
||||
for _, arg := range info.Args {
|
||||
if arg == tt.wantArg || (tt.preset == AgentGemini && arg == "yolo") {
|
||||
found = true
|
||||
break
|
||||
}
|
||||
}
|
||||
if !found {
|
||||
t.Errorf("preset %s args %v missing expected %s", tt.preset, info.Args, tt.wantArg)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestMergeWithPreset(t *testing.T) {
|
||||
// Test that user config overrides preset defaults
|
||||
userConfig := &RuntimeConfig{
|
||||
Command: "/custom/claude",
|
||||
Args: []string{"--custom-arg"},
|
||||
}
|
||||
|
||||
merged := userConfig.MergeWithPreset(AgentClaude)
|
||||
|
||||
if merged.Command != "/custom/claude" {
|
||||
t.Errorf("merged command should be user value, got %s", merged.Command)
|
||||
}
|
||||
if len(merged.Args) != 1 || merged.Args[0] != "--custom-arg" {
|
||||
t.Errorf("merged args should be user value, got %v", merged.Args)
|
||||
}
|
||||
|
||||
// Test nil config gets preset defaults
|
||||
var nilConfig *RuntimeConfig
|
||||
merged = nilConfig.MergeWithPreset(AgentClaude)
|
||||
|
||||
if merged.Command != "claude" {
|
||||
t.Errorf("nil config merge should get preset command, got %s", merged.Command)
|
||||
}
|
||||
|
||||
// Test empty config gets preset defaults
|
||||
emptyConfig := &RuntimeConfig{}
|
||||
merged = emptyConfig.MergeWithPreset(AgentGemini)
|
||||
|
||||
if merged.Command != "gemini" {
|
||||
t.Errorf("empty config merge should get preset command, got %s", merged.Command)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user