Add AgentIdentity type for session name parsing (gt-ov2uv)
Create AgentIdentity type to parse and construct session names, replacing duplicated logic in sling.go and handoff.go. - Add internal/session/identity.go with AgentIdentity type - ParseSessionName handles: mayor, deacon, witness, refinery, crew, polecat - SessionName() reconstructs valid tmux session name - Address() returns mail-style address (e.g., "gastown/crew/max") - GTRole() returns GT_ROLE env var format - Update sling.go:sessionToAgentID to use ParseSessionName - Update handoff.go:sessionToGTRole to use ParseSessionName - Add comprehensive unit tests with round-trip verification 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
252
internal/session/identity_test.go
Normal file
252
internal/session/identity_test.go
Normal file
@@ -0,0 +1,252 @@
|
||||
package session
|
||||
|
||||
import (
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestParseSessionName(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
session string
|
||||
wantRole Role
|
||||
wantRig string
|
||||
wantName string
|
||||
wantErr bool
|
||||
}{
|
||||
// Global roles (no rig)
|
||||
{
|
||||
name: "mayor",
|
||||
session: "gt-mayor",
|
||||
wantRole: RoleMayor,
|
||||
},
|
||||
{
|
||||
name: "deacon",
|
||||
session: "gt-deacon",
|
||||
wantRole: RoleDeacon,
|
||||
},
|
||||
|
||||
// Witness (simple rig)
|
||||
{
|
||||
name: "witness simple rig",
|
||||
session: "gt-gastown-witness",
|
||||
wantRole: RoleWitness,
|
||||
wantRig: "gastown",
|
||||
},
|
||||
{
|
||||
name: "witness hyphenated rig",
|
||||
session: "gt-foo-bar-witness",
|
||||
wantRole: RoleWitness,
|
||||
wantRig: "foo-bar",
|
||||
},
|
||||
|
||||
// Refinery (simple rig)
|
||||
{
|
||||
name: "refinery simple rig",
|
||||
session: "gt-gastown-refinery",
|
||||
wantRole: RoleRefinery,
|
||||
wantRig: "gastown",
|
||||
},
|
||||
{
|
||||
name: "refinery hyphenated rig",
|
||||
session: "gt-my-project-refinery",
|
||||
wantRole: RoleRefinery,
|
||||
wantRig: "my-project",
|
||||
},
|
||||
|
||||
// Crew (with marker)
|
||||
{
|
||||
name: "crew simple",
|
||||
session: "gt-gastown-crew-max",
|
||||
wantRole: RoleCrew,
|
||||
wantRig: "gastown",
|
||||
wantName: "max",
|
||||
},
|
||||
{
|
||||
name: "crew hyphenated rig",
|
||||
session: "gt-foo-bar-crew-alice",
|
||||
wantRole: RoleCrew,
|
||||
wantRig: "foo-bar",
|
||||
wantName: "alice",
|
||||
},
|
||||
{
|
||||
name: "crew hyphenated name",
|
||||
session: "gt-gastown-crew-my-worker",
|
||||
wantRole: RoleCrew,
|
||||
wantRig: "gastown",
|
||||
wantName: "my-worker",
|
||||
},
|
||||
|
||||
// Polecat (fallback)
|
||||
{
|
||||
name: "polecat simple",
|
||||
session: "gt-gastown-morsov",
|
||||
wantRole: RolePolecat,
|
||||
wantRig: "gastown",
|
||||
wantName: "morsov",
|
||||
},
|
||||
{
|
||||
name: "polecat hyphenated rig",
|
||||
session: "gt-foo-bar-Toast",
|
||||
wantRole: RolePolecat,
|
||||
wantRig: "foo-bar",
|
||||
wantName: "Toast",
|
||||
},
|
||||
|
||||
// Error cases
|
||||
{
|
||||
name: "missing prefix",
|
||||
session: "gastown-witness",
|
||||
wantErr: true,
|
||||
},
|
||||
{
|
||||
name: "empty after prefix",
|
||||
session: "gt-",
|
||||
wantErr: true,
|
||||
},
|
||||
{
|
||||
name: "just prefix",
|
||||
session: "gt-x",
|
||||
wantErr: true,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
got, err := ParseSessionName(tt.session)
|
||||
if (err != nil) != tt.wantErr {
|
||||
t.Errorf("ParseSessionName(%q) error = %v, wantErr %v", tt.session, err, tt.wantErr)
|
||||
return
|
||||
}
|
||||
if err != nil {
|
||||
return
|
||||
}
|
||||
if got.Role != tt.wantRole {
|
||||
t.Errorf("ParseSessionName(%q).Role = %v, want %v", tt.session, got.Role, tt.wantRole)
|
||||
}
|
||||
if got.Rig != tt.wantRig {
|
||||
t.Errorf("ParseSessionName(%q).Rig = %v, want %v", tt.session, got.Rig, tt.wantRig)
|
||||
}
|
||||
if got.Name != tt.wantName {
|
||||
t.Errorf("ParseSessionName(%q).Name = %v, want %v", tt.session, got.Name, tt.wantName)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestAgentIdentity_SessionName(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
identity AgentIdentity
|
||||
want string
|
||||
}{
|
||||
{
|
||||
name: "mayor",
|
||||
identity: AgentIdentity{Role: RoleMayor},
|
||||
want: "gt-mayor",
|
||||
},
|
||||
{
|
||||
name: "deacon",
|
||||
identity: AgentIdentity{Role: RoleDeacon},
|
||||
want: "gt-deacon",
|
||||
},
|
||||
{
|
||||
name: "witness",
|
||||
identity: AgentIdentity{Role: RoleWitness, Rig: "gastown"},
|
||||
want: "gt-gastown-witness",
|
||||
},
|
||||
{
|
||||
name: "refinery",
|
||||
identity: AgentIdentity{Role: RoleRefinery, Rig: "my-project"},
|
||||
want: "gt-my-project-refinery",
|
||||
},
|
||||
{
|
||||
name: "crew",
|
||||
identity: AgentIdentity{Role: RoleCrew, Rig: "gastown", Name: "max"},
|
||||
want: "gt-gastown-crew-max",
|
||||
},
|
||||
{
|
||||
name: "polecat",
|
||||
identity: AgentIdentity{Role: RolePolecat, Rig: "gastown", Name: "morsov"},
|
||||
want: "gt-gastown-morsov",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if got := tt.identity.SessionName(); got != tt.want {
|
||||
t.Errorf("AgentIdentity.SessionName() = %v, want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestAgentIdentity_Address(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
identity AgentIdentity
|
||||
want string
|
||||
}{
|
||||
{
|
||||
name: "mayor",
|
||||
identity: AgentIdentity{Role: RoleMayor},
|
||||
want: "mayor",
|
||||
},
|
||||
{
|
||||
name: "deacon",
|
||||
identity: AgentIdentity{Role: RoleDeacon},
|
||||
want: "deacon",
|
||||
},
|
||||
{
|
||||
name: "witness",
|
||||
identity: AgentIdentity{Role: RoleWitness, Rig: "gastown"},
|
||||
want: "gastown/witness",
|
||||
},
|
||||
{
|
||||
name: "refinery",
|
||||
identity: AgentIdentity{Role: RoleRefinery, Rig: "my-project"},
|
||||
want: "my-project/refinery",
|
||||
},
|
||||
{
|
||||
name: "crew",
|
||||
identity: AgentIdentity{Role: RoleCrew, Rig: "gastown", Name: "max"},
|
||||
want: "gastown/crew/max",
|
||||
},
|
||||
{
|
||||
name: "polecat",
|
||||
identity: AgentIdentity{Role: RolePolecat, Rig: "gastown", Name: "Toast"},
|
||||
want: "gastown/polecats/Toast",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if got := tt.identity.Address(); got != tt.want {
|
||||
t.Errorf("AgentIdentity.Address() = %v, want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestParseSessionName_RoundTrip(t *testing.T) {
|
||||
// Test that parsing then reconstructing gives the same result
|
||||
sessions := []string{
|
||||
"gt-mayor",
|
||||
"gt-deacon",
|
||||
"gt-gastown-witness",
|
||||
"gt-foo-bar-refinery",
|
||||
"gt-gastown-crew-max",
|
||||
"gt-gastown-morsov",
|
||||
}
|
||||
|
||||
for _, session := range sessions {
|
||||
t.Run(session, func(t *testing.T) {
|
||||
identity, err := ParseSessionName(session)
|
||||
if err != nil {
|
||||
t.Fatalf("ParseSessionName(%q) error = %v", session, err)
|
||||
}
|
||||
if got := identity.SessionName(); got != session {
|
||||
t.Errorf("Round-trip failed: ParseSessionName(%q).SessionName() = %q", session, got)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user