fix: use tmux for agent liveness in daemon checks (gt-zecmc)

Complete the "discover, don't track" refactoring:

- checkGUPPViolations: use tmux.IsClaudeRunning() instead of agent_state
- checkOrphanedWork: derive dead agents from tmux, not agent_state=dead
- assessStaleness: rely on HasActiveSession (tmux), not agent_state

Non-observable states (stuck, awaiting-gate) are still respected.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
gastown/crew/joe
2026-01-06 20:49:49 -08:00
committed by Steve Yegge
parent 9729e05f86
commit fc4b9de02c
2 changed files with 57 additions and 61 deletions

View File

@@ -866,40 +866,39 @@ func countCommitsBehind(g *git.Git, defaultBranch string) int {
}
// assessStaleness determines if a polecat should be cleaned up.
// Per gt-zecmc: uses tmux state (HasActiveSession) rather than agent_state
// since observable states (running, done, idle) are no longer recorded in beads.
func assessStaleness(info *StalenessInfo, threshold int) (bool, string) {
// Never clean up if there's uncommitted work
if info.HasUncommittedWork {
return false, "has uncommitted work"
}
// If session is active, not stale
// If session is active, not stale (tmux is source of truth for liveness)
if info.HasActiveSession {
return false, "session active"
}
// No active session - check other indicators
// No active session - this polecat is a cleanup candidate
// Check for reasons to keep it:
// If agent reports "running" state but no session, that's suspicious
// but give benefit of doubt (session may have just died)
if info.AgentState == "running" {
return false, "agent reports running (session may be restarting)"
// Check for non-observable states that indicate intentional pause
// (stuck, awaiting-gate are still stored in beads per gt-zecmc)
if info.AgentState == "stuck" || info.AgentState == "awaiting-gate" {
return false, fmt.Sprintf("agent_state=%s (intentional pause)", info.AgentState)
}
// If agent reports "done" or "idle", it's a cleanup candidate
if info.AgentState == "done" || info.AgentState == "idle" {
return true, fmt.Sprintf("agent_state=%s, no active session", info.AgentState)
}
// Way behind main is a strong staleness signal
// No session and way behind main = stale
if info.CommitsBehind >= threshold {
return true, fmt.Sprintf("%d commits behind main, no active session", info.CommitsBehind)
}
// No agent bead and no session - likely abandoned
// No session and no agent bead = abandoned, clean up
if info.AgentState == "" {
return true, "no agent bead, no active session"
}
// Default: not enough evidence to consider stale
return false, "insufficient staleness indicators"
// No session but has agent bead without special state = clean up
// (The session is the source of truth for liveness)
return true, "no active session"
}