johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(plugin): don't record false success for manual plugin runs #4

Open
johno wants to merge 5 commits from dog/charlie-gastown-1769245500525 into main
pull from: dog/charlie-gastown-1769245500525
merge into: johno:main
Conversation 0 Commits 5 Files Changed 7 +48 -61
johno commented 2026-01-24 01:21:46 -08:00
Owner
Copy Link

Summary

gt plugin run was recording ResultSuccess even though it only prints instructions without actually executing them. This poisoned the cooldown gate, blocking actual plugin executions for 24h while no real work was done.

Root cause: When someone runs gt plugin run gitea-reconcile, it:

  1. Prints the plugin instructions to stdout
  2. Records a "success" bead even though nothing was executed
  3. The cooldown gate then blocks future runs for 24h

Fix:

  • Record manual runs as ResultSkipped instead of ResultSuccess
  • Add CountSuccessfulRunsSince() to only count successful runs for gate evaluation
  • Gate check now uses CountSuccessfulRunsSince() so skipped/failed runs don't block future executions

Fixes: hq-2dis4c

## Summary `gt plugin run` was recording `ResultSuccess` even though it only prints instructions without actually executing them. This poisoned the cooldown gate, blocking actual plugin executions for 24h while no real work was done. **Root cause**: When someone runs `gt plugin run gitea-reconcile`, it: 1. Prints the plugin instructions to stdout 2. Records a "success" bead even though nothing was executed 3. The cooldown gate then blocks future runs for 24h **Fix**: - Record manual runs as `ResultSkipped` instead of `ResultSuccess` - Add `CountSuccessfulRunsSince()` to only count successful runs for gate evaluation - Gate check now uses `CountSuccessfulRunsSince()` so skipped/failed runs don't block future executions Fixes: hq-2dis4c
johno added 1 commit 2026-01-24 01:21:46 -08:00
fix(plugin): don't record false success for manual plugin runs
Some checks failed
CI / Check for .beads changes (pull_request) Successful in 9s
Details
CI / Check embedded formulas (pull_request) Successful in 32s
Details
CI / Test (pull_request) Failing after 1m47s
Details
CI / Lint (pull_request) Failing after 22s
Details
CI / Integration Tests (pull_request) Successful in 1m35s
Details
CI / Coverage Report (pull_request) Has been skipped
Details
Windows CI / Windows Build and Unit Tests (pull_request) Has been cancelled
Details
612c59629f 
`gt plugin run` was recording ResultSuccess even though it only prints
instructions without executing them. This poisoned the cooldown gate,
blocking actual executions for 24h.

Changes:
- Record manual runs as ResultSkipped instead of ResultSuccess
- Add CountSuccessfulRunsSince() to only count successful runs for gate
- Gate check now uses CountSuccessfulRunsSince() so skipped/failed runs
  don't block future executions

Fixes: hq-2dis4c

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Some checks failed
CI / Check for .beads changes (pull_request) Successful in 9s
Details
CI / Check embedded formulas (pull_request) Successful in 32s
Details
CI / Test (pull_request) Failing after 1m47s
Details
CI / Lint (pull_request) Failing after 22s
Details
CI / Integration Tests (pull_request) Successful in 1m35s
Details
CI / Coverage Report (pull_request) Has been skipped
Details
Windows CI / Windows Build and Unit Tests (pull_request) Has been cancelled
Details
This pull request has changes conflicting with the target branch.
  • internal/cmd/plugin.go
  • internal/config/env.go
  • internal/config/env_test.go
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dog/charlie-gastown-1769245500525:dog/charlie-gastown-1769245500525
git checkout dog/charlie-gastown-1769245500525
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johno-square johno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: johno/gastown#4
Delete Branch "dog/charlie-gastown-1769245500525"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?