package config import ( "os" "path/filepath" "strings" "testing" "time" ) func TestTownConfigRoundTrip(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "mayor", "town.json") original := &TownConfig{ Type: "town", Version: 1, Name: "test-town", CreatedAt: time.Now().Truncate(time.Second), } if err := SaveTownConfig(path, original); err != nil { t.Fatalf("SaveTownConfig: %v", err) } loaded, err := LoadTownConfig(path) if err != nil { t.Fatalf("LoadTownConfig: %v", err) } if loaded.Name != original.Name { t.Errorf("Name = %q, want %q", loaded.Name, original.Name) } if loaded.Type != original.Type { t.Errorf("Type = %q, want %q", loaded.Type, original.Type) } } func TestRigsConfigRoundTrip(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "mayor", "rigs.json") original := &RigsConfig{ Version: 1, Rigs: map[string]RigEntry{ "gastown": { GitURL: "git@github.com:steveyegge/gastown.git", LocalRepo: "/tmp/local-repo", AddedAt: time.Now().Truncate(time.Second), BeadsConfig: &BeadsConfig{ Repo: "local", Prefix: "gt-", }, }, }, } if err := SaveRigsConfig(path, original); err != nil { t.Fatalf("SaveRigsConfig: %v", err) } loaded, err := LoadRigsConfig(path) if err != nil { t.Fatalf("LoadRigsConfig: %v", err) } if len(loaded.Rigs) != 1 { t.Errorf("Rigs count = %d, want 1", len(loaded.Rigs)) } rig, ok := loaded.Rigs["gastown"] if !ok { t.Fatal("missing 'gastown' rig") } if rig.BeadsConfig == nil || rig.BeadsConfig.Prefix != "gt-" { t.Errorf("BeadsConfig.Prefix = %v, want 'gt-'", rig.BeadsConfig) } if rig.LocalRepo != "/tmp/local-repo" { t.Errorf("LocalRepo = %q, want %q", rig.LocalRepo, "/tmp/local-repo") } } func TestLoadTownConfigNotFound(t *testing.T) { _, err := LoadTownConfig("/nonexistent/path.json") if err == nil { t.Fatal("expected error for nonexistent file") } } func TestValidationErrors(t *testing.T) { // Missing name tc := &TownConfig{Type: "town", Version: 1} if err := validateTownConfig(tc); err == nil { t.Error("expected error for missing name") } // Wrong type tc = &TownConfig{Type: "wrong", Version: 1, Name: "test"} if err := validateTownConfig(tc); err == nil { t.Error("expected error for wrong type") } } func TestRigConfigRoundTrip(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "config.json") original := NewRigConfig("gastown", "git@github.com:test/gastown.git") original.CreatedAt = time.Now().Truncate(time.Second) original.Beads = &BeadsConfig{Prefix: "gt-"} original.LocalRepo = "/tmp/local-repo" if err := SaveRigConfig(path, original); err != nil { t.Fatalf("SaveRigConfig: %v", err) } loaded, err := LoadRigConfig(path) if err != nil { t.Fatalf("LoadRigConfig: %v", err) } if loaded.Type != "rig" { t.Errorf("Type = %q, want 'rig'", loaded.Type) } if loaded.Version != CurrentRigConfigVersion { t.Errorf("Version = %d, want %d", loaded.Version, CurrentRigConfigVersion) } if loaded.Name != "gastown" { t.Errorf("Name = %q, want 'gastown'", loaded.Name) } if loaded.GitURL != "git@github.com:test/gastown.git" { t.Errorf("GitURL = %q, want expected URL", loaded.GitURL) } if loaded.LocalRepo != "/tmp/local-repo" { t.Errorf("LocalRepo = %q, want %q", loaded.LocalRepo, "/tmp/local-repo") } if loaded.Beads == nil || loaded.Beads.Prefix != "gt-" { t.Error("Beads.Prefix not preserved") } } func TestRigSettingsRoundTrip(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "settings", "config.json") original := NewRigSettings() if err := SaveRigSettings(path, original); err != nil { t.Fatalf("SaveRigSettings: %v", err) } loaded, err := LoadRigSettings(path) if err != nil { t.Fatalf("LoadRigSettings: %v", err) } if loaded.Type != "rig-settings" { t.Errorf("Type = %q, want 'rig-settings'", loaded.Type) } if loaded.MergeQueue == nil { t.Fatal("MergeQueue is nil") } if !loaded.MergeQueue.Enabled { t.Error("MergeQueue.Enabled = false, want true") } if loaded.MergeQueue.TargetBranch != "main" { t.Errorf("MergeQueue.TargetBranch = %q, want 'main'", loaded.MergeQueue.TargetBranch) } } func TestRigSettingsWithCustomMergeQueue(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "settings.json") original := &RigSettings{ Type: "rig-settings", Version: 1, MergeQueue: &MergeQueueConfig{ Enabled: true, TargetBranch: "develop", IntegrationBranches: false, OnConflict: OnConflictAutoRebase, RunTests: true, TestCommand: "make test", DeleteMergedBranches: false, RetryFlakyTests: 3, PollInterval: "1m", MaxConcurrent: 2, }, } if err := SaveRigSettings(path, original); err != nil { t.Fatalf("SaveRigSettings: %v", err) } loaded, err := LoadRigSettings(path) if err != nil { t.Fatalf("LoadRigSettings: %v", err) } mq := loaded.MergeQueue if mq.TargetBranch != "develop" { t.Errorf("TargetBranch = %q, want 'develop'", mq.TargetBranch) } if mq.OnConflict != OnConflictAutoRebase { t.Errorf("OnConflict = %q, want %q", mq.OnConflict, OnConflictAutoRebase) } if mq.TestCommand != "make test" { t.Errorf("TestCommand = %q, want 'make test'", mq.TestCommand) } if mq.RetryFlakyTests != 3 { t.Errorf("RetryFlakyTests = %d, want 3", mq.RetryFlakyTests) } } func TestRigConfigValidation(t *testing.T) { tests := []struct { name string config *RigConfig wantErr bool }{ { name: "valid config", config: &RigConfig{ Type: "rig", Version: 1, Name: "test-rig", }, wantErr: false, }, { name: "missing name", config: &RigConfig{ Type: "rig", Version: 1, }, wantErr: true, }, { name: "wrong type", config: &RigConfig{ Type: "wrong", Version: 1, Name: "test", }, wantErr: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { err := validateRigConfig(tt.config) if (err != nil) != tt.wantErr { t.Errorf("validateRigConfig() error = %v, wantErr %v", err, tt.wantErr) } }) } } func TestRigSettingsValidation(t *testing.T) { tests := []struct { name string settings *RigSettings wantErr bool }{ { name: "valid settings", settings: &RigSettings{ Type: "rig-settings", Version: 1, MergeQueue: DefaultMergeQueueConfig(), }, wantErr: false, }, { name: "valid settings without merge queue", settings: &RigSettings{ Type: "rig-settings", Version: 1, }, wantErr: false, }, { name: "wrong type", settings: &RigSettings{ Type: "wrong", Version: 1, }, wantErr: true, }, { name: "invalid on_conflict", settings: &RigSettings{ Type: "rig-settings", Version: 1, MergeQueue: &MergeQueueConfig{ OnConflict: "invalid", }, }, wantErr: true, }, { name: "invalid poll_interval", settings: &RigSettings{ Type: "rig-settings", Version: 1, MergeQueue: &MergeQueueConfig{ PollInterval: "not-a-duration", }, }, wantErr: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { err := validateRigSettings(tt.settings) if (err != nil) != tt.wantErr { t.Errorf("validateRigSettings() error = %v, wantErr %v", err, tt.wantErr) } }) } } func TestDefaultMergeQueueConfig(t *testing.T) { cfg := DefaultMergeQueueConfig() if !cfg.Enabled { t.Error("Enabled should be true by default") } if cfg.TargetBranch != "main" { t.Errorf("TargetBranch = %q, want 'main'", cfg.TargetBranch) } if !cfg.IntegrationBranches { t.Error("IntegrationBranches should be true by default") } if cfg.OnConflict != OnConflictAssignBack { t.Errorf("OnConflict = %q, want %q", cfg.OnConflict, OnConflictAssignBack) } if !cfg.RunTests { t.Error("RunTests should be true by default") } if cfg.TestCommand != "go test ./..." { t.Errorf("TestCommand = %q, want 'go test ./...'", cfg.TestCommand) } if !cfg.DeleteMergedBranches { t.Error("DeleteMergedBranches should be true by default") } if cfg.RetryFlakyTests != 1 { t.Errorf("RetryFlakyTests = %d, want 1", cfg.RetryFlakyTests) } if cfg.PollInterval != "30s" { t.Errorf("PollInterval = %q, want '30s'", cfg.PollInterval) } if cfg.MaxConcurrent != 1 { t.Errorf("MaxConcurrent = %d, want 1", cfg.MaxConcurrent) } } func TestLoadRigConfigNotFound(t *testing.T) { _, err := LoadRigConfig("/nonexistent/path.json") if err == nil { t.Fatal("expected error for nonexistent file") } } func TestLoadRigSettingsNotFound(t *testing.T) { _, err := LoadRigSettings("/nonexistent/path.json") if err == nil { t.Fatal("expected error for nonexistent file") } } func TestMayorConfigRoundTrip(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "mayor", "config.json") original := NewMayorConfig() original.Theme = &TownThemeConfig{ RoleDefaults: map[string]string{ "witness": "rust", }, } if err := SaveMayorConfig(path, original); err != nil { t.Fatalf("SaveMayorConfig: %v", err) } loaded, err := LoadMayorConfig(path) if err != nil { t.Fatalf("LoadMayorConfig: %v", err) } if loaded.Type != "mayor-config" { t.Errorf("Type = %q, want 'mayor-config'", loaded.Type) } if loaded.Version != CurrentMayorConfigVersion { t.Errorf("Version = %d, want %d", loaded.Version, CurrentMayorConfigVersion) } if loaded.Theme == nil || loaded.Theme.RoleDefaults["witness"] != "rust" { t.Error("Theme.RoleDefaults not preserved") } } func TestLoadMayorConfigNotFound(t *testing.T) { _, err := LoadMayorConfig("/nonexistent/path.json") if err == nil { t.Fatal("expected error for nonexistent file") } } func TestAccountsConfigRoundTrip(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "mayor", "accounts.json") original := NewAccountsConfig() original.Accounts["yegge"] = Account{ Email: "steve.yegge@gmail.com", Description: "Personal account", ConfigDir: "~/.claude-accounts/yegge", } original.Accounts["ghosttrack"] = Account{ Email: "steve@ghosttrack.com", Description: "Business account", ConfigDir: "~/.claude-accounts/ghosttrack", } original.Default = "ghosttrack" if err := SaveAccountsConfig(path, original); err != nil { t.Fatalf("SaveAccountsConfig: %v", err) } loaded, err := LoadAccountsConfig(path) if err != nil { t.Fatalf("LoadAccountsConfig: %v", err) } if loaded.Version != CurrentAccountsVersion { t.Errorf("Version = %d, want %d", loaded.Version, CurrentAccountsVersion) } if len(loaded.Accounts) != 2 { t.Errorf("Accounts count = %d, want 2", len(loaded.Accounts)) } if loaded.Default != "ghosttrack" { t.Errorf("Default = %q, want 'ghosttrack'", loaded.Default) } yegge := loaded.GetAccount("yegge") if yegge == nil { t.Fatal("GetAccount('yegge') returned nil") } if yegge.Email != "steve.yegge@gmail.com" { t.Errorf("yegge.Email = %q, want 'steve.yegge@gmail.com'", yegge.Email) } defAcct := loaded.GetDefaultAccount() if defAcct == nil { t.Fatal("GetDefaultAccount() returned nil") } if defAcct.Email != "steve@ghosttrack.com" { t.Errorf("default.Email = %q, want 'steve@ghosttrack.com'", defAcct.Email) } } func TestAccountsConfigValidation(t *testing.T) { tests := []struct { name string config *AccountsConfig wantErr bool }{ { name: "valid empty config", config: NewAccountsConfig(), wantErr: false, }, { name: "valid config with accounts", config: &AccountsConfig{ Version: 1, Accounts: map[string]Account{ "test": {Email: "test@example.com", ConfigDir: "~/.claude-accounts/test"}, }, Default: "test", }, wantErr: false, }, { name: "default refers to nonexistent account", config: &AccountsConfig{ Version: 1, Accounts: map[string]Account{ "test": {Email: "test@example.com", ConfigDir: "~/.claude-accounts/test"}, }, Default: "nonexistent", }, wantErr: true, }, { name: "account missing config_dir", config: &AccountsConfig{ Version: 1, Accounts: map[string]Account{ "test": {Email: "test@example.com"}, }, }, wantErr: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { err := validateAccountsConfig(tt.config) if (err != nil) != tt.wantErr { t.Errorf("validateAccountsConfig() error = %v, wantErr %v", err, tt.wantErr) } }) } } func TestLoadAccountsConfigNotFound(t *testing.T) { _, err := LoadAccountsConfig("/nonexistent/path.json") if err == nil { t.Fatal("expected error for nonexistent file") } } func TestMessagingConfigRoundTrip(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "config", "messaging.json") original := NewMessagingConfig() original.Lists["oncall"] = []string{"mayor/", "gastown/witness"} original.Lists["cleanup"] = []string{"gastown/witness", "deacon/"} original.Queues["work/gastown"] = QueueConfig{ Workers: []string{"gastown/polecats/*"}, MaxClaims: 5, } original.Announces["alerts"] = AnnounceConfig{ Readers: []string{"@town"}, RetainCount: 100, } original.NudgeChannels["workers"] = []string{"gastown/polecats/*", "gastown/crew/*"} original.NudgeChannels["witnesses"] = []string{"*/witness"} if err := SaveMessagingConfig(path, original); err != nil { t.Fatalf("SaveMessagingConfig: %v", err) } loaded, err := LoadMessagingConfig(path) if err != nil { t.Fatalf("LoadMessagingConfig: %v", err) } if loaded.Type != "messaging" { t.Errorf("Type = %q, want 'messaging'", loaded.Type) } if loaded.Version != CurrentMessagingVersion { t.Errorf("Version = %d, want %d", loaded.Version, CurrentMessagingVersion) } // Check lists if len(loaded.Lists) != 2 { t.Errorf("Lists count = %d, want 2", len(loaded.Lists)) } if oncall, ok := loaded.Lists["oncall"]; !ok || len(oncall) != 2 { t.Error("oncall list not preserved") } // Check queues if len(loaded.Queues) != 1 { t.Errorf("Queues count = %d, want 1", len(loaded.Queues)) } if q, ok := loaded.Queues["work/gastown"]; !ok || q.MaxClaims != 5 { t.Error("queue not preserved") } // Check announces if len(loaded.Announces) != 1 { t.Errorf("Announces count = %d, want 1", len(loaded.Announces)) } if a, ok := loaded.Announces["alerts"]; !ok || a.RetainCount != 100 { t.Error("announce not preserved") } // Check nudge channels if len(loaded.NudgeChannels) != 2 { t.Errorf("NudgeChannels count = %d, want 2", len(loaded.NudgeChannels)) } if workers, ok := loaded.NudgeChannels["workers"]; !ok || len(workers) != 2 { t.Error("workers nudge channel not preserved") } if witnesses, ok := loaded.NudgeChannels["witnesses"]; !ok || len(witnesses) != 1 { t.Error("witnesses nudge channel not preserved") } } func TestMessagingConfigValidation(t *testing.T) { tests := []struct { name string config *MessagingConfig wantErr bool }{ { name: "valid empty config", config: NewMessagingConfig(), wantErr: false, }, { name: "valid config with lists", config: &MessagingConfig{ Type: "messaging", Version: 1, Lists: map[string][]string{ "oncall": {"mayor/", "gastown/witness"}, }, }, wantErr: false, }, { name: "wrong type", config: &MessagingConfig{ Type: "wrong", Version: 1, }, wantErr: true, }, { name: "future version rejected", config: &MessagingConfig{ Type: "messaging", Version: 999, }, wantErr: true, }, { name: "list with no recipients", config: &MessagingConfig{ Version: 1, Lists: map[string][]string{ "empty": {}, }, }, wantErr: true, }, { name: "queue with no workers", config: &MessagingConfig{ Version: 1, Queues: map[string]QueueConfig{ "work": {Workers: []string{}}, }, }, wantErr: true, }, { name: "queue with negative max_claims", config: &MessagingConfig{ Version: 1, Queues: map[string]QueueConfig{ "work": {Workers: []string{"worker/"}, MaxClaims: -1}, }, }, wantErr: true, }, { name: "announce with no readers", config: &MessagingConfig{ Version: 1, Announces: map[string]AnnounceConfig{ "alerts": {Readers: []string{}}, }, }, wantErr: true, }, { name: "announce with negative retain_count", config: &MessagingConfig{ Version: 1, Announces: map[string]AnnounceConfig{ "alerts": {Readers: []string{"@town"}, RetainCount: -1}, }, }, wantErr: true, }, { name: "valid config with nudge channels", config: &MessagingConfig{ Type: "messaging", Version: 1, NudgeChannels: map[string][]string{ "workers": {"gastown/polecats/*", "gastown/crew/*"}, }, }, wantErr: false, }, { name: "nudge channel with no recipients", config: &MessagingConfig{ Version: 1, NudgeChannels: map[string][]string{ "empty": {}, }, }, wantErr: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { err := validateMessagingConfig(tt.config) if (err != nil) != tt.wantErr { t.Errorf("validateMessagingConfig() error = %v, wantErr %v", err, tt.wantErr) } }) } } func TestLoadMessagingConfigNotFound(t *testing.T) { _, err := LoadMessagingConfig("/nonexistent/path.json") if err == nil { t.Fatal("expected error for nonexistent file") } } func TestLoadMessagingConfigMalformedJSON(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "messaging.json") // Write malformed JSON if err := os.WriteFile(path, []byte("{not valid json"), 0644); err != nil { t.Fatalf("writing test file: %v", err) } _, err := LoadMessagingConfig(path) if err == nil { t.Fatal("expected error for malformed JSON") } } func TestLoadOrCreateMessagingConfig(t *testing.T) { // Test creating default when not found config, err := LoadOrCreateMessagingConfig("/nonexistent/path.json") if err != nil { t.Fatalf("LoadOrCreateMessagingConfig: %v", err) } if config == nil { t.Fatal("expected non-nil config") } if config.Version != CurrentMessagingVersion { t.Errorf("Version = %d, want %d", config.Version, CurrentMessagingVersion) } // Test loading existing dir := t.TempDir() path := filepath.Join(dir, "messaging.json") original := NewMessagingConfig() original.Lists["test"] = []string{"mayor/"} if err := SaveMessagingConfig(path, original); err != nil { t.Fatalf("SaveMessagingConfig: %v", err) } loaded, err := LoadOrCreateMessagingConfig(path) if err != nil { t.Fatalf("LoadOrCreateMessagingConfig: %v", err) } if _, ok := loaded.Lists["test"]; !ok { t.Error("existing config not loaded") } } func TestMessagingConfigPath(t *testing.T) { path := MessagingConfigPath("/home/user/gt") expected := "/home/user/gt/config/messaging.json" if path != expected { t.Errorf("MessagingConfigPath = %q, want %q", path, expected) } } func TestRuntimeConfigDefaults(t *testing.T) { rc := DefaultRuntimeConfig() if rc.Command != "claude" { t.Errorf("Command = %q, want %q", rc.Command, "claude") } if len(rc.Args) != 1 || rc.Args[0] != "--dangerously-skip-permissions" { t.Errorf("Args = %v, want [--dangerously-skip-permissions]", rc.Args) } } func TestRuntimeConfigBuildCommand(t *testing.T) { tests := []struct { name string rc *RuntimeConfig want string }{ { name: "nil config uses defaults", rc: nil, want: "claude --dangerously-skip-permissions", }, { name: "default config", rc: DefaultRuntimeConfig(), want: "claude --dangerously-skip-permissions", }, { name: "custom command", rc: &RuntimeConfig{Command: "aider", Args: []string{"--no-git"}}, want: "aider --no-git", }, { name: "multiple args", rc: &RuntimeConfig{Command: "claude", Args: []string{"--model", "opus", "--no-confirm"}}, want: "claude --model opus --no-confirm", }, { name: "empty command uses default", rc: &RuntimeConfig{Command: "", Args: nil}, want: "claude --dangerously-skip-permissions", }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { got := tt.rc.BuildCommand() if got != tt.want { t.Errorf("BuildCommand() = %q, want %q", got, tt.want) } }) } } func TestRuntimeConfigBuildCommandWithPrompt(t *testing.T) { tests := []struct { name string rc *RuntimeConfig prompt string want string }{ { name: "no prompt", rc: DefaultRuntimeConfig(), prompt: "", want: "claude --dangerously-skip-permissions", }, { name: "with prompt", rc: DefaultRuntimeConfig(), prompt: "gt prime", want: `claude --dangerously-skip-permissions "gt prime"`, }, { name: "prompt with quotes", rc: DefaultRuntimeConfig(), prompt: `Hello "world"`, want: `claude --dangerously-skip-permissions "Hello \"world\""`, }, { name: "config initial prompt used if no override", rc: &RuntimeConfig{Command: "aider", Args: []string{}, InitialPrompt: "/help"}, prompt: "", want: `aider "/help"`, }, { name: "override takes precedence over config", rc: &RuntimeConfig{Command: "aider", Args: []string{}, InitialPrompt: "/help"}, prompt: "custom prompt", want: `aider "custom prompt"`, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { got := tt.rc.BuildCommandWithPrompt(tt.prompt) if got != tt.want { t.Errorf("BuildCommandWithPrompt(%q) = %q, want %q", tt.prompt, got, tt.want) } }) } } func TestBuildAgentStartupCommand(t *testing.T) { // Test without rig config (uses defaults) cmd := BuildAgentStartupCommand("witness", "gastown/witness", "", "") // Should contain environment exports and claude command if !strings.Contains(cmd, "export") { t.Error("expected export in command") } if !strings.Contains(cmd, "GT_ROLE=witness") { t.Error("expected GT_ROLE=witness in command") } if !strings.Contains(cmd, "BD_ACTOR=gastown/witness") { t.Error("expected BD_ACTOR in command") } if !strings.Contains(cmd, "claude --dangerously-skip-permissions") { t.Error("expected claude command in output") } } func TestBuildPolecatStartupCommand(t *testing.T) { cmd := BuildPolecatStartupCommand("gastown", "toast", "", "") if !strings.Contains(cmd, "GT_ROLE=polecat") { t.Error("expected GT_ROLE=polecat in command") } if !strings.Contains(cmd, "GT_RIG=gastown") { t.Error("expected GT_RIG=gastown in command") } if !strings.Contains(cmd, "GT_POLECAT=toast") { t.Error("expected GT_POLECAT=toast in command") } if !strings.Contains(cmd, "BD_ACTOR=gastown/polecats/toast") { t.Error("expected BD_ACTOR in command") } } func TestBuildCrewStartupCommand(t *testing.T) { cmd := BuildCrewStartupCommand("gastown", "max", "", "") if !strings.Contains(cmd, "GT_ROLE=crew") { t.Error("expected GT_ROLE=crew in command") } if !strings.Contains(cmd, "GT_RIG=gastown") { t.Error("expected GT_RIG=gastown in command") } if !strings.Contains(cmd, "GT_CREW=max") { t.Error("expected GT_CREW=max in command") } if !strings.Contains(cmd, "BD_ACTOR=gastown/crew/max") { t.Error("expected BD_ACTOR in command") } } func TestLoadRuntimeConfigFromSettings(t *testing.T) { // Create temp rig with custom runtime config dir := t.TempDir() settingsDir := filepath.Join(dir, "settings") if err := os.MkdirAll(settingsDir, 0755); err != nil { t.Fatalf("creating settings dir: %v", err) } settings := NewRigSettings() settings.Runtime = &RuntimeConfig{ Command: "aider", Args: []string{"--no-git", "--model", "claude-3"}, } if err := SaveRigSettings(filepath.Join(settingsDir, "config.json"), settings); err != nil { t.Fatalf("saving settings: %v", err) } // Load and verify rc := LoadRuntimeConfig(dir) if rc.Command != "aider" { t.Errorf("Command = %q, want %q", rc.Command, "aider") } if len(rc.Args) != 3 { t.Errorf("Args = %v, want 3 args", rc.Args) } cmd := rc.BuildCommand() if cmd != "aider --no-git --model claude-3" { t.Errorf("BuildCommand() = %q, want %q", cmd, "aider --no-git --model claude-3") } } func TestLoadRuntimeConfigFallsBackToDefaults(t *testing.T) { // Non-existent path should use defaults rc := LoadRuntimeConfig("/nonexistent/path") if rc.Command != "claude" { t.Errorf("Command = %q, want %q (default)", rc.Command, "claude") } } func TestDaemonPatrolConfigRoundTrip(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "mayor", "daemon.json") original := NewDaemonPatrolConfig() original.Patrols["custom"] = PatrolConfig{ Enabled: true, Interval: "10m", Agent: "custom-agent", } if err := SaveDaemonPatrolConfig(path, original); err != nil { t.Fatalf("SaveDaemonPatrolConfig: %v", err) } loaded, err := LoadDaemonPatrolConfig(path) if err != nil { t.Fatalf("LoadDaemonPatrolConfig: %v", err) } if loaded.Type != "daemon-patrol-config" { t.Errorf("Type = %q, want 'daemon-patrol-config'", loaded.Type) } if loaded.Version != CurrentDaemonPatrolConfigVersion { t.Errorf("Version = %d, want %d", loaded.Version, CurrentDaemonPatrolConfigVersion) } if loaded.Heartbeat == nil || !loaded.Heartbeat.Enabled { t.Error("Heartbeat not preserved") } if len(loaded.Patrols) != 4 { t.Errorf("Patrols count = %d, want 4", len(loaded.Patrols)) } if custom, ok := loaded.Patrols["custom"]; !ok || custom.Agent != "custom-agent" { t.Error("custom patrol not preserved") } } func TestDaemonPatrolConfigValidation(t *testing.T) { tests := []struct { name string config *DaemonPatrolConfig wantErr bool }{ { name: "valid default config", config: NewDaemonPatrolConfig(), wantErr: false, }, { name: "valid minimal config", config: &DaemonPatrolConfig{ Type: "daemon-patrol-config", Version: 1, }, wantErr: false, }, { name: "wrong type", config: &DaemonPatrolConfig{ Type: "wrong", Version: 1, }, wantErr: true, }, { name: "future version rejected", config: &DaemonPatrolConfig{ Type: "daemon-patrol-config", Version: 999, }, wantErr: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { err := validateDaemonPatrolConfig(tt.config) if (err != nil) != tt.wantErr { t.Errorf("validateDaemonPatrolConfig() error = %v, wantErr %v", err, tt.wantErr) } }) } } func TestLoadDaemonPatrolConfigNotFound(t *testing.T) { _, err := LoadDaemonPatrolConfig("/nonexistent/path.json") if err == nil { t.Fatal("expected error for nonexistent file") } } func TestDaemonPatrolConfigPath(t *testing.T) { tests := []struct { townRoot string expected string }{ {"/home/user/gt", "/home/user/gt/mayor/daemon.json"}, {"/var/lib/gastown", "/var/lib/gastown/mayor/daemon.json"}, {"/tmp/test-workspace", "/tmp/test-workspace/mayor/daemon.json"}, {"~/gt", "~/gt/mayor/daemon.json"}, } for _, tt := range tests { t.Run(tt.townRoot, func(t *testing.T) { path := DaemonPatrolConfigPath(tt.townRoot) if path != tt.expected { t.Errorf("DaemonPatrolConfigPath(%q) = %q, want %q", tt.townRoot, path, tt.expected) } }) } } func TestEnsureDaemonPatrolConfig(t *testing.T) { t.Run("creates config if missing", func(t *testing.T) { dir := t.TempDir() if err := os.MkdirAll(filepath.Join(dir, "mayor"), 0755); err != nil { t.Fatalf("creating mayor dir: %v", err) } err := EnsureDaemonPatrolConfig(dir) if err != nil { t.Fatalf("EnsureDaemonPatrolConfig: %v", err) } path := DaemonPatrolConfigPath(dir) loaded, err := LoadDaemonPatrolConfig(path) if err != nil { t.Fatalf("LoadDaemonPatrolConfig: %v", err) } if loaded.Type != "daemon-patrol-config" { t.Errorf("Type = %q, want 'daemon-patrol-config'", loaded.Type) } if len(loaded.Patrols) != 3 { t.Errorf("Patrols count = %d, want 3 (deacon, witness, refinery)", len(loaded.Patrols)) } }) t.Run("preserves existing config", func(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "mayor", "daemon.json") existing := &DaemonPatrolConfig{ Type: "daemon-patrol-config", Version: 1, Patrols: map[string]PatrolConfig{ "custom-only": {Enabled: true, Agent: "custom"}, }, } if err := SaveDaemonPatrolConfig(path, existing); err != nil { t.Fatalf("SaveDaemonPatrolConfig: %v", err) } err := EnsureDaemonPatrolConfig(dir) if err != nil { t.Fatalf("EnsureDaemonPatrolConfig: %v", err) } loaded, err := LoadDaemonPatrolConfig(path) if err != nil { t.Fatalf("LoadDaemonPatrolConfig: %v", err) } if len(loaded.Patrols) != 1 { t.Errorf("Patrols count = %d, want 1 (should preserve existing)", len(loaded.Patrols)) } if _, ok := loaded.Patrols["custom-only"]; !ok { t.Error("existing custom patrol was overwritten") } }) } func TestNewDaemonPatrolConfig(t *testing.T) { cfg := NewDaemonPatrolConfig() if cfg.Type != "daemon-patrol-config" { t.Errorf("Type = %q, want 'daemon-patrol-config'", cfg.Type) } if cfg.Version != CurrentDaemonPatrolConfigVersion { t.Errorf("Version = %d, want %d", cfg.Version, CurrentDaemonPatrolConfigVersion) } if cfg.Heartbeat == nil { t.Fatal("Heartbeat is nil") } if !cfg.Heartbeat.Enabled { t.Error("Heartbeat.Enabled should be true by default") } if cfg.Heartbeat.Interval != "3m" { t.Errorf("Heartbeat.Interval = %q, want '3m'", cfg.Heartbeat.Interval) } if len(cfg.Patrols) != 3 { t.Errorf("Patrols count = %d, want 3", len(cfg.Patrols)) } for _, name := range []string{"deacon", "witness", "refinery"} { patrol, ok := cfg.Patrols[name] if !ok { t.Errorf("missing %s patrol", name) continue } if !patrol.Enabled { t.Errorf("%s patrol should be enabled by default", name) } if patrol.Agent != name { t.Errorf("%s patrol Agent = %q, want %q", name, patrol.Agent, name) } } } func TestSaveTownSettings(t *testing.T) { t.Run("saves valid town settings", func(t *testing.T) { tmpDir := t.TempDir() settingsPath := filepath.Join(tmpDir, "settings", "config.json") settings := &TownSettings{ Type: "town-settings", Version: CurrentTownSettingsVersion, DefaultAgent: "gemini", Agents: map[string]*RuntimeConfig{ "my-agent": { Command: "my-agent", Args: []string{"--arg1", "--arg2"}, }, }, } err := SaveTownSettings(settingsPath, settings) if err != nil { t.Fatalf("SaveTownSettings failed: %v", err) } // Verify file exists data, err := os.ReadFile(settingsPath) if err != nil { t.Fatalf("reading settings file: %v", err) } // Verify it contains expected content content := string(data) if !strings.Contains(content, `"type": "town-settings"`) { t.Errorf("missing type field") } if !strings.Contains(content, `"default_agent": "gemini"`) { t.Errorf("missing default_agent field") } if !strings.Contains(content, `"my-agent"`) { t.Errorf("missing custom agent") } }) t.Run("creates parent directories", func(t *testing.T) { tmpDir := t.TempDir() settingsPath := filepath.Join(tmpDir, "deeply", "nested", "settings", "config.json") settings := NewTownSettings() err := SaveTownSettings(settingsPath, settings) if err != nil { t.Fatalf("SaveTownSettings failed: %v", err) } // Verify file exists if _, err := os.Stat(settingsPath); err != nil { t.Errorf("settings file not created: %v", err) } }) t.Run("rejects invalid type", func(t *testing.T) { tmpDir := t.TempDir() settingsPath := filepath.Join(tmpDir, "config.json") settings := &TownSettings{ Type: "invalid-type", Version: CurrentTownSettingsVersion, } err := SaveTownSettings(settingsPath, settings) if err == nil { t.Error("expected error for invalid type") } }) t.Run("rejects unsupported version", func(t *testing.T) { tmpDir := t.TempDir() settingsPath := filepath.Join(tmpDir, "config.json") settings := &TownSettings{ Type: "town-settings", Version: CurrentTownSettingsVersion + 100, } err := SaveTownSettings(settingsPath, settings) if err == nil { t.Error("expected error for unsupported version") } }) t.Run("roundtrip save and load", func(t *testing.T) { tmpDir := t.TempDir() settingsPath := filepath.Join(tmpDir, "config.json") original := &TownSettings{ Type: "town-settings", Version: CurrentTownSettingsVersion, DefaultAgent: "codex", Agents: map[string]*RuntimeConfig{ "custom-1": { Command: "custom-agent", Args: []string{"--flag"}, }, }, } err := SaveTownSettings(settingsPath, original) if err != nil { t.Fatalf("SaveTownSettings failed: %v", err) } loaded, err := LoadOrCreateTownSettings(settingsPath) if err != nil { t.Fatalf("LoadOrCreateTownSettings failed: %v", err) } if loaded.Type != original.Type { t.Errorf("Type = %q, want %q", loaded.Type, original.Type) } if loaded.Version != original.Version { t.Errorf("Version = %d, want %d", loaded.Version, original.Version) } if loaded.DefaultAgent != original.DefaultAgent { t.Errorf("DefaultAgent = %q, want %q", loaded.DefaultAgent, original.DefaultAgent) } if len(loaded.Agents) != len(original.Agents) { t.Errorf("Agents count = %d, want %d", len(loaded.Agents), len(original.Agents)) } }) }