Files
gastown/internal/cmd/mail_inbox.go
Artem Bambalov 533caf8e4b Detect and clean stale POLECAT_DONE messages (#913)
* fix(witness): detect and ignore stale POLECAT_DONE messages

Add timestamp validation to prevent witness from nuking newly spawned
polecat sessions when processing stale POLECAT_DONE messages from
previous sessions.

- Add isStalePolecatDone() to compare message timestamp vs session created time
- If message timestamp < session created time, message is stale and ignored
- Add unit tests for timestamp parsing and stale detection logic

Fixes #909

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(mail): add --stale flag to gt mail archive

Add ability to archive stale messages (sent before current session started).
This prevents old messages from cycling forever in patrol inbox.

Changes:
- Add --stale and --dry-run flags to gt mail archive
- Move stale detection helpers to internal/session/stale.go for reuse
- Add ParseAddress to parse mail addresses into AgentIdentity
- Add SessionCreatedAt to get tmux session start time

Usage:
  gt mail archive --stale           # Archive all stale messages
  gt mail archive --stale --dry-run # Preview what would be archived

Co-Authored-By: GPT-5.2 Codex <noreply@openai.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: GPT-5.2 Codex <noreply@openai.com>
2026-01-24 21:47:59 -08:00

551 lines
14 KiB
Go

package cmd
import (
"encoding/json"
"errors"
"fmt"
"os"
"strconv"
"strings"
"time"
"github.com/spf13/cobra"
"github.com/steveyegge/gastown/internal/mail"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/style"
)
// getMailbox returns the mailbox for the given address.
func getMailbox(address string) (*mail.Mailbox, error) {
// All mail uses town beads (two-level architecture)
workDir, err := findMailWorkDir()
if err != nil {
return nil, fmt.Errorf("not in a Gas Town workspace: %w", err)
}
// Get mailbox
router := mail.NewRouter(workDir)
mailbox, err := router.GetMailbox(address)
if err != nil {
return nil, fmt.Errorf("getting mailbox: %w", err)
}
return mailbox, nil
}
func runMailInbox(cmd *cobra.Command, args []string) error {
// Check for mutually exclusive flags
if mailInboxAll && mailInboxUnread {
return errors.New("--all and --unread are mutually exclusive")
}
// Determine which inbox to check (priority: --identity flag, positional arg, auto-detect)
address := ""
if mailInboxIdentity != "" {
address = mailInboxIdentity
} else if len(args) > 0 {
address = args[0]
} else {
address = detectSender()
}
mailbox, err := getMailbox(address)
if err != nil {
return err
}
// Get messages
// --all is the default behavior (shows all messages)
// --unread filters to only unread messages
var messages []*mail.Message
if mailInboxUnread {
messages, err = mailbox.ListUnread()
} else {
messages, err = mailbox.List()
}
if err != nil {
return fmt.Errorf("listing messages: %w", err)
}
// JSON output
if mailInboxJSON {
enc := json.NewEncoder(os.Stdout)
enc.SetIndent("", " ")
return enc.Encode(messages)
}
// Human-readable output
total, unread, _ := mailbox.Count()
fmt.Printf("%s Inbox: %s (%d messages, %d unread)\n\n",
style.Bold.Render("📬"), address, total, unread)
if len(messages) == 0 {
fmt.Printf(" %s\n", style.Dim.Render("(no messages)"))
return nil
}
for i, msg := range messages {
readMarker := "●"
if msg.Read {
readMarker = "○"
}
typeMarker := ""
if msg.Type != "" && msg.Type != mail.TypeNotification {
typeMarker = fmt.Sprintf(" [%s]", msg.Type)
}
priorityMarker := ""
if msg.Priority == mail.PriorityHigh || msg.Priority == mail.PriorityUrgent {
priorityMarker = " " + style.Bold.Render("!")
}
wispMarker := ""
if msg.Wisp {
wispMarker = " " + style.Dim.Render("(wisp)")
}
// Show 1-based index for easy reference with 'gt mail read <n>'
indexStr := style.Dim.Render(fmt.Sprintf("%d.", i+1))
fmt.Printf(" %s %s %s%s%s%s\n", indexStr, readMarker, msg.Subject, typeMarker, priorityMarker, wispMarker)
fmt.Printf(" %s from %s\n",
style.Dim.Render(msg.ID),
msg.From)
fmt.Printf(" %s\n",
style.Dim.Render(msg.Timestamp.Format("2006-01-02 15:04")))
}
return nil
}
func runMailRead(cmd *cobra.Command, args []string) error {
if len(args) == 0 {
return errors.New("message ID or index required")
}
msgRef := args[0]
// Determine which inbox
address := detectSender()
mailbox, err := getMailbox(address)
if err != nil {
return err
}
// Check if the argument is a numeric index (1-based)
var msgID string
if idx, err := strconv.Atoi(msgRef); err == nil && idx > 0 {
// Numeric index: resolve to message ID by listing inbox
messages, err := mailbox.List()
if err != nil {
return fmt.Errorf("listing messages: %w", err)
}
if idx > len(messages) {
return fmt.Errorf("index %d out of range (inbox has %d messages)", idx, len(messages))
}
msgID = messages[idx-1].ID
} else {
msgID = msgRef
}
msg, err := mailbox.Get(msgID)
if err != nil {
return fmt.Errorf("getting message: %w", err)
}
// Note: We intentionally do NOT mark as read/ack on read.
// User must explicitly delete/ack the message.
// This preserves handoff messages for reference.
// JSON output
if mailReadJSON {
enc := json.NewEncoder(os.Stdout)
enc.SetIndent("", " ")
return enc.Encode(msg)
}
// Human-readable output
priorityStr := ""
if msg.Priority == mail.PriorityUrgent {
priorityStr = " " + style.Bold.Render("[URGENT]")
} else if msg.Priority == mail.PriorityHigh {
priorityStr = " " + style.Bold.Render("[HIGH PRIORITY]")
}
typeStr := ""
if msg.Type != "" && msg.Type != mail.TypeNotification {
typeStr = fmt.Sprintf(" [%s]", msg.Type)
}
fmt.Printf("%s %s%s%s\n\n", style.Bold.Render("Subject:"), msg.Subject, typeStr, priorityStr)
fmt.Printf("From: %s\n", msg.From)
fmt.Printf("To: %s\n", msg.To)
fmt.Printf("Date: %s\n", msg.Timestamp.Format("2006-01-02 15:04:05"))
fmt.Printf("ID: %s\n", style.Dim.Render(msg.ID))
if msg.ThreadID != "" {
fmt.Printf("Thread: %s\n", style.Dim.Render(msg.ThreadID))
}
if msg.ReplyTo != "" {
fmt.Printf("Reply-To: %s\n", style.Dim.Render(msg.ReplyTo))
}
if msg.Body != "" {
fmt.Printf("\n%s\n", msg.Body)
}
return nil
}
func runMailPeek(cmd *cobra.Command, args []string) error {
// Determine which inbox
address := detectSender()
mailbox, err := getMailbox(address)
if err != nil {
return NewSilentExit(1) // Silent exit - can't access mailbox
}
// Get unread messages
messages, err := mailbox.ListUnread()
if err != nil || len(messages) == 0 {
return NewSilentExit(1) // Silent exit - no unread
}
// Show first unread message
msg := messages[0]
// Header with priority indicator
priorityStr := ""
if msg.Priority == mail.PriorityUrgent {
priorityStr = " [URGENT]"
} else if msg.Priority == mail.PriorityHigh {
priorityStr = " [!]"
}
fmt.Printf("📬 %s%s\n", msg.Subject, priorityStr)
fmt.Printf("From: %s\n", msg.From)
fmt.Printf("ID: %s\n\n", msg.ID)
// Body preview (truncate long bodies)
if msg.Body != "" {
body := msg.Body
// Truncate to ~500 chars for popup display
if len(body) > 500 {
body = body[:500] + "\n..."
}
fmt.Print(body)
if !strings.HasSuffix(body, "\n") {
fmt.Println()
}
}
// Show count if more messages
if len(messages) > 1 {
fmt.Printf("\n%s\n", style.Dim.Render(fmt.Sprintf("(+%d more unread)", len(messages)-1)))
}
return nil
}
func runMailDelete(cmd *cobra.Command, args []string) error {
// Determine which inbox
address := detectSender()
mailbox, err := getMailbox(address)
if err != nil {
return err
}
// Delete all specified messages
deleted := 0
var errors []string
for _, msgID := range args {
if err := mailbox.Delete(msgID); err != nil {
errors = append(errors, fmt.Sprintf("%s: %v", msgID, err))
} else {
deleted++
}
}
// Report results
if len(errors) > 0 {
fmt.Printf("%s Deleted %d/%d messages\n",
style.Bold.Render("⚠"), deleted, len(args))
for _, e := range errors {
fmt.Printf(" Error: %s\n", e)
}
return fmt.Errorf("failed to delete %d messages", len(errors))
}
if len(args) == 1 {
fmt.Printf("%s Message deleted\n", style.Bold.Render("✓"))
} else {
fmt.Printf("%s Deleted %d messages\n", style.Bold.Render("✓"), deleted)
}
return nil
}
func runMailArchive(cmd *cobra.Command, args []string) error {
// Determine which inbox
address := detectSender()
mailbox, err := getMailbox(address)
if err != nil {
return err
}
if mailArchiveStale {
if len(args) > 0 {
return errors.New("--stale cannot be combined with message IDs")
}
return runMailArchiveStale(mailbox, address)
}
if len(args) == 0 {
return errors.New("message ID required unless using --stale")
}
if mailArchiveDryRun {
fmt.Printf("%s Would archive %d message(s)\n", style.Dim.Render("(dry-run)"), len(args))
for _, msgID := range args {
fmt.Printf(" %s\n", style.Dim.Render(msgID))
}
return nil
}
// Archive all specified messages
archived := 0
var errors []string
for _, msgID := range args {
if err := mailbox.Delete(msgID); err != nil {
errors = append(errors, fmt.Sprintf("%s: %v", msgID, err))
} else {
archived++
}
}
// Report results
if len(errors) > 0 {
fmt.Printf("%s Archived %d/%d messages\n",
style.Bold.Render("⚠"), archived, len(args))
for _, e := range errors {
fmt.Printf(" Error: %s\n", e)
}
return fmt.Errorf("failed to archive %d messages", len(errors))
}
if len(args) == 1 {
fmt.Printf("%s Message archived\n", style.Bold.Render("✓"))
} else {
fmt.Printf("%s Archived %d messages\n", style.Bold.Render("✓"), archived)
}
return nil
}
type staleMessage struct {
Message *mail.Message
Reason string
}
func runMailArchiveStale(mailbox *mail.Mailbox, address string) error {
identity, err := session.ParseAddress(address)
if err != nil {
return fmt.Errorf("determining session for %s: %w", address, err)
}
sessionName := identity.SessionName()
if sessionName == "" {
return fmt.Errorf("could not determine session name for %s", address)
}
sessionStart, err := session.SessionCreatedAt(sessionName)
if err != nil {
return fmt.Errorf("getting session start time for %s: %w", sessionName, err)
}
messages, err := mailbox.List()
if err != nil {
return fmt.Errorf("listing messages: %w", err)
}
staleMessages := staleMessagesForSession(messages, sessionStart)
if mailArchiveDryRun {
if len(staleMessages) == 0 {
fmt.Printf("%s No stale messages found\n", style.Success.Render("✓"))
return nil
}
fmt.Printf("%s Would archive %d stale message(s):\n", style.Dim.Render("(dry-run)"), len(staleMessages))
for _, stale := range staleMessages {
fmt.Printf(" %s %s\n", style.Dim.Render(stale.Message.ID), stale.Message.Subject)
}
return nil
}
if len(staleMessages) == 0 {
fmt.Printf("%s No stale messages to archive\n", style.Success.Render("✓"))
return nil
}
archived := 0
var errors []string
for _, stale := range staleMessages {
if err := mailbox.Delete(stale.Message.ID); err != nil {
errors = append(errors, fmt.Sprintf("%s: %v", stale.Message.ID, err))
} else {
archived++
}
}
if len(errors) > 0 {
fmt.Printf("%s Archived %d/%d stale messages\n", style.Bold.Render("⚠"), archived, len(staleMessages))
for _, e := range errors {
fmt.Printf(" Error: %s\n", e)
}
return fmt.Errorf("failed to archive %d stale messages", len(errors))
}
if archived == 1 {
fmt.Printf("%s Stale message archived\n", style.Bold.Render("✓"))
} else {
fmt.Printf("%s Archived %d stale messages\n", style.Bold.Render("✓"), archived)
}
return nil
}
func staleMessagesForSession(messages []*mail.Message, sessionStart time.Time) []staleMessage {
var staleMessages []staleMessage
for _, msg := range messages {
stale, reason := session.StaleReasonForTimes(msg.Timestamp, sessionStart)
if stale {
staleMessages = append(staleMessages, staleMessage{Message: msg, Reason: reason})
}
}
return staleMessages
}
func runMailMarkRead(cmd *cobra.Command, args []string) error {
// Determine which inbox
address := detectSender()
mailbox, err := getMailbox(address)
if err != nil {
return err
}
// Mark all specified messages as read
marked := 0
var errors []string
for _, msgID := range args {
if err := mailbox.MarkReadOnly(msgID); err != nil {
errors = append(errors, fmt.Sprintf("%s: %v", msgID, err))
} else {
marked++
}
}
// Report results
if len(errors) > 0 {
fmt.Printf("%s Marked %d/%d messages as read\n",
style.Bold.Render("⚠"), marked, len(args))
for _, e := range errors {
fmt.Printf(" Error: %s\n", e)
}
return fmt.Errorf("failed to mark %d messages", len(errors))
}
if len(args) == 1 {
fmt.Printf("%s Message marked as read\n", style.Bold.Render("✓"))
} else {
fmt.Printf("%s Marked %d messages as read\n", style.Bold.Render("✓"), marked)
}
return nil
}
func runMailMarkUnread(cmd *cobra.Command, args []string) error {
// Determine which inbox
address := detectSender()
mailbox, err := getMailbox(address)
if err != nil {
return err
}
// Mark all specified messages as unread
marked := 0
var errors []string
for _, msgID := range args {
if err := mailbox.MarkUnreadOnly(msgID); err != nil {
errors = append(errors, fmt.Sprintf("%s: %v", msgID, err))
} else {
marked++
}
}
// Report results
if len(errors) > 0 {
fmt.Printf("%s Marked %d/%d messages as unread\n",
style.Bold.Render("⚠"), marked, len(args))
for _, e := range errors {
fmt.Printf(" Error: %s\n", e)
}
return fmt.Errorf("failed to mark %d messages", len(errors))
}
if len(args) == 1 {
fmt.Printf("%s Message marked as unread\n", style.Bold.Render("✓"))
} else {
fmt.Printf("%s Marked %d messages as unread\n", style.Bold.Render("✓"), marked)
}
return nil
}
func runMailClear(cmd *cobra.Command, args []string) error {
// Determine which inbox to clear (target arg or auto-detect)
address := ""
if len(args) > 0 {
address = args[0]
} else {
address = detectSender()
}
mailbox, err := getMailbox(address)
if err != nil {
return err
}
// List all messages
messages, err := mailbox.List()
if err != nil {
return fmt.Errorf("listing messages: %w", err)
}
if len(messages) == 0 {
fmt.Printf("%s Inbox %s is already empty\n", style.Dim.Render("○"), address)
return nil
}
// Delete each message
deleted := 0
var errors []string
for _, msg := range messages {
if err := mailbox.Delete(msg.ID); err != nil {
// If file is already gone (race condition), ignore it and count as success
if os.IsNotExist(err) || strings.Contains(err.Error(), "no such file") {
continue
}
errors = append(errors, fmt.Sprintf("%s: %v", msg.ID, err))
} else {
deleted++
}
}
// Report results
if len(errors) > 0 {
fmt.Printf("%s Cleared %d/%d messages from %s\n",
style.Bold.Render("⚠"), deleted, len(messages), address)
for _, e := range errors {
fmt.Printf(" Error: %s\n", e)
}
return fmt.Errorf("failed to clear %d messages", len(errors))
}
fmt.Printf("%s Cleared %d messages from %s\n",
style.Bold.Render("✓"), deleted, address)
return nil
}