Files
gastown/internal/cmd/hooks_test.go
dementus 493507ad4e fix(hooks): discover crew-level and polecats-level settings
The `gt hooks` command was not discovering settings at:
- <rig>/crew/.claude/settings.json (crew-level, inherited by all members)
- <rig>/polecats/.claude/settings.json (polecats-level)

This caused confusion when debugging hooks since Claude Code inherits
from parent directories, so hooks were executing but not shown by
`gt hooks`.

Also fixed: skip .claude directories when iterating crew members.

Fixes: gh-735

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-22 21:39:31 -08:00

215 lines
5.5 KiB
Go

package cmd
import (
"encoding/json"
"os"
"path/filepath"
"testing"
)
func TestParseHooksFile(t *testing.T) {
// Create a temp directory with a test settings file
tmpDir := t.TempDir()
claudeDir := filepath.Join(tmpDir, ".claude")
if err := os.MkdirAll(claudeDir, 0755); err != nil {
t.Fatalf("failed to create .claude dir: %v", err)
}
settings := ClaudeSettings{
Hooks: map[string][]ClaudeHookMatcher{
"SessionStart": {
{
Matcher: "",
Hooks: []ClaudeHook{
{Type: "command", Command: "gt prime"},
},
},
},
"UserPromptSubmit": {
{
Matcher: "*.go",
Hooks: []ClaudeHook{
{Type: "command", Command: "go fmt"},
{Type: "command", Command: "go vet"},
},
},
},
},
}
data, err := json.Marshal(settings)
if err != nil {
t.Fatalf("failed to marshal settings: %v", err)
}
settingsPath := filepath.Join(claudeDir, "settings.json")
if err := os.WriteFile(settingsPath, data, 0644); err != nil {
t.Fatalf("failed to write settings: %v", err)
}
// Parse the file
hooks, err := parseHooksFile(settingsPath, "test/agent")
if err != nil {
t.Fatalf("parseHooksFile failed: %v", err)
}
// Verify results
if len(hooks) != 2 {
t.Errorf("expected 2 hooks, got %d", len(hooks))
}
// Find the SessionStart hook
var sessionStart, userPrompt *HookInfo
for i := range hooks {
switch hooks[i].Type {
case "SessionStart":
sessionStart = &hooks[i]
case "UserPromptSubmit":
userPrompt = &hooks[i]
}
}
if sessionStart == nil {
t.Fatal("expected SessionStart hook")
}
if sessionStart.Agent != "test/agent" {
t.Errorf("expected agent 'test/agent', got %q", sessionStart.Agent)
}
if len(sessionStart.Commands) != 1 || sessionStart.Commands[0] != "gt prime" {
t.Errorf("unexpected SessionStart commands: %v", sessionStart.Commands)
}
if userPrompt == nil {
t.Fatal("expected UserPromptSubmit hook")
}
if userPrompt.Matcher != "*.go" {
t.Errorf("expected matcher '*.go', got %q", userPrompt.Matcher)
}
if len(userPrompt.Commands) != 2 {
t.Errorf("expected 2 commands, got %d", len(userPrompt.Commands))
}
}
func TestParseHooksFileMissing(t *testing.T) {
_, err := parseHooksFile("/nonexistent/settings.json", "test")
if err == nil {
t.Error("expected error for missing file")
}
}
func TestParseHooksFileInvalidJSON(t *testing.T) {
tmpDir := t.TempDir()
settingsPath := filepath.Join(tmpDir, "settings.json")
if err := os.WriteFile(settingsPath, []byte("not json"), 0644); err != nil {
t.Fatalf("failed to write file: %v", err)
}
_, err := parseHooksFile(settingsPath, "test")
if err == nil {
t.Error("expected error for invalid JSON")
}
}
func TestParseHooksFileEmptyHooks(t *testing.T) {
tmpDir := t.TempDir()
settingsPath := filepath.Join(tmpDir, "settings.json")
settings := ClaudeSettings{
Hooks: map[string][]ClaudeHookMatcher{},
}
data, _ := json.Marshal(settings)
if err := os.WriteFile(settingsPath, data, 0644); err != nil {
t.Fatalf("failed to write file: %v", err)
}
hooks, err := parseHooksFile(settingsPath, "test")
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if len(hooks) != 0 {
t.Errorf("expected 0 hooks, got %d", len(hooks))
}
}
func TestDiscoverHooksCrewLevel(t *testing.T) {
// Create a temp directory structure simulating a Gas Town workspace
tmpDir := t.TempDir()
// Create rig structure with crew-level and polecats-level settings
rigName := "testrig"
rigDir := filepath.Join(tmpDir, rigName)
// Create crew-level settings (inherited by all crew members)
crewClaudeDir := filepath.Join(rigDir, "crew", ".claude")
if err := os.MkdirAll(crewClaudeDir, 0755); err != nil {
t.Fatalf("failed to create crew/.claude dir: %v", err)
}
crewSettings := ClaudeSettings{
Hooks: map[string][]ClaudeHookMatcher{
"SessionStart": {
{
Matcher: "",
Hooks: []ClaudeHook{
{Type: "command", Command: "crew-level-hook"},
},
},
},
},
}
crewData, _ := json.Marshal(crewSettings)
if err := os.WriteFile(filepath.Join(crewClaudeDir, "settings.json"), crewData, 0644); err != nil {
t.Fatalf("failed to write crew settings: %v", err)
}
// Create polecats-level settings (inherited by all polecats)
polecatsClaudeDir := filepath.Join(rigDir, "polecats", ".claude")
if err := os.MkdirAll(polecatsClaudeDir, 0755); err != nil {
t.Fatalf("failed to create polecats/.claude dir: %v", err)
}
polecatsSettings := ClaudeSettings{
Hooks: map[string][]ClaudeHookMatcher{
"PreToolUse": {
{
Matcher: "",
Hooks: []ClaudeHook{
{Type: "command", Command: "polecats-level-hook"},
},
},
},
},
}
polecatsData, _ := json.Marshal(polecatsSettings)
if err := os.WriteFile(filepath.Join(polecatsClaudeDir, "settings.json"), polecatsData, 0644); err != nil {
t.Fatalf("failed to write polecats settings: %v", err)
}
// Discover hooks
hooks, err := discoverHooks(tmpDir)
if err != nil {
t.Fatalf("discoverHooks failed: %v", err)
}
// Verify crew-level hook was discovered
var foundCrewLevel, foundPolecatsLevel bool
for _, h := range hooks {
if h.Agent == "testrig/crew" && len(h.Commands) > 0 && h.Commands[0] == "crew-level-hook" {
foundCrewLevel = true
}
if h.Agent == "testrig/polecats" && len(h.Commands) > 0 && h.Commands[0] == "polecats-level-hook" {
foundPolecatsLevel = true
}
}
if !foundCrewLevel {
t.Error("expected crew-level hook to be discovered (testrig/crew)")
}
if !foundPolecatsLevel {
t.Error("expected polecats-level hook to be discovered (testrig/polecats)")
}
}