533caf8e4b
* fix(witness): detect and ignore stale POLECAT_DONE messages Add timestamp validation to prevent witness from nuking newly spawned polecat sessions when processing stale POLECAT_DONE messages from previous sessions. - Add isStalePolecatDone() to compare message timestamp vs session created time - If message timestamp < session created time, message is stale and ignored - Add unit tests for timestamp parsing and stale detection logic Fixes #909 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mail): add --stale flag to gt mail archive Add ability to archive stale messages (sent before current session started). This prevents old messages from cycling forever in patrol inbox. Changes: - Add --stale and --dry-run flags to gt mail archive - Move stale detection helpers to internal/session/stale.go for reuse - Add ParseAddress to parse mail addresses into AgentIdentity - Add SessionCreatedAt to get tmux session start time Usage: gt mail archive --stale # Archive all stale messages gt mail archive --stale --dry-run # Preview what would be archived Co-Authored-By: GPT-5.2 Codex <noreply@openai.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: GPT-5.2 Codex <noreply@openai.com>
61 lines
1.6 KiB
Go
61 lines
1.6 KiB
Go
package session
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestParseTmuxSessionCreated(t *testing.T) {
|
|
input := "2026-01-24 01:02:03"
|
|
expected, err := time.ParseInLocation("2006-01-02 15:04:05", input, time.Local)
|
|
if err != nil {
|
|
t.Fatalf("parse expected: %v", err)
|
|
}
|
|
|
|
parsed, err := ParseTmuxSessionCreated(input)
|
|
if err != nil {
|
|
t.Fatalf("ParseTmuxSessionCreated: %v", err)
|
|
}
|
|
if !parsed.Equal(expected) {
|
|
t.Fatalf("parsed time mismatch: got %v want %v", parsed, expected)
|
|
}
|
|
}
|
|
|
|
func TestStaleReasonForTimes(t *testing.T) {
|
|
now := time.Date(2026, 1, 24, 2, 0, 0, 0, time.UTC)
|
|
newer := now.Add(2 * time.Minute)
|
|
older := now.Add(-2 * time.Minute)
|
|
|
|
t.Run("message before session", func(t *testing.T) {
|
|
stale, reason := StaleReasonForTimes(older, newer)
|
|
if !stale {
|
|
t.Fatalf("expected stale")
|
|
}
|
|
if !strings.Contains(reason, "message=") || !strings.Contains(reason, "session_started=") {
|
|
t.Fatalf("expected reason details, got %q", reason)
|
|
}
|
|
})
|
|
|
|
t.Run("message after session", func(t *testing.T) {
|
|
stale, reason := StaleReasonForTimes(newer, older)
|
|
if stale || reason != "" {
|
|
t.Fatalf("expected not stale, got %v %q", stale, reason)
|
|
}
|
|
})
|
|
|
|
t.Run("zero message time", func(t *testing.T) {
|
|
stale, reason := StaleReasonForTimes(time.Time{}, now)
|
|
if stale || reason != "" {
|
|
t.Fatalf("expected not stale for zero message time, got %v %q", stale, reason)
|
|
}
|
|
})
|
|
|
|
t.Run("zero session time", func(t *testing.T) {
|
|
stale, reason := StaleReasonForTimes(now, time.Time{})
|
|
if stale || reason != "" {
|
|
t.Fatalf("expected not stale for zero session time, got %v %q", stale, reason)
|
|
}
|
|
})
|
|
}
|