Files
gastown/internal/doctor/lifecycle_check.go
splendid acd2565a5b fix: remove vestigial state.json files from agent directories
Agent directories (witness/, refinery/, mayor/) contained state.json files
with last_active timestamps that were never updated, making them stale and
misleading. This change removes:

- initAgentStates function that created vestigial state.json files
- AgentState type and related Load/Save functions from config package
- MayorStateValidCheck from doctor checks
- requesting_* lifecycle verification (dead code - flags were never set)
- FileStateJSON constant and MayorStatePath function

Kept intact:
- daemon/state.json (actively used for daemon runtime state)
- crew/<name>/state.json (operational CrewWorker metadata)
- Agent state tracking via beads (the ZFC-compliant approach)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-04 10:36:23 -08:00

113 lines
2.8 KiB
Go

package doctor
import (
"encoding/json"
"fmt"
"os/exec"
"strings"
)
// LifecycleHygieneCheck detects and cleans up stale lifecycle state.
// This can happen when lifecycle messages weren't properly deleted after processing.
type LifecycleHygieneCheck struct {
FixableCheck
staleMessages []staleMessage
}
type staleMessage struct {
ID string
Subject string
From string
}
// NewLifecycleHygieneCheck creates a new lifecycle hygiene check.
func NewLifecycleHygieneCheck() *LifecycleHygieneCheck {
return &LifecycleHygieneCheck{
FixableCheck: FixableCheck{
BaseCheck: BaseCheck{
CheckName: "lifecycle-hygiene",
CheckDescription: "Check for stale lifecycle messages",
},
},
}
}
// Run checks for stale lifecycle state.
func (c *LifecycleHygieneCheck) Run(ctx *CheckContext) *CheckResult {
c.staleMessages = nil
// Check for stale lifecycle messages in deacon inbox
staleCount := c.checkDeaconInbox(ctx)
if staleCount == 0 {
return &CheckResult{
Name: c.Name(),
Status: StatusOK,
Message: "No stale lifecycle messages found",
}
}
return &CheckResult{
Name: c.Name(),
Status: StatusWarning,
Message: fmt.Sprintf("Found %d stale lifecycle message(s) in deacon inbox", staleCount),
FixHint: "Run 'gt doctor --fix' to clean up",
}
}
// checkDeaconInbox looks for stale lifecycle messages.
func (c *LifecycleHygieneCheck) checkDeaconInbox(ctx *CheckContext) int {
// Get deacon inbox via gt mail
cmd := exec.Command("gt", "mail", "inbox", "--identity", "deacon/", "--json")
cmd.Dir = ctx.TownRoot
output, err := cmd.Output()
if err != nil {
return 0 // Can't check, assume OK
}
if len(output) == 0 || string(output) == "[]" || string(output) == "[]\n" {
return 0
}
var messages []struct {
ID string `json:"id"`
From string `json:"from"`
Subject string `json:"subject"`
}
if err := json.Unmarshal(output, &messages); err != nil {
return 0
}
// Look for lifecycle messages
for _, msg := range messages {
if strings.HasPrefix(strings.ToLower(msg.Subject), "lifecycle:") {
c.staleMessages = append(c.staleMessages, staleMessage{
ID: msg.ID,
Subject: msg.Subject,
From: msg.From,
})
}
}
return len(c.staleMessages)
}
// Fix cleans up stale lifecycle messages.
func (c *LifecycleHygieneCheck) Fix(ctx *CheckContext) error {
var errors []string
// Delete stale lifecycle messages
for _, msg := range c.staleMessages {
cmd := exec.Command("gt", "mail", "delete", msg.ID) //nolint:gosec // G204: msg.ID is from internal state, not user input
cmd.Dir = ctx.TownRoot
if err := cmd.Run(); err != nil {
errors = append(errors, fmt.Sprintf("failed to delete message %s: %v", msg.ID, err))
}
}
if len(errors) > 0 {
return fmt.Errorf("%s", strings.Join(errors, "; "))
}
return nil
}