5ab01f383a
When the gt binary is built from a local fork (e.g., ~/src/gastown), the staleness check would incorrectly warn about being stale because it compared against the rig's repo HEAD. This confused agents. The fix detects fork builds by checking if the binary's embedded commit exists in the target repo. If not, the binary was built from a different repo and we report "fork build" instead of "stale". Changes: - Add IsForkBuild field to StaleBinaryInfo - Add commitExistsInRepo helper to detect fork scenarios - Update gt stale command to show "Binary built from fork" status - Update doctor check to report fork builds as OK Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
95 lines
2.6 KiB
Go
95 lines
2.6 KiB
Go
package doctor
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/steveyegge/gastown/internal/version"
|
|
)
|
|
|
|
// StaleBinaryCheck verifies the installed gt binary is up to date with the repo.
|
|
type StaleBinaryCheck struct {
|
|
FixableCheck
|
|
}
|
|
|
|
// NewStaleBinaryCheck creates a new stale binary check.
|
|
func NewStaleBinaryCheck() *StaleBinaryCheck {
|
|
return &StaleBinaryCheck{
|
|
FixableCheck: FixableCheck{
|
|
BaseCheck: BaseCheck{
|
|
CheckName: "stale-binary",
|
|
CheckDescription: "Check if gt binary is up to date with repo",
|
|
CheckCategory: CategoryInfrastructure,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
// Run checks if the binary is stale.
|
|
func (c *StaleBinaryCheck) Run(ctx *CheckContext) *CheckResult {
|
|
repoRoot, err := version.GetRepoRoot()
|
|
if err != nil {
|
|
return &CheckResult{
|
|
Name: c.Name(),
|
|
Status: StatusOK,
|
|
Message: "Cannot locate gt source repo (not a development environment)",
|
|
Details: []string{err.Error()},
|
|
}
|
|
}
|
|
|
|
info := version.CheckStaleBinary(repoRoot)
|
|
if info.Error != nil {
|
|
return &CheckResult{
|
|
Name: c.Name(),
|
|
Status: StatusOK,
|
|
Message: "Cannot determine binary version (dev build?)",
|
|
Details: []string{info.Error.Error()},
|
|
}
|
|
}
|
|
|
|
// Fork builds are fine - the binary was built from a different repo
|
|
if info.IsForkBuild {
|
|
return &CheckResult{
|
|
Name: c.Name(),
|
|
Status: StatusOK,
|
|
Message: fmt.Sprintf("Binary built from fork (%s)", version.ShortCommit(info.BinaryCommit)),
|
|
Details: []string{"Binary commit not in rig repo - likely built from local fork"},
|
|
}
|
|
}
|
|
|
|
if info.IsStale {
|
|
msg := fmt.Sprintf("Binary is stale (built from %s, repo at %s)",
|
|
version.ShortCommit(info.BinaryCommit), version.ShortCommit(info.RepoCommit))
|
|
if info.CommitsBehind > 0 {
|
|
msg = fmt.Sprintf("Binary is %d commits behind (built from %s, repo at %s)",
|
|
info.CommitsBehind, version.ShortCommit(info.BinaryCommit), version.ShortCommit(info.RepoCommit))
|
|
}
|
|
|
|
return &CheckResult{
|
|
Name: c.Name(),
|
|
Status: StatusWarning,
|
|
Message: msg,
|
|
FixHint: "Run 'gt install' to rebuild and install",
|
|
}
|
|
}
|
|
|
|
return &CheckResult{
|
|
Name: c.Name(),
|
|
Status: StatusOK,
|
|
Message: fmt.Sprintf("Binary is up to date (%s)", version.ShortCommit(info.BinaryCommit)),
|
|
}
|
|
}
|
|
|
|
// Fix rebuilds and installs gt.
|
|
func (c *StaleBinaryCheck) Fix(ctx *CheckContext) error {
|
|
// Note: We don't auto-fix this because:
|
|
// 1. It requires building and installing, which takes time
|
|
// 2. It modifies system files outside the workspace
|
|
// 3. User should explicitly run 'gt install'
|
|
return fmt.Errorf("run 'gt install' manually to rebuild")
|
|
}
|
|
|
|
// CanFix returns false - stale binary should be fixed manually.
|
|
func (c *StaleBinaryCheck) CanFix() bool {
|
|
return false
|
|
}
|