johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix PrefixOverride not respected in transaction storage layer (#1257)

Browse Source 
When creating issues with explicit IDs via PrefixOverride (for cross-rig
creation), the storage layer was still validating against the local
config prefix, causing errors like:

  issue ID 'da-DataArchive-witness' does not match configured prefix 'hq'

The queries.go layer already handled PrefixOverride correctly, but
transaction.go did not. This fix adds the same PrefixOverride handling
to transaction.go:

1. Check if PrefixOverride is set
2. If set, use it as the prefix and skip validation (caller knows best)
3. Otherwise, fall back to existing IDPrefix/configPrefix logic

This allows gt doctor --fix to create agent beads for non-local rigs.

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
justSteve
2026-01-22 15:04:52 -06:00
committed by GitHub
parent a597e013e0
commit 244b32b624
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
internal/storage/sqlite/transaction.go
View File

@@ -151,10 +151,16 @@ func (t *sqliteTxStorage) CreateIssue(ctx context.Context, issue *types.Issue, a
return fmt.Errorf("failed to get config: %w", err)
}
// Use IDPrefix override if set, combined with config prefix
// e.g., configPrefix="bd" + IDPrefix="wisp" → "bd-wisp"
// Determine prefix for ID generation and validation:
// 1. PrefixOverride completely replaces config prefix (for cross-rig creation)
// 2. IDPrefix appends to config prefix (e.g., "bd" + "wisp" → "bd-wisp")
// 3. Otherwise use config prefix as-is
prefix := configPrefix
if issue.IDPrefix != "" {
skipPrefixValidation := false
if issue.PrefixOverride != "" {
prefix = issue.PrefixOverride
skipPrefixValidation = true // Caller explicitly specified prefix, skip validation
} else if issue.IDPrefix != "" {
prefix = configPrefix + "-" + issue.IDPrefix
}
@@ -168,8 +174,11 @@ func (t *sqliteTxStorage) CreateIssue(ctx context.Context, issue *types.Issue, a
issue.ID = generatedID
} else {
// Validate that explicitly provided ID matches the configured prefix
if err := ValidateIssueIDPrefix(issue.ID, prefix); err != nil {
return fmt.Errorf("failed to validate issue ID prefix: %w", err)
// Skip validation when PrefixOverride is set (cross-rig creation)
if !skipPrefixValidation {
if err := ValidateIssueIDPrefix(issue.ID, prefix); err != nil {
return fmt.Errorf("failed to validate issue ID prefix: %w", err)
}
}
// For hierarchical IDs (bd-a3f8e9.1), ensure parent exists