test(sync): add unit tests for gitHasUncommittedBeadsChanges (bd-p7i2)

Extract parseGitStatusForBeadsChanges helper function from
gitHasUncommittedBeadsChanges to enable unit testing without git setup.

Add 14 test cases covering:
- Empty/no changes
- Modified files (staged, unstaged, both)
- Added files (staged, with modifications)
- Untracked files (should return false)
- Deleted files (should return false)
- Renamed/copied files
- Edge cases (short status line)

Part of GH#885 follow-up.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
ruby
2026-01-04 16:21:04 -08:00
committed by Steve Yegge
parent 6202711b5c
commit 32aea46ca6
2 changed files with 113 additions and 7 deletions

View File

@@ -466,12 +466,18 @@ func gitHasUncommittedBeadsChanges(ctx context.Context) (bool, error) {
return false, fmt.Errorf("git status failed: %w", err)
}
// Parse status output - look for modified/added files
// Format: XY filename where X=staged, Y=unstaged
// M = modified, A = added, ? = untracked
statusLine := strings.TrimSpace(string(output))
return parseGitStatusForBeadsChanges(string(output)), nil
}
// parseGitStatusForBeadsChanges parses git status --porcelain output and returns
// true if the status indicates uncommitted changes (modified or added).
// Format: XY filename where X=staged, Y=unstaged
// M = modified, A = added, ? = untracked, D = deleted
// Only M and A in either position indicate changes we care about.
func parseGitStatusForBeadsChanges(statusOutput string) bool {
statusLine := strings.TrimSpace(statusOutput)
if statusLine == "" {
return false, nil // No changes
return false // No changes
}
// Any status (M, A, MM, AM, etc.) indicates uncommitted changes
@@ -479,11 +485,11 @@ func gitHasUncommittedBeadsChanges(ctx context.Context) (bool, error) {
x, y := statusLine[0], statusLine[1]
// Check for modifications (staged or unstaged)
if x == 'M' || x == 'A' || y == 'M' || y == 'A' {
return true, nil
return true
}
}
return false, nil
return false
}
// getDefaultBranch returns the default branch name (main or master) for origin remote

100
cmd/bd/sync_git_test.go Normal file
View File

@@ -0,0 +1,100 @@
package main
import (
"testing"
)
func TestParseGitStatusForBeadsChanges(t *testing.T) {
tests := []struct {
name string
status string
expected bool
}{
// No changes
{
name: "empty status",
status: "",
expected: false,
},
{
name: "whitespace only",
status: " \n",
expected: false,
},
// Modified (should return true)
{
name: "staged modified",
status: "M .beads/issues.jsonl",
expected: true,
},
{
name: "unstaged modified",
status: " M .beads/issues.jsonl",
expected: true,
},
{
name: "staged and unstaged modified",
status: "MM .beads/issues.jsonl",
expected: true,
},
// Added (should return true)
{
name: "staged added",
status: "A .beads/issues.jsonl",
expected: true,
},
{
name: "added then modified",
status: "AM .beads/issues.jsonl",
expected: true,
},
// Untracked (should return false)
{
name: "untracked file",
status: "?? .beads/issues.jsonl",
expected: false,
},
// Deleted (should return false)
{
name: "staged deleted",
status: "D .beads/issues.jsonl",
expected: false,
},
{
name: "unstaged deleted",
status: " D .beads/issues.jsonl",
expected: false,
},
// Edge cases
{
name: "renamed file",
status: "R old.jsonl -> .beads/issues.jsonl",
expected: false,
},
{
name: "copied file",
status: "C source.jsonl -> .beads/issues.jsonl",
expected: false,
},
{
name: "status too short",
status: "M",
expected: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := parseGitStatusForBeadsChanges(tt.status)
if result != tt.expected {
t.Errorf("parseGitStatusForBeadsChanges(%q) = %v, want %v",
tt.status, result, tt.expected)
}
})
}
}