bd sync: 2026-01-10 13:36:47

.beads/issues.jsonl

@@ -114,6 +114,7 @@
 {"id":"bd-1tkd","title":"Code smell: ComputeContentHash() is 100+ lines of repetitive code","description":"attached_args: Refactor ComputeContentHash repetitive code\n\nThe ComputeContentHash() method in internal/types/types.go (lines 87-190) is over 100 lines of repetitive code:\n\n```go\nh.Write([]byte(i.Title))\nh.Write([]byte{0}) // separator\nh.Write([]byte(i.Description))\nh.Write([]byte{0})\nh.Write([]byte(i.Design))\n// ... repeated 40+ times\n```\n\nConsider:\n1. Using reflection to iterate over struct fields tagged for hashing\n2. Creating a helper function that takes field name and value\n3. Using a slice of fields to hash and iterating over it\n4. At minimum, extracting the repetitive pattern into a helper\n\nLocation: internal/types/types.go:87-190","status":"closed","priority":3,"issue_type":"chore","created_at":"2025-12-28T15:31:55.514941-08:00","created_by":"beads/crew/dave","updated_at":"2025-12-28T16:41:13.031194-08:00","closed_at":"2025-12-28T16:41:13.031194-08:00","dependencies":[{"issue_id":"bd-1tkd","depends_on_id":"bd-784c","type":"parent-child","created_at":"2025-12-28T15:38:04.204723-08:00","created_by":"daemon"}]}
 {"id":"bd-1tw","title":"Fix G104 errors unhandled in internal/storage/sqlite/queries.go:1186","description":"Linting issue: G104: Errors unhandled (gosec) at internal/storage/sqlite/queries.go:1186:2. Error: rows.Close()","status":"tombstone","priority":0,"issue_type":"bug","created_at":"2025-12-07T15:35:13.051671889-07:00","updated_at":"2025-12-25T01:21:01.952723-08:00","deleted_at":"2025-12-25T01:21:01.952723-08:00","deleted_by":"batch delete","delete_reason":"batch delete","original_type":"bug"}
 {"id":"bd-1u4","title":"Fix gosec lint warnings in doctor.go, main.go, and fix subdirectory","description":"CI lint job failing with 4 gosec warnings:\n- cmd/bd/doctor.go:664 (G304: file inclusion via variable)\n- cmd/bd/doctor/fix/database_config.go:166 (G304: file inclusion via variable)  \n- cmd/bd/doctor/fix/untracked.go:61 (G204: subprocess launched with variable)\n- cmd/bd/main.go:645 (G304: file inclusion via variable)\n\nEither suppress with `// #nosec` if false positives, or refactor to validate paths properly.","status":"closed","priority":2,"issue_type":"task","created_at":"2025-11-29T00:43:07.393406783-07:00","updated_at":"2025-11-29T23:31:20.977129-08:00","closed_at":"2025-11-29T23:31:16.4478-08:00"}
+{"id":"bd-1vc13","title":"Remove or integrate unused EnsureSocketDir/CleanupSocketDir functions","description":"Code review follow-up from GH#1001 fix.\n\nEnsureSocketDir() and CleanupSocketDir() in internal/rpc/socket_path.go are defined but never called:\n- Server's ensureSocketDir() in server_lifecycle_conn.go:144 already handles directory creation\n- Server's Stop() doesn't call CleanupSocketDir()\n\nOptions:\n1. Remove unused functions (YAGNI)\n2. Integrate them into server lifecycle\n3. Keep as exported API for future use\n\nRelated: GH#1001, commit 3ecffa11","status":"open","priority":3,"issue_type":"task","created_at":"2026-01-10T13:36:34.318095-08:00","created_by":"beads/crew/wolf","updated_at":"2026-01-10T13:36:34.318095-08:00"}
 {"id":"bd-1vup","title":"Test FK constraint via close","status":"closed","priority":4,"issue_type":"task","created_at":"2025-11-07T15:06:10.324045-08:00","updated_at":"2025-11-07T15:06:14.289835-08:00","closed_at":"2025-11-07T15:06:14.289835-08:00"}
 {"id":"bd-1vv","title":"Add WebSocket support","description":"## Feature Request\n\n[Describe the desired feature]\n\n## Motivation\n\n[Why is this feature needed? What problem does it solve?]\n\n## Use Cases\n\n1. **Use Case 1**: [description]\n2. **Use Case 2**: [description]\n\n## Proposed Solution\n\n[High-level approach to implementing this feature]\n\n## Alternatives Considered\n\n- **Alternative 1**: [description and why not chosen]\n- **Alternative 2**: [description and why not chosen]\n","status":"closed","priority":2,"issue_type":"feature","created_at":"2025-11-03T19:56:41.271215-08:00","updated_at":"2025-12-14T00:32:11.04773-08:00","closed_at":"2025-12-13T23:30:18.69345-08:00"}
 {"id":"bd-1wmwp","title":"Cost tracking performance and reliability improvements","description":"Post-merge improvements for the wisp-based cost tracking system (gt-cm900).\n\nThese are non-critical enhancements identified during code review.","status":"closed","priority":3,"issue_type":"epic","assignee":"mayor","created_at":"2026-01-08T22:54:54.812479-08:00","created_by":"mayor","updated_at":"2026-01-09T00:47:17.309176-08:00","closed_at":"2026-01-09T00:47:17.309176-08:00","close_reason":"All 4 child tasks completed and merged","dependencies":[{"issue_id":"bd-1wmwp","depends_on_id":"bd-3hqvs","type":"blocks","created_at":"2026-01-08T22:55:44.702562-08:00","created_by":"mayor"},{"issue_id":"bd-1wmwp","depends_on_id":"bd-i8zab","type":"blocks","created_at":"2026-01-08T22:55:44.730968-08:00","created_by":"mayor"},{"issue_id":"bd-1wmwp","depends_on_id":"bd-qv8f9","type":"blocks","created_at":"2026-01-08T22:55:44.758375-08:00","created_by":"mayor"},{"issue_id":"bd-1wmwp","depends_on_id":"bd-66z6a","type":"blocks","created_at":"2026-01-08T22:55:44.785431-08:00","created_by":"mayor"}]}
@@ -1210,6 +1211,7 @@
 {"id":"bd-keb","title":"Add database maintenance commands section to QUICKSTART.md","description":"**Problem:**\nUsers don't discover `bd compact` or `bd cleanup` commands until their database grows large. These maintenance commands aren't mentioned in quickstart documentation.\n\nRelated to issue #349 item #4.\n\n**Current state:**\ndocs/QUICKSTART.md ends at line 217 with \"See README.md for full documentation\" but has no mention of maintenance operations.\n\n**Proposed addition:**\nAdd a \"Database Maintenance\" section after line 140 (before \"Advanced: Agent Mail\" section) covering:\n- When database grows (many closed issues)\n- How to view compaction statistics\n- How to compact old issues\n- How to delete closed issues\n- Warning about permanence\n\n**Example content:**\n```markdown\n## Database Maintenance\n\nAs your project accumulates closed issues, the database grows. Use these commands to manage size:\n\n```bash\n# View compaction statistics\nbd compact --stats\n\n# Preview compaction candidates (30+ days closed)\nbd compact --analyze --json\n\n# Apply agent-generated summary\nbd compact --apply --id bd-42 --summary summary.txt\n\n# Immediately delete closed issues (use with caution!)\nbd cleanup --force\n```\n\n**When to compact:**\n- Database file \u003e 10MB with many old closed issues\n- After major project milestones\n- Before archiving a project phase\n```\n\n**Files to modify:**\n- docs/QUICKSTART.md (add section after line 140)","status":"closed","priority":3,"issue_type":"task","created_at":"2025-11-20T20:48:40.488512-05:00","updated_at":"2025-11-20T20:59:13.439462-05:00","closed_at":"2025-11-20T20:59:13.439462-05:00"}
 {"id":"bd-keob","title":"Session ended: gt-beads-crew-emma","status":"closed","priority":2,"issue_type":"event","created_at":"2026-01-07T00:31:59.245551-08:00","created_by":"beads/crew/emma","updated_at":"2026-01-07T00:31:59.398761-08:00","closed_at":"2026-01-07T00:31:59.398761-08:00","close_reason":"auto-closed session event"}
 {"id":"bd-kff0","title":"Integrate detect-pollution into bd doctor","description":"## Task\nMove `bd detect-pollution` → `bd doctor --check=pollution`\n\n## Current state\n- detect-pollution already shows deprecation hint pointing to doctor\n- Doctor command exists with multiple checks\n\n## Implementation\n\n### 1. Update doctor.go\n- Add pollution check to the doctor checks\n- Add `--check=pollution` flag option\n- Integrate detect-pollution logic\n\n### 2. Update detect_pollution.go\n- Mark as hidden (deprecated)\n- Forward to doctor --check=pollution\n- Keep for one release cycle\n\n### 3. Update docs\n- Remove detect-pollution from any command lists\n- Update doctor docs to include pollution check\n\n## Files to modify\n- cmd/bd/doctor.go\n- cmd/bd/detect_pollution.go\n","status":"closed","priority":2,"issue_type":"task","created_at":"2025-12-27T15:11:10.46326-08:00","created_by":"mayor","updated_at":"2025-12-27T16:04:58.471341-08:00","closed_at":"2025-12-27T16:04:58.471341-08:00"}
+{"id":"bd-kgjzm","title":"Daemon should cleanup /tmp/beads-* directories on shutdown","description":"Code review follow-up from GH#1001 fix.\n\nWhen using short socket paths (/tmp/beads-{hash}/bd.sock), the daemon creates directories in /tmp but doesn't clean them up on shutdown. These empty directories accumulate over time.\n\nThe CleanupSocketDir() function exists but isn't called from Server.Stop().\n\nShould:\n1. Call CleanupSocketDir() from server shutdown path\n2. Add integration test verifying cleanup happens\n\nRelated: GH#1001, commit 3ecffa11, bd-1vc13","status":"open","priority":3,"issue_type":"task","created_at":"2026-01-10T13:36:40.91827-08:00","created_by":"beads/crew/wolf","updated_at":"2026-01-10T13:36:40.91827-08:00"}
 {"id":"bd-khnb","title":"bd migrate --update-repo-id triggers auto-import that resurrects deleted issues","description":"**Bug:** Running `bd migrate --update-repo-id` can resurrect previously deleted issues from git history.\n\n## What Happened\n\nUser deleted 490 closed issues:\n- Deletion committed successfully (06d655a) with JSONL at 48 lines\n- Database had 48 issues after deletion\n- User ran `bd migrate --update-repo-id` to fix legacy database\n- Migration triggered daemon auto-import\n- JSONL had been restored to 538 issues (from commit 6cd3a32 - before deletion)\n- Auto-import loaded the old JSONL over the cleaned database\n- Result: 490 deleted issues resurrected\n\n## Root Cause\n\nThe auto-import logic in `cmd/bd/sync.go:130-136`:\n```go\nif isJSONLNewer(jsonlPath) {\n    fmt.Println(\"→ JSONL is newer than database, importing first...\")\n    if err := importFromJSONL(ctx, jsonlPath, renameOnImport); err != nil {\n```\n\nThis checks if JSONL mtime is newer than database and auto-imports. The problem:\n1. Git operations (pull, merge, checkout) can restore old JSONL files\n2. Restored file has recent mtime (time of git operation)\n3. Auto-import sees \"newer\" JSONL and imports it\n4. Old data overwrites current database state\n\n## Timeline\n\n- 19:59: Commit 6cd3a32 restored JSONL to 538 issues from d99222d\n- 20:22: Commit 3520321 (bd sync)\n- 20:23: Commit 06d655a deleted 490 issues → JSONL now 48 lines\n- 20:23: User ran `bd migrate --update-repo-id`\n- Migration completed, daemon started\n- Daemon saw JSONL (restored earlier to 538) was \"newer\" than database\n- Auto-import resurrected 490 deleted issues\n\n## Impact\n\n- **Critical data loss bug** - user deletions can be undone silently\n- Affects any workflow that uses git branches, merges, or checkouts\n- Auto-import has no safety checks against importing older data\n- Users have no warning that old data will overwrite current state\n\n## Fix Options\n\n1. **Content-based staleness** (not mtime-based)\n   - Compare JSONL content hash vs database content hash\n   - Only import if content actually changed\n   - Prevents re-importing old data with new mtime\n\n2. **Database timestamp check**\n   - Store \"last export timestamp\" in database metadata\n   - Only import JSONL if it's newer than last export\n   - Prevents importing old JSONL after git operations\n\n3. **User confirmation**\n   - Before auto-import, show diff of what will change\n   - Require confirmation for large changes (\u003e10% issues affected)\n   - Safety valve for destructive imports\n\n4. **Explicit sync mode**\n   - Disable auto-import entirely\n   - Require explicit `bd sync` or `bd import` commands\n   - Trade convenience for safety\n\n## Recommended Solution\n\nCombination of #1 and #2:\n- Add `last_export_timestamp` to database metadata\n- Check JSONL mtime \u003e last_export_timestamp before importing\n- Add content hash check as additional safety\n- Show warning if importing would delete \u003e10 issues\n\nThis preserves auto-import convenience while preventing data loss.\n\n## Files Involved\n\n- `cmd/bd/sync.go:130-136` - Auto-import logic\n- `cmd/bd/daemon_sync.go` - Daemon export/import cycle\n- `internal/autoimport/autoimport.go` - Staleness detection\n\n## Reproduction Steps\n\n1. Create and delete some issues, commit to git\n2. Checkout an earlier commit (before deletion)\n3. Checkout back to current commit\n4. JSONL file now has recent mtime but old content\n5. Run any bd command that triggers auto-import\n6. Deleted issues are resurrected","status":"closed","priority":0,"issue_type":"bug","created_at":"2025-11-20T20:44:35.235807-05:00","updated_at":"2025-11-20T21:51:31.806158-05:00","closed_at":"2025-11-20T21:51:31.806158-05:00"}
 {"id":"bd-kjons","title":"Session ended: gt-beads-crew-emma","status":"closed","priority":2,"issue_type":"event","created_at":"2026-01-09T00:50:13.727347-08:00","created_by":"beads/crew/emma","updated_at":"2026-01-09T00:50:13.762208-08:00","closed_at":"2026-01-09T00:50:13.762208-08:00","close_reason":"auto-closed session event"}
 {"id":"bd-kkka","title":"Dead code: fetchAndRebaseInWorktree() marked DEPRECATED but still exists","description":"attached_args: Remove dead code fetchAndRebaseInWorktree\n\nThe function fetchAndRebaseInWorktree() in internal/syncbranch/worktree.go (lines 811-830) is marked as DEPRECATED with a comment:\n\n```go\n// fetchAndRebaseInWorktree is DEPRECATED - kept for reference only.\n// Use contentMergeRecovery instead to avoid tombstone resurrection.\n```\n\nSince contentMergeRecovery() is the replacement and is being used, this dead code should be removed to reduce maintenance burden.\n\nLocation: internal/syncbranch/worktree.go:811-830","status":"closed","priority":3,"issue_type":"chore","created_at":"2025-12-28T15:32:21.97865-08:00","created_by":"beads/crew/dave","updated_at":"2025-12-28T16:41:36.721496-08:00","closed_at":"2025-12-28T16:41:36.721496-08:00","dependencies":[{"issue_id":"bd-kkka","depends_on_id":"bd-784c","type":"parent-child","created_at":"2025-12-28T15:38:04.241483-08:00","created_by":"daemon"}]}