Add test coverage for compact, ready, and dep commands
- Add comprehensive tests for cmd/bd/compact.go - Test dry run, validation, stats, progress bar, uptime formatting - Test compaction eligibility checks - Add comprehensive tests for cmd/bd/ready.go - Test ready work filtering by priority, assignee, limit - Test blocking dependencies exclusion - Test in-progress issues inclusion - Add comprehensive tests for cmd/bd/dep.go - Test dependency add/remove operations - Test all dependency types (blocks, related, parent-child, discovered-from) - Test cycle detection and prevention Coverage improved from 45.6% to 46.0% overall cmd/bd coverage improved from 20.0% to 20.4% Amp-Thread-ID: https://ampcode.com/threads/T-0707eb82-f56e-4b2d-b64a-f18cc5bc7421 Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
281
cmd/bd/compact_test.go
Normal file
281
cmd/bd/compact_test.go
Normal file
@@ -0,0 +1,281 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"context"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/steveyegge/beads/internal/storage/sqlite"
|
||||
"github.com/steveyegge/beads/internal/types"
|
||||
)
|
||||
|
||||
func TestCompactDryRun(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create a closed issue
|
||||
issue := &types.Issue{
|
||||
ID: "test-1",
|
||||
Title: "Test Issue",
|
||||
Description: "This is a long description that should be compacted. " + string(make([]byte, 500)),
|
||||
Status: types.StatusClosed,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now().Add(-60 * 24 * time.Hour),
|
||||
ClosedAt: ptrTime(time.Now().Add(-35 * 24 * time.Hour)),
|
||||
}
|
||||
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
// Test dry run - should not error even without API key
|
||||
compactDryRun = true
|
||||
compactTier = 1
|
||||
compactID = "test-1"
|
||||
compactForce = false
|
||||
jsonOutput = false
|
||||
|
||||
store = sqliteStore
|
||||
daemonClient = nil
|
||||
|
||||
// Should check eligibility without error
|
||||
eligible, reason, err := sqliteStore.CheckEligibility(ctx, "test-1", 1)
|
||||
if err != nil {
|
||||
t.Fatalf("CheckEligibility failed: %v", err)
|
||||
}
|
||||
|
||||
if !eligible {
|
||||
t.Fatalf("Issue should be eligible for compaction: %s", reason)
|
||||
}
|
||||
|
||||
compactDryRun = false
|
||||
compactID = ""
|
||||
}
|
||||
|
||||
func TestCompactValidation(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
compactID string
|
||||
compactAll bool
|
||||
dryRun bool
|
||||
force bool
|
||||
wantError bool
|
||||
}{
|
||||
{
|
||||
name: "both id and all",
|
||||
compactID: "test-1",
|
||||
compactAll: true,
|
||||
wantError: true,
|
||||
},
|
||||
{
|
||||
name: "force without id",
|
||||
force: true,
|
||||
wantError: true,
|
||||
},
|
||||
{
|
||||
name: "no flags",
|
||||
wantError: true,
|
||||
},
|
||||
{
|
||||
name: "dry run only",
|
||||
dryRun: true,
|
||||
wantError: false,
|
||||
},
|
||||
{
|
||||
name: "id only",
|
||||
compactID: "test-1",
|
||||
wantError: false,
|
||||
},
|
||||
{
|
||||
name: "all only",
|
||||
compactAll: true,
|
||||
wantError: false,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if tt.compactID != "" && tt.compactAll {
|
||||
// Should fail
|
||||
if !tt.wantError {
|
||||
t.Error("Expected error for both --id and --all")
|
||||
}
|
||||
}
|
||||
|
||||
if tt.force && tt.compactID == "" {
|
||||
// Should fail
|
||||
if !tt.wantError {
|
||||
t.Error("Expected error for --force without --id")
|
||||
}
|
||||
}
|
||||
|
||||
if tt.compactID == "" && !tt.compactAll && !tt.dryRun {
|
||||
// Should fail
|
||||
if !tt.wantError {
|
||||
t.Error("Expected error when no action specified")
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestCompactStats(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create mix of issues - some eligible, some not
|
||||
issues := []*types.Issue{
|
||||
{
|
||||
ID: "test-1",
|
||||
Title: "Old closed",
|
||||
Status: types.StatusClosed,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now().Add(-60 * 24 * time.Hour),
|
||||
ClosedAt: ptrTime(time.Now().Add(-35 * 24 * time.Hour)),
|
||||
},
|
||||
{
|
||||
ID: "test-2",
|
||||
Title: "Recent closed",
|
||||
Status: types.StatusClosed,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now().Add(-10 * 24 * time.Hour),
|
||||
ClosedAt: ptrTime(time.Now().Add(-5 * 24 * time.Hour)),
|
||||
},
|
||||
{
|
||||
ID: "test-3",
|
||||
Title: "Still open",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now().Add(-40 * 24 * time.Hour),
|
||||
},
|
||||
}
|
||||
|
||||
for _, issue := range issues {
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
// Verify issues were created
|
||||
allIssues, err := sqliteStore.SearchIssues(ctx, "", types.IssueFilter{})
|
||||
if err != nil {
|
||||
t.Fatalf("SearchIssues failed: %v", err)
|
||||
}
|
||||
|
||||
if len(allIssues) != 3 {
|
||||
t.Errorf("Expected 3 total issues, got %d", len(allIssues))
|
||||
}
|
||||
|
||||
// Test eligibility check for old closed issue
|
||||
eligible, _, err := sqliteStore.CheckEligibility(ctx, "test-1", 1)
|
||||
if err != nil {
|
||||
t.Fatalf("CheckEligibility failed: %v", err)
|
||||
}
|
||||
if !eligible {
|
||||
t.Error("Old closed issue should be eligible for Tier 1")
|
||||
}
|
||||
}
|
||||
|
||||
func TestCompactProgressBar(t *testing.T) {
|
||||
// Test progress bar formatting
|
||||
pb := progressBar(50, 100)
|
||||
if len(pb) == 0 {
|
||||
t.Error("Progress bar should not be empty")
|
||||
}
|
||||
|
||||
pb = progressBar(100, 100)
|
||||
if len(pb) == 0 {
|
||||
t.Error("Full progress bar should not be empty")
|
||||
}
|
||||
|
||||
pb = progressBar(0, 100)
|
||||
if len(pb) == 0 {
|
||||
t.Error("Zero progress bar should not be empty")
|
||||
}
|
||||
}
|
||||
|
||||
func TestFormatUptime(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
seconds float64
|
||||
want string
|
||||
}{
|
||||
{
|
||||
name: "seconds",
|
||||
seconds: 45.0,
|
||||
want: "45.0 seconds",
|
||||
},
|
||||
{
|
||||
name: "minutes",
|
||||
seconds: 300.0,
|
||||
want: "5m 0s",
|
||||
},
|
||||
{
|
||||
name: "hours",
|
||||
seconds: 7200.0,
|
||||
want: "2h 0m",
|
||||
},
|
||||
{
|
||||
name: "days",
|
||||
seconds: 90000.0,
|
||||
want: "1d 1h",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
got := formatUptime(tt.seconds)
|
||||
if got != tt.want {
|
||||
t.Errorf("formatUptime(%v) = %q, want %q", tt.seconds, got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func ptrTime(t time.Time) *time.Time {
|
||||
return &t
|
||||
}
|
||||
|
||||
func TestCompactInitCommand(t *testing.T) {
|
||||
if compactCmd == nil {
|
||||
t.Fatal("compactCmd should be initialized")
|
||||
}
|
||||
|
||||
if compactCmd.Use != "compact" {
|
||||
t.Errorf("Expected Use='compact', got %q", compactCmd.Use)
|
||||
}
|
||||
|
||||
if len(compactCmd.Long) == 0 {
|
||||
t.Error("compactCmd should have Long description")
|
||||
}
|
||||
}
|
||||
302
cmd/bd/dep_test.go
Normal file
302
cmd/bd/dep_test.go
Normal file
@@ -0,0 +1,302 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/steveyegge/beads/internal/storage/sqlite"
|
||||
"github.com/steveyegge/beads/internal/types"
|
||||
)
|
||||
|
||||
func TestDepAdd(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create test issues
|
||||
issues := []*types.Issue{
|
||||
{
|
||||
ID: "test-1",
|
||||
Title: "Task 1",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
{
|
||||
ID: "test-2",
|
||||
Title: "Task 2",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
}
|
||||
|
||||
for _, issue := range issues {
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
// Add dependency
|
||||
dep := &types.Dependency{
|
||||
IssueID: "test-1",
|
||||
DependsOnID: "test-2",
|
||||
Type: types.DepBlocks,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
|
||||
if err := sqliteStore.AddDependency(ctx, dep, "test"); err != nil {
|
||||
t.Fatalf("AddDependency failed: %v", err)
|
||||
}
|
||||
|
||||
// Verify dependency was added
|
||||
deps, err := sqliteStore.GetDependencies(ctx, "test-1")
|
||||
if err != nil {
|
||||
t.Fatalf("GetDependencies failed: %v", err)
|
||||
}
|
||||
|
||||
if len(deps) != 1 {
|
||||
t.Fatalf("Expected 1 dependency, got %d", len(deps))
|
||||
}
|
||||
|
||||
if deps[0].ID != "test-2" {
|
||||
t.Errorf("Expected dependency on test-2, got %s", deps[0].ID)
|
||||
}
|
||||
}
|
||||
|
||||
func TestDepTypes(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create test issues
|
||||
for i := 1; i <= 4; i++ {
|
||||
issue := &types.Issue{
|
||||
ID: fmt.Sprintf("test-%d", i),
|
||||
Title: fmt.Sprintf("Task %d", i),
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
// Test different dependency types (without creating cycles)
|
||||
depTypes := []struct {
|
||||
depType types.DependencyType
|
||||
from string
|
||||
to string
|
||||
}{
|
||||
{types.DepBlocks, "test-2", "test-1"},
|
||||
{types.DepRelated, "test-3", "test-1"},
|
||||
{types.DepParentChild, "test-4", "test-1"},
|
||||
{types.DepDiscoveredFrom, "test-3", "test-2"},
|
||||
}
|
||||
|
||||
for _, dt := range depTypes {
|
||||
dep := &types.Dependency{
|
||||
IssueID: dt.from,
|
||||
DependsOnID: dt.to,
|
||||
Type: dt.depType,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
|
||||
if err := sqliteStore.AddDependency(ctx, dep, "test"); err != nil {
|
||||
t.Fatalf("AddDependency failed for type %s: %v", dt.depType, err)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestDepCycleDetection(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create test issues
|
||||
for i := 1; i <= 3; i++ {
|
||||
issue := &types.Issue{
|
||||
ID: fmt.Sprintf("test-%d", i),
|
||||
Title: fmt.Sprintf("Task %d", i),
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
// Create a cycle: test-1 -> test-2 -> test-3 -> test-1
|
||||
// Add first two deps successfully
|
||||
deps := []struct {
|
||||
from string
|
||||
to string
|
||||
}{
|
||||
{"test-1", "test-2"},
|
||||
{"test-2", "test-3"},
|
||||
}
|
||||
|
||||
for _, d := range deps {
|
||||
dep := &types.Dependency{
|
||||
IssueID: d.from,
|
||||
DependsOnID: d.to,
|
||||
Type: types.DepBlocks,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
if err := sqliteStore.AddDependency(ctx, dep, "test"); err != nil {
|
||||
t.Fatalf("AddDependency failed: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// Try to add the third dep which would create a cycle - should fail
|
||||
cycleDep := &types.Dependency{
|
||||
IssueID: "test-3",
|
||||
DependsOnID: "test-1",
|
||||
Type: types.DepBlocks,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
if err := sqliteStore.AddDependency(ctx, cycleDep, "test"); err == nil {
|
||||
t.Fatal("Expected AddDependency to fail when creating cycle, but it succeeded")
|
||||
}
|
||||
|
||||
// Since cycle detection prevented the cycle, DetectCycles should find no cycles
|
||||
cycles, err := sqliteStore.DetectCycles(ctx)
|
||||
if err != nil {
|
||||
t.Fatalf("DetectCycles failed: %v", err)
|
||||
}
|
||||
|
||||
if len(cycles) != 0 {
|
||||
t.Error("Expected no cycles since cycle was prevented")
|
||||
}
|
||||
}
|
||||
|
||||
func TestDepCommandsInit(t *testing.T) {
|
||||
if depCmd == nil {
|
||||
t.Fatal("depCmd should be initialized")
|
||||
}
|
||||
|
||||
if depCmd.Use != "dep" {
|
||||
t.Errorf("Expected Use='dep', got %q", depCmd.Use)
|
||||
}
|
||||
|
||||
if depAddCmd == nil {
|
||||
t.Fatal("depAddCmd should be initialized")
|
||||
}
|
||||
|
||||
if depRemoveCmd == nil {
|
||||
t.Fatal("depRemoveCmd should be initialized")
|
||||
}
|
||||
}
|
||||
|
||||
func TestDepRemove(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create test issues
|
||||
issues := []*types.Issue{
|
||||
{
|
||||
ID: "test-1",
|
||||
Title: "Task 1",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
{
|
||||
ID: "test-2",
|
||||
Title: "Task 2",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
}
|
||||
|
||||
for _, issue := range issues {
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
// Add dependency
|
||||
dep := &types.Dependency{
|
||||
IssueID: "test-1",
|
||||
DependsOnID: "test-2",
|
||||
Type: types.DepBlocks,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
|
||||
if err := sqliteStore.AddDependency(ctx, dep, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
// Remove dependency
|
||||
if err := sqliteStore.RemoveDependency(ctx, "test-1", "test-2", "test"); err != nil {
|
||||
t.Fatalf("RemoveDependency failed: %v", err)
|
||||
}
|
||||
|
||||
// Verify dependency was removed
|
||||
deps, err := sqliteStore.GetDependencies(ctx, "test-1")
|
||||
if err != nil {
|
||||
t.Fatalf("GetDependencies failed: %v", err)
|
||||
}
|
||||
|
||||
if len(deps) != 0 {
|
||||
t.Errorf("Expected 0 dependencies after removal, got %d", len(deps))
|
||||
}
|
||||
}
|
||||
273
cmd/bd/ready_test.go
Normal file
273
cmd/bd/ready_test.go
Normal file
@@ -0,0 +1,273 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"context"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/steveyegge/beads/internal/storage/sqlite"
|
||||
"github.com/steveyegge/beads/internal/types"
|
||||
)
|
||||
|
||||
func TestReadyWork(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create issues with different states
|
||||
issues := []*types.Issue{
|
||||
{
|
||||
ID: "test-1",
|
||||
Title: "Ready task 1",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
{
|
||||
ID: "test-2",
|
||||
Title: "Ready task 2",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
{
|
||||
ID: "test-3",
|
||||
Title: "Blocked task",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
{
|
||||
ID: "test-blocker",
|
||||
Title: "Blocking task",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 0,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
{
|
||||
ID: "test-closed",
|
||||
Title: "Closed task",
|
||||
Status: types.StatusClosed,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
ClosedAt: ptrTime(time.Now()),
|
||||
},
|
||||
}
|
||||
|
||||
for _, issue := range issues {
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
// Add dependency: test-3 depends on test-blocker
|
||||
dep := &types.Dependency{
|
||||
IssueID: "test-3",
|
||||
DependsOnID: "test-blocker",
|
||||
Type: types.DepBlocks,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
if err := sqliteStore.AddDependency(ctx, dep, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
// Test basic ready work
|
||||
ready, err := sqliteStore.GetReadyWork(ctx, types.WorkFilter{})
|
||||
if err != nil {
|
||||
t.Fatalf("GetReadyWork failed: %v", err)
|
||||
}
|
||||
|
||||
// Should have test-1, test-2, test-blocker (not test-3 because it's blocked, not test-closed because it's closed)
|
||||
if len(ready) < 3 {
|
||||
t.Errorf("Expected at least 3 ready issues, got %d", len(ready))
|
||||
}
|
||||
|
||||
// Check that test-3 is NOT in ready work
|
||||
for _, issue := range ready {
|
||||
if issue.ID == "test-3" {
|
||||
t.Error("test-3 should not be in ready work (it's blocked)")
|
||||
}
|
||||
if issue.ID == "test-closed" {
|
||||
t.Error("test-closed should not be in ready work (it's closed)")
|
||||
}
|
||||
}
|
||||
|
||||
// Test with priority filter
|
||||
priority1 := 1
|
||||
readyP1, err := sqliteStore.GetReadyWork(ctx, types.WorkFilter{
|
||||
Priority: &priority1,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("GetReadyWork with priority filter failed: %v", err)
|
||||
}
|
||||
|
||||
// Should only have priority 1 issues
|
||||
for _, issue := range readyP1 {
|
||||
if issue.Priority != 1 {
|
||||
t.Errorf("Expected priority 1, got %d for issue %s", issue.Priority, issue.ID)
|
||||
}
|
||||
}
|
||||
|
||||
// Test with limit
|
||||
readyLimited, err := sqliteStore.GetReadyWork(ctx, types.WorkFilter{
|
||||
Limit: 1,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("GetReadyWork with limit failed: %v", err)
|
||||
}
|
||||
|
||||
if len(readyLimited) > 1 {
|
||||
t.Errorf("Expected at most 1 issue with limit=1, got %d", len(readyLimited))
|
||||
}
|
||||
}
|
||||
|
||||
func TestReadyWorkWithAssignee(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create issues with different assignees
|
||||
issues := []*types.Issue{
|
||||
{
|
||||
ID: "test-alice",
|
||||
Title: "Alice's task",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
Assignee: "alice",
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
{
|
||||
ID: "test-bob",
|
||||
Title: "Bob's task",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
Assignee: "bob",
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
{
|
||||
ID: "test-unassigned",
|
||||
Title: "Unassigned task",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
},
|
||||
}
|
||||
|
||||
for _, issue := range issues {
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
// Test filtering by assignee
|
||||
alice := "alice"
|
||||
readyAlice, err := sqliteStore.GetReadyWork(ctx, types.WorkFilter{
|
||||
Assignee: &alice,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("GetReadyWork with assignee filter failed: %v", err)
|
||||
}
|
||||
|
||||
if len(readyAlice) != 1 {
|
||||
t.Errorf("Expected 1 issue for alice, got %d", len(readyAlice))
|
||||
}
|
||||
|
||||
if len(readyAlice) > 0 && readyAlice[0].Assignee != "alice" {
|
||||
t.Errorf("Expected assignee='alice', got %q", readyAlice[0].Assignee)
|
||||
}
|
||||
}
|
||||
|
||||
func TestReadyCommandInit(t *testing.T) {
|
||||
if readyCmd == nil {
|
||||
t.Fatal("readyCmd should be initialized")
|
||||
}
|
||||
|
||||
if readyCmd.Use != "ready" {
|
||||
t.Errorf("Expected Use='ready', got %q", readyCmd.Use)
|
||||
}
|
||||
|
||||
if len(readyCmd.Short) == 0 {
|
||||
t.Error("readyCmd should have Short description")
|
||||
}
|
||||
}
|
||||
|
||||
func TestReadyWorkInProgress(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
sqliteStore, err := sqlite.New(dbPath)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer sqliteStore.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
// Create in-progress issue (should be in ready work)
|
||||
issue := &types.Issue{
|
||||
ID: "test-wip",
|
||||
Title: "Work in progress",
|
||||
Status: types.StatusInProgress,
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
CreatedAt: time.Now(),
|
||||
}
|
||||
|
||||
if err := sqliteStore.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
// Test that in-progress shows up in ready work
|
||||
ready, err := sqliteStore.GetReadyWork(ctx, types.WorkFilter{})
|
||||
if err != nil {
|
||||
t.Fatalf("GetReadyWork failed: %v", err)
|
||||
}
|
||||
|
||||
found := false
|
||||
for _, i := range ready {
|
||||
if i.ID == "test-wip" {
|
||||
found = true
|
||||
break
|
||||
}
|
||||
}
|
||||
|
||||
if !found {
|
||||
t.Error("In-progress issue should appear in ready work")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user