Fix errcheck warnings in cmd/bd/daemon.go

- Check error returns for client.Close() calls (3 instances)
- Check error returns for devNull.Close() calls (3 instances)
- Check error returns for tempFile.Close()
- Check error returns for logF.Close()
- Check error returns for fmt.Fprintf() calls (2 instances)
- Check error returns for lock.Close()
- Check error returns for f.Close()
- Check error returns for store.Close()
- Check error returns for os.Remove() calls (2 instances)

All errors are now properly handled or explicitly ignored with _.
This fixes the linting failures in CI.

Amp-Thread-ID: https://ampcode.com/threads/T-56b6d9f4-16a4-4c50-b7b9-dde1c3774650
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
2025-10-24 10:34:42 -07:00
parent 42480014b3
commit beb5dd91bf

View File

@@ -535,7 +535,7 @@ func migrateToGlobalDaemon() {
cmd.Stdout = devNull
cmd.Stderr = devNull
cmd.Stdin = devNull
defer devNull.Close()
defer func() { _ = devNull.Close() }()
}
configureDaemonProcess(cmd)
@@ -812,7 +812,7 @@ func runDaemonLoop(interval time.Duration, autoCommit, autoPush bool, logPath, p
log("Error acquiring daemon lock: %v", err)
os.Exit(1)
}
defer lock.Close()
defer func() { _ = lock.Close() }()
myPID := os.Getpid()
pidFileCreated := false
@@ -820,8 +820,8 @@ func runDaemonLoop(interval time.Duration, autoCommit, autoPush bool, logPath, p
for attempt := 0; attempt < 2; attempt++ {
f, err := os.OpenFile(pidFile, os.O_WRONLY|os.O_CREATE|os.O_EXCL, 0600)
if err == nil {
fmt.Fprintf(f, "%d", myPID)
f.Close()
_, _ = fmt.Fprintf(f, "%d", myPID)
_ = f.Close()
pidFileCreated = true
break
}
@@ -832,7 +832,7 @@ func runDaemonLoop(interval time.Duration, autoCommit, autoPush bool, logPath, p
os.Exit(1)
}
log("Stale PID file detected, removing and retrying")
os.Remove(pidFile)
_ = os.Remove(pidFile)
continue
}
@@ -845,7 +845,7 @@ func runDaemonLoop(interval time.Duration, autoCommit, autoPush bool, logPath, p
os.Exit(1)
}
defer os.Remove(pidFile)
defer func() { _ = os.Remove(pidFile) }()
log("Daemon started (interval: %v, auto-commit: %v, auto-push: %v)", interval, autoCommit, autoPush)
@@ -923,7 +923,7 @@ func runDaemonLoop(interval time.Duration, autoCommit, autoPush bool, logPath, p
log("Error: cannot open database: %v", err)
os.Exit(1)
}
defer store.Close()
defer func() { _ = store.Close() }()
log("Database opened: %s", daemonDBPath)
// Start RPC server